Re: [PATCH v1 13/18] media: hantro: Introduce G2/HEVC decoder

2021-02-18 Thread Dan Carpenter
On Wed, Feb 17, 2021 at 09:03:01AM +0100, Benjamin Gaignard wrote: > diff --git a/drivers/staging/media/hantro/hantro_drv.c > b/drivers/staging/media/hantro/hantro_drv.c > index e1443c394f62..d171fb80876a 100644 > --- a/drivers/staging/media/hantro/hantro_drv.c > +++

Re: [PATCH v1 13/18] media: hantro: Introduce G2/HEVC decoder

2021-02-18 Thread Benjamin Gaignard
Le 17/02/2021 à 21:45, Ezequiel Garcia a écrit : Hi Benjamin, Before I review the implementation in detail, there's one thing that looks suspicious. On Wed, 2021-02-17 at 09:03 +0100, Benjamin Gaignard wrote: Implement all the logic to get G2 hardware decoding HEVC frames. It support up

Re: [PATCH v1 13/18] media: hantro: Introduce G2/HEVC decoder

2021-02-17 Thread Ezequiel Garcia
Hi Benjamin, Before I review the implementation in detail, there's one thing that looks suspicious. On Wed, 2021-02-17 at 09:03 +0100, Benjamin Gaignard wrote: > Implement all the logic to get G2 hardware decoding HEVC frames. > It support up level 5.1 HEVC stream. > It doesn't support yet 10

[PATCH v1 13/18] media: hantro: Introduce G2/HEVC decoder

2021-02-17 Thread Benjamin Gaignard
Implement all the logic to get G2 hardware decoding HEVC frames. It support up level 5.1 HEVC stream. It doesn't support yet 10 bits formats or scaling feature. Add HANTRO HEVC dedicated control to skip some bits at the beginning of the slice header. That is very specific to this hardware so