Re: [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline

On Thu, Jan 18, 2018 at 02:03:07PM +0100, David Woodhouse wrote: > On Thu, 2018-01-18 at 05:01 -0800, Andi Kleen wrote: > > > > > > Side effect: [1/3] will move __x86_indirect_thunk_* functions > > > in kernel text area. Of course those functions were in the > > > .text area, but placed in right

Re: [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline

On Thu, Jan 18, 2018 at 02:03:07PM +0100, David Woodhouse wrote: > On Thu, 2018-01-18 at 05:01 -0800, Andi Kleen wrote: > > > > > > Side effect: [1/3] will move __x86_indirect_thunk_* functions > > > in kernel text area. Of course those functions were in the > > > .text area, but placed in right

Re: [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline

On Thu, 18 Jan 2018 05:01:57 -0800 Andi Kleen wrote: > > Side effect: [1/3] will move __x86_indirect_thunk_* functions > > in kernel text area. Of course those functions were in the > > .text area, but placed in right after _etext. This just moves > > it right before the

Re: [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline

On Thu, 18 Jan 2018 05:01:57 -0800 Andi Kleen wrote: > > Side effect: [1/3] will move __x86_indirect_thunk_* functions > > in kernel text area. Of course those functions were in the > > .text area, but placed in right after _etext. This just moves > > it right before the _etext. > > I assume

Re: [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline

On Thu, 2018-01-18 at 05:01 -0800, Andi Kleen wrote: > > > > Side effect: [1/3] will move __x86_indirect_thunk_* functions > > in kernel text area. Of course those functions were in the > > .text area, but placed in right after _etext. This just moves > > it right before the _etext. > I assume

Re: [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline

On Thu, 2018-01-18 at 05:01 -0800, Andi Kleen wrote: > > > > Side effect: [1/3] will move __x86_indirect_thunk_* functions > > in kernel text area. Of course those functions were in the > > .text area, but placed in right after _etext. This just moves > > it right before the _etext. > I assume

Re: [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline

> Side effect: [1/3] will move __x86_indirect_thunk_* functions > in kernel text area. Of course those functions were in the > .text area, but placed in right after _etext. This just moves > it right before the _etext. I assume you tested that with page table isolation on? The thunks need to be

Re: [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline

> Side effect: [1/3] will move __x86_indirect_thunk_* functions > in kernel text area. Of course those functions were in the > .text area, but placed in right after _etext. This just moves > it right before the _etext. I assume you tested that with page table isolation on? The thunks need to be

[PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline

Hi, This is a series of patches to fix kprobes issues on the kernel with CONFIG_RETPOLINE=y. - [1/3]: This introduces __x86_indirect_thunk_* boundary symbols so that kprobes easily identify those functions. - [2/3]: Mark __x86_indirect_thunk_* as blacklisted function for

[PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline

Hi, This is a series of patches to fix kprobes issues on the kernel with CONFIG_RETPOLINE=y. - [1/3]: This introduces __x86_indirect_thunk_* boundary symbols so that kprobes easily identify those functions. - [2/3]: Mark __x86_indirect_thunk_* as blacklisted function for