Re: [PATCH v2] ACPI / PCI: fix acpi_pci_irq_enable() memory leak

2019-09-03 Thread Rafael J. Wysocki
On Tue, Sep 3, 2019 at 12:34 AM Bjorn Helgaas wrote: > > On Mon, Sep 02, 2019 at 11:19:58PM +0200, Rafael J. Wysocki wrote: > > On Wed, Aug 21, 2019 at 5:44 AM Wenwen Wang wrote: > > > > > > In acpi_pci_irq_enable(), 'entry' is allocated by kzalloc() in > > > acpi_pci_irq_check_entry() (invoked

Re: [PATCH v2] ACPI / PCI: fix acpi_pci_irq_enable() memory leak

2019-09-02 Thread Bjorn Helgaas
On Mon, Sep 02, 2019 at 11:19:58PM +0200, Rafael J. Wysocki wrote: > On Wed, Aug 21, 2019 at 5:44 AM Wenwen Wang wrote: > > > > In acpi_pci_irq_enable(), 'entry' is allocated by kzalloc() in > > acpi_pci_irq_check_entry() (invoked from acpi_pci_irq_lookup()). However, > > it is not deallocated if

Re: [PATCH v2] ACPI / PCI: fix acpi_pci_irq_enable() memory leak

2019-09-02 Thread Rafael J. Wysocki
On Wed, Aug 21, 2019 at 5:44 AM Wenwen Wang wrote: > > In acpi_pci_irq_enable(), 'entry' is allocated by kzalloc() in > acpi_pci_irq_check_entry() (invoked from acpi_pci_irq_lookup()). However, > it is not deallocated if acpi_pci_irq_valid() returns false, leading to a > memory leak. To fix this

[PATCH v2] ACPI / PCI: fix acpi_pci_irq_enable() memory leak

2019-08-20 Thread Wenwen Wang
In acpi_pci_irq_enable(), 'entry' is allocated by kzalloc() in acpi_pci_irq_check_entry() (invoked from acpi_pci_irq_lookup()). However, it is not deallocated if acpi_pci_irq_valid() returns false, leading to a memory leak. To fix this issue, free 'entry' before returning 0. Fixes: e237a5518425