Re: [PATCH v2] iov_iter: don't revert iov buffer if csum error

2017-04-30 Thread David Miller
From: Al Viro Date: Sat, 29 Apr 2017 21:48:23 +0100 > On Sat, Apr 29, 2017 at 05:37:38PM +0800, Ding Tianhong wrote: > >> Looks good, if so, we don't need the csum_error any more, > > Acked-by: Al Viro > > Dave, I could put that through my

Re: [PATCH v2] iov_iter: don't revert iov buffer if csum error

2017-04-30 Thread David Miller
From: Al Viro Date: Sat, 29 Apr 2017 21:48:23 +0100 > On Sat, Apr 29, 2017 at 05:37:38PM +0800, Ding Tianhong wrote: > >> Looks good, if so, we don't need the csum_error any more, > > Acked-by: Al Viro > > Dave, I could put that through my tree, but I think it would be better off > in

Re: [PATCH v2] iov_iter: don't revert iov buffer if csum error

2017-04-29 Thread Al Viro
On Sat, Apr 29, 2017 at 05:37:38PM +0800, Ding Tianhong wrote: > Looks good, if so, we don't need the csum_error any more, Acked-by: Al Viro Dave, I could put that through my tree, but I think it would be better off in net.git; either way, it needs to go into mainline

Re: [PATCH v2] iov_iter: don't revert iov buffer if csum error

2017-04-29 Thread Al Viro
On Sat, Apr 29, 2017 at 05:37:38PM +0800, Ding Tianhong wrote: > Looks good, if so, we don't need the csum_error any more, Acked-by: Al Viro Dave, I could put that through my tree, but I think it would be better off in net.git; either way, it needs to go into mainline before -final...

Re: [PATCH v2] iov_iter: don't revert iov buffer if csum error

2017-04-29 Thread Ding Tianhong
On 2017/4/29 10:46, Al Viro wrote: > On Sat, Apr 29, 2017 at 10:38:48AM +0800, Ding Tianhong wrote: >> The patch 327868212381 (make skb_copy_datagram_msg() et.al. preserve >> ->msg_iter on error) will revert the iov buffer if copy to iter >> failed, but it didn't copy any datagram if the

Re: [PATCH v2] iov_iter: don't revert iov buffer if csum error

2017-04-29 Thread Ding Tianhong
On 2017/4/29 10:46, Al Viro wrote: > On Sat, Apr 29, 2017 at 10:38:48AM +0800, Ding Tianhong wrote: >> The patch 327868212381 (make skb_copy_datagram_msg() et.al. preserve >> ->msg_iter on error) will revert the iov buffer if copy to iter >> failed, but it didn't copy any datagram if the

Re: [PATCH v2] iov_iter: don't revert iov buffer if csum error

2017-04-28 Thread Al Viro
On Sat, Apr 29, 2017 at 10:38:48AM +0800, Ding Tianhong wrote: > The patch 327868212381 (make skb_copy_datagram_msg() et.al. preserve > ->msg_iter on error) will revert the iov buffer if copy to iter > failed, but it didn't copy any datagram if the skb_checksum_complete > error, so no need to

Re: [PATCH v2] iov_iter: don't revert iov buffer if csum error

2017-04-28 Thread Al Viro
On Sat, Apr 29, 2017 at 10:38:48AM +0800, Ding Tianhong wrote: > The patch 327868212381 (make skb_copy_datagram_msg() et.al. preserve > ->msg_iter on error) will revert the iov buffer if copy to iter > failed, but it didn't copy any datagram if the skb_checksum_complete > error, so no need to

[PATCH v2] iov_iter: don't revert iov buffer if csum error

2017-04-28 Thread Ding Tianhong
The patch 327868212381 (make skb_copy_datagram_msg() et.al. preserve ->msg_iter on error) will revert the iov buffer if copy to iter failed, but it didn't copy any datagram if the skb_checksum_complete error, so no need to revert any data at this place. v2: Sabrina notice that return -EFAULT when

[PATCH v2] iov_iter: don't revert iov buffer if csum error

2017-04-28 Thread Ding Tianhong
The patch 327868212381 (make skb_copy_datagram_msg() et.al. preserve ->msg_iter on error) will revert the iov buffer if copy to iter failed, but it didn't copy any datagram if the skb_checksum_complete error, so no need to revert any data at this place. v2: Sabrina notice that return -EFAULT when