Re: [PATCH v2] kprobes: avoid the kprobe being re-registered

2017-10-27 Thread zhouchengming
On 2017/10/27 13:57, Masami Hiramatsu wrote: On Fri, 27 Oct 2017 09:56:40 +0800 Zhou Chengming wrote: Changes from v1: - We should put the modifies of the kprobe after the re-reg check. - And then the address_safe check. - When check_kprobe_address_safe() return

Re: [PATCH v2] kprobes: avoid the kprobe being re-registered

2017-10-27 Thread zhouchengming
On 2017/10/27 13:57, Masami Hiramatsu wrote: On Fri, 27 Oct 2017 09:56:40 +0800 Zhou Chengming wrote: Changes from v1: - We should put the modifies of the kprobe after the re-reg check. - And then the address_safe check. - When check_kprobe_address_safe() return fail, the *probed_mod

Re: [PATCH v2] kprobes: avoid the kprobe being re-registered

2017-10-26 Thread Masami Hiramatsu
On Fri, 27 Oct 2017 09:56:40 +0800 Zhou Chengming wrote: > Changes from v1: > - We should put the modifies of the kprobe after the re-reg check. > - And then the address_safe check. > - When check_kprobe_address_safe() return fail, the *probed_mod > should be set to

Re: [PATCH v2] kprobes: avoid the kprobe being re-registered

2017-10-26 Thread Masami Hiramatsu
On Fri, 27 Oct 2017 09:56:40 +0800 Zhou Chengming wrote: > Changes from v1: > - We should put the modifies of the kprobe after the re-reg check. > - And then the address_safe check. > - When check_kprobe_address_safe() return fail, the *probed_mod > should be set to NULL, and no module

[PATCH v2] kprobes: avoid the kprobe being re-registered

2017-10-26 Thread Zhou Chengming
Changes from v1: - We should put the modifies of the kprobe after the re-reg check. - And then the address_safe check. - When check_kprobe_address_safe() return fail, the *probed_mod should be set to NULL, and no module refcount held. Old code use check_kprobe_rereg() to check if the kprobe has

[PATCH v2] kprobes: avoid the kprobe being re-registered

2017-10-26 Thread Zhou Chengming
Changes from v1: - We should put the modifies of the kprobe after the re-reg check. - And then the address_safe check. - When check_kprobe_address_safe() return fail, the *probed_mod should be set to NULL, and no module refcount held. Old code use check_kprobe_rereg() to check if the kprobe has