Re: [PATCH v2] psmouse: mitigate failing-mouse symptoms

2012-10-02 Thread Jim Hill
On 09/30/2012 11:02 AM, Alessandro Rubini wrote: >> I think this would be less controversial if the run-time default were >> to disable the feature. > > Yes, that's the common sensible path Fixed, there's no way I can test it well enough for anything more widespread. > Then, I think it would be

Re: [PATCH v2] psmouse: mitigate failing-mouse symptoms

2012-10-02 Thread Jim Hill
On 09/30/2012 11:02 AM, Alessandro Rubini wrote: I think this would be less controversial if the run-time default were to disable the feature. Yes, that's the common sensible path Fixed, there's no way I can test it well enough for anything more widespread. Then, I think it would be good to

Re: [PATCH v2] psmouse: mitigate failing-mouse symptoms

2012-09-30 Thread Alessandro Rubini
> I think this would be less controversial if the run-time default were > to disable the feature. Yes, that's the common sensible path to new little-tested features. As you say, it may become enabled by default over time. Then, I think it would be good to have a specific sub-structure for this

Re: [PATCH v2] psmouse: mitigate failing-mouse symptoms

2012-09-30 Thread Jonathan Nieder
Hi Jim, In January, 2011, Jim Hill wrote: > Keep a failing PS/2 mouse usable until it's convenient to replace it. > Filter incoming packets: drop invalid ones and attempt to correct for > dropped bytes. > > New parameter 'filter' makes filtering and logging selectable, set to 0 > to shut off all

Re: [PATCH v2] psmouse: mitigate failing-mouse symptoms

2012-09-30 Thread Jonathan Nieder
Hi Jim, In January, 2011, Jim Hill wrote: Keep a failing PS/2 mouse usable until it's convenient to replace it. Filter incoming packets: drop invalid ones and attempt to correct for dropped bytes. New parameter 'filter' makes filtering and logging selectable, set to 0 to shut off all

Re: [PATCH v2] psmouse: mitigate failing-mouse symptoms

2012-09-30 Thread Alessandro Rubini
I think this would be less controversial if the run-time default were to disable the feature. Yes, that's the common sensible path to new little-tested features. As you say, it may become enabled by default over time. Then, I think it would be good to have a specific sub-structure for this