Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-12-02 Thread Paul E. McKenney
On Wed, Dec 02, 2020 at 09:58:38AM -0500, Joel Fernandes wrote: > On Tue, Dec 01, 2020 at 08:21:43PM -0800, Paul E. McKenney wrote: > > On Tue, Dec 01, 2020 at 05:26:32PM -0500, Joel Fernandes wrote: > > > On Thu, Nov 19, 2020 at 3:42 PM Joel Fernandes > > > wrote: > > > > > > > > On Thu, Nov

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-12-02 Thread Joel Fernandes
On Tue, Dec 01, 2020 at 08:21:43PM -0800, Paul E. McKenney wrote: > On Tue, Dec 01, 2020 at 05:26:32PM -0500, Joel Fernandes wrote: > > On Thu, Nov 19, 2020 at 3:42 PM Joel Fernandes > > wrote: > > > > > > On Thu, Nov 19, 2020 at 12:16:15PM -0800, Paul E. McKenney wrote: > > > > On Thu, Nov 19,

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-12-01 Thread Paul E. McKenney
On Tue, Dec 01, 2020 at 05:26:32PM -0500, Joel Fernandes wrote: > On Thu, Nov 19, 2020 at 3:42 PM Joel Fernandes wrote: > > > > On Thu, Nov 19, 2020 at 12:16:15PM -0800, Paul E. McKenney wrote: > > > On Thu, Nov 19, 2020 at 02:44:35PM -0500, Joel Fernandes wrote: > > > > On Thu, Nov 19, 2020 at

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-12-01 Thread Joel Fernandes
On Thu, Nov 19, 2020 at 3:42 PM Joel Fernandes wrote: > > On Thu, Nov 19, 2020 at 12:16:15PM -0800, Paul E. McKenney wrote: > > On Thu, Nov 19, 2020 at 02:44:35PM -0500, Joel Fernandes wrote: > > > On Thu, Nov 19, 2020 at 2:22 PM Paul E. McKenney > > > wrote: > > > > > > > > On Wed, Nov 18,

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-19 Thread Joel Fernandes
On Thu, Nov 19, 2020 at 12:16:15PM -0800, Paul E. McKenney wrote: > On Thu, Nov 19, 2020 at 02:44:35PM -0500, Joel Fernandes wrote: > > On Thu, Nov 19, 2020 at 2:22 PM Paul E. McKenney wrote: > > > > > > > On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes (Google) > > > > > > > wrote: > >

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-19 Thread Paul E. McKenney
On Thu, Nov 19, 2020 at 02:44:35PM -0500, Joel Fernandes wrote: > On Thu, Nov 19, 2020 at 2:22 PM Paul E. McKenney wrote: > > > > > > On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes (Google) > > > > > > wrote: > > > > > > > After rcu_do_batch(), add a check for whether the seglen counts

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-19 Thread Joel Fernandes
On Thu, Nov 19, 2020 at 2:22 PM Paul E. McKenney wrote: > > > > > On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes (Google) > > > > > wrote: > > > > > > After rcu_do_batch(), add a check for whether the seglen counts > > > > > > went to > > > > > > zero if the list was indeed empty. > >

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-19 Thread Paul E. McKenney
On Thu, Nov 19, 2020 at 01:32:52PM -0500, Joel Fernandes wrote: > On Wed, Nov 18, 2020 at 07:56:13PM -0800, Paul E. McKenney wrote: > > On Wed, Nov 18, 2020 at 07:52:23PM -0800, Paul E. McKenney wrote: > > > On Wed, Nov 18, 2020 at 12:13:35PM -0800, Paul E. McKenney wrote: > > > > On Wed, Nov 18,

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-19 Thread Joel Fernandes
On Wed, Nov 18, 2020 at 07:56:13PM -0800, Paul E. McKenney wrote: > On Wed, Nov 18, 2020 at 07:52:23PM -0800, Paul E. McKenney wrote: > > On Wed, Nov 18, 2020 at 12:13:35PM -0800, Paul E. McKenney wrote: > > > On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes (Google) wrote: > > > > After

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-18 Thread Paul E. McKenney
On Wed, Nov 18, 2020 at 07:52:23PM -0800, Paul E. McKenney wrote: > On Wed, Nov 18, 2020 at 12:13:35PM -0800, Paul E. McKenney wrote: > > On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes (Google) wrote: > > > After rcu_do_batch(), add a check for whether the seglen counts went to > > >

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-18 Thread Paul E. McKenney
On Wed, Nov 18, 2020 at 12:13:35PM -0800, Paul E. McKenney wrote: > On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes (Google) wrote: > > After rcu_do_batch(), add a check for whether the seglen counts went to > > zero if the list was indeed empty. > > > > Signed-off-by: Joel Fernandes

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-18 Thread Paul E. McKenney
On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes (Google) wrote: > After rcu_do_batch(), add a check for whether the seglen counts went to > zero if the list was indeed empty. > > Signed-off-by: Joel Fernandes (Google) Queued for testing and further review, thank you!

[PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-18 Thread Joel Fernandes (Google)
After rcu_do_batch(), add a check for whether the seglen counts went to zero if the list was indeed empty. Signed-off-by: Joel Fernandes (Google) --- v1->v2: Added more debug checks. kernel/rcu/rcu_segcblist.c | 12 kernel/rcu/rcu_segcblist.h | 3 +++ kernel/rcu/tree.c |