Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-27 Thread Huang Rui
On Wed, Oct 28, 2015 at 01:34:18AM +0100, Borislav Petkov wrote: > On Tue, Oct 27, 2015 at 10:53:40AM +0800, Huang Rui wrote: > > Preemption must be disabled when calling smp_call_function_many, > > get_cpu would did that. Will get_online_cpus have the same behavior > > like that? > > Well,

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-27 Thread Borislav Petkov
On Tue, Oct 27, 2015 at 10:53:40AM +0800, Huang Rui wrote: > Preemption must be disabled when calling smp_call_function_many, > get_cpu would did that. Will get_online_cpus have the same behavior > like that? Well, get_online_cpus() protects you against CPU hotplug operations in general. If you

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-27 Thread Borislav Petkov
On Tue, Oct 27, 2015 at 10:53:40AM +0800, Huang Rui wrote: > Preemption must be disabled when calling smp_call_function_many, > get_cpu would did that. Will get_online_cpus have the same behavior > like that? Well, get_online_cpus() protects you against CPU hotplug operations in general. If you

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-27 Thread Huang Rui
On Wed, Oct 28, 2015 at 01:34:18AM +0100, Borislav Petkov wrote: > On Tue, Oct 27, 2015 at 10:53:40AM +0800, Huang Rui wrote: > > Preemption must be disabled when calling smp_call_function_many, > > get_cpu would did that. Will get_online_cpus have the same behavior > > like that? > > Well,

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-26 Thread Huang Rui
On Fri, Oct 23, 2015 at 03:27:02PM +0200, Borislav Petkov wrote: > On Tue, Oct 20, 2015 at 10:28:24AM +0800, Huang Rui wrote: > > This patch adds a member in fam15h_power_data which specifies the > > compute unit accumulated power. It adds do_read_registers_on_cu to do > > all the read to all MSRs

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-26 Thread Huang Rui
On Fri, Oct 23, 2015 at 03:27:02PM +0200, Borislav Petkov wrote: > On Tue, Oct 20, 2015 at 10:28:24AM +0800, Huang Rui wrote: > > This patch adds a member in fam15h_power_data which specifies the > > compute unit accumulated power. It adds do_read_registers_on_cu to do > > all the read to all MSRs

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-23 Thread Guenter Roeck
On 10/23/2015 06:27 AM, Borislav Petkov wrote: On Tue, Oct 20, 2015 at 10:28:24AM +0800, Huang Rui wrote: This patch adds a member in fam15h_power_data which specifies the compute unit accumulated power. It adds do_read_registers_on_cu to do all the read to all MSRs and run it on one of the

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-23 Thread Borislav Petkov
On Tue, Oct 20, 2015 at 10:28:24AM +0800, Huang Rui wrote: > This patch adds a member in fam15h_power_data which specifies the > compute unit accumulated power. It adds do_read_registers_on_cu to do > all the read to all MSRs and run it on one of the online cores on each > compute unit with

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-23 Thread Guenter Roeck
On 10/23/2015 06:27 AM, Borislav Petkov wrote: On Tue, Oct 20, 2015 at 10:28:24AM +0800, Huang Rui wrote: This patch adds a member in fam15h_power_data which specifies the compute unit accumulated power. It adds do_read_registers_on_cu to do all the read to all MSRs and run it on one of the

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-23 Thread Borislav Petkov
On Tue, Oct 20, 2015 at 10:28:24AM +0800, Huang Rui wrote: > This patch adds a member in fam15h_power_data which specifies the > compute unit accumulated power. It adds do_read_registers_on_cu to do > all the read to all MSRs and run it on one of the online cores on each > compute unit with

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-21 Thread Huang Rui
Hi Jean, On Wed, Oct 21, 2015 at 08:05:20AM +0200, Jean Delvare wrote: > Hi Rui, > > On Wed, 21 Oct 2015 11:04:01 +0800, Huang Rui wrote: > > On Tue, Oct 20, 2015 at 07:49:53PM -0700, Guenter Roeck wrote: > > > On 10/20/2015 07:40 PM, Huang Rui wrote: > > > >>>Thanks to report this issue. :) > >

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-21 Thread Jean Delvare
Hi Rui, On Wed, 21 Oct 2015 11:04:01 +0800, Huang Rui wrote: > On Tue, Oct 20, 2015 at 07:49:53PM -0700, Guenter Roeck wrote: > > On 10/20/2015 07:40 PM, Huang Rui wrote: > > >>>Thanks to report this issue. :) > > >>>The root cause is that the test config doesn't enable > > >>>CONFIG_CPU_SUP_AMD.

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-21 Thread Jean Delvare
Hi Rui, On Wed, 21 Oct 2015 11:04:01 +0800, Huang Rui wrote: > On Tue, Oct 20, 2015 at 07:49:53PM -0700, Guenter Roeck wrote: > > On 10/20/2015 07:40 PM, Huang Rui wrote: > > >>>Thanks to report this issue. :) > > >>>The root cause is that the test config doesn't enable > > >>>CONFIG_CPU_SUP_AMD.

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-21 Thread Huang Rui
Hi Jean, On Wed, Oct 21, 2015 at 08:05:20AM +0200, Jean Delvare wrote: > Hi Rui, > > On Wed, 21 Oct 2015 11:04:01 +0800, Huang Rui wrote: > > On Tue, Oct 20, 2015 at 07:49:53PM -0700, Guenter Roeck wrote: > > > On 10/20/2015 07:40 PM, Huang Rui wrote: > > > >>>Thanks to report this issue. :) > >

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-20 Thread Huang Rui
On Tue, Oct 20, 2015 at 07:49:53PM -0700, Guenter Roeck wrote: > On 10/20/2015 07:40 PM, Huang Rui wrote: > >On Tue, Oct 20, 2015 at 07:15:25PM -0700, Guenter Roeck wrote: > >>On 10/20/2015 06:42 PM, Huang Rui wrote: > >>>On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote: > Hi

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-20 Thread Guenter Roeck
On 10/20/2015 07:40 PM, Huang Rui wrote: On Tue, Oct 20, 2015 at 07:15:25PM -0700, Guenter Roeck wrote: On 10/20/2015 06:42 PM, Huang Rui wrote: On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote: Hi Huang, [auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-20 Thread Huang Rui
On Tue, Oct 20, 2015 at 07:15:25PM -0700, Guenter Roeck wrote: > On 10/20/2015 06:42 PM, Huang Rui wrote: > >On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote: > >>Hi Huang, > >> > >>[auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate base, > >>please suggest rules

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-20 Thread Guenter Roeck
On 10/20/2015 06:42 PM, Huang Rui wrote: On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote: Hi Huang, [auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url:

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-20 Thread Huang Rui
On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote: > Hi Huang, > > [auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate base, > please suggest rules for selecting the more suitable base] > > url: >

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-20 Thread kbuild test robot
Hi Huang, [auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Huang-Rui/hwmon-fam15h_power-Introduce-an-accumulated-power-reporting-algorithm/20151020-110712

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-20 Thread kbuild test robot
Hi Huang, [auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Huang-Rui/hwmon-fam15h_power-Introduce-an-accumulated-power-reporting-algorithm/20151020-110712

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-20 Thread Guenter Roeck
On 10/20/2015 06:42 PM, Huang Rui wrote: On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote: Hi Huang, [auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url:

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-20 Thread Huang Rui
On Tue, Oct 20, 2015 at 07:15:25PM -0700, Guenter Roeck wrote: > On 10/20/2015 06:42 PM, Huang Rui wrote: > >On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote: > >>Hi Huang, > >> > >>[auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate base, > >>please suggest rules

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-20 Thread Huang Rui
On Tue, Oct 20, 2015 at 07:49:53PM -0700, Guenter Roeck wrote: > On 10/20/2015 07:40 PM, Huang Rui wrote: > >On Tue, Oct 20, 2015 at 07:15:25PM -0700, Guenter Roeck wrote: > >>On 10/20/2015 06:42 PM, Huang Rui wrote: > >>>On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote: > Hi

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-20 Thread Huang Rui
On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote: > Hi Huang, > > [auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate base, > please suggest rules for selecting the more suitable base] > > url: >

Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-20 Thread Guenter Roeck
On 10/20/2015 07:40 PM, Huang Rui wrote: On Tue, Oct 20, 2015 at 07:15:25PM -0700, Guenter Roeck wrote: On 10/20/2015 06:42 PM, Huang Rui wrote: On Tue, Oct 20, 2015 at 03:24:09PM +0800, kbuild test robot wrote: Hi Huang, [auto build test ERROR on hwmon/hwmon-next -- if it's inappropriate

[PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-19 Thread Huang Rui
This patch adds a member in fam15h_power_data which specifies the compute unit accumulated power. It adds do_read_registers_on_cu to do all the read to all MSRs and run it on one of the online cores on each compute unit with smp_call_function_many(). This behavior can decrease IPI numbers.

[PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power

2015-10-19 Thread Huang Rui
This patch adds a member in fam15h_power_data which specifies the compute unit accumulated power. It adds do_read_registers_on_cu to do all the read to all MSRs and run it on one of the online cores on each compute unit with smp_call_function_many(). This behavior can decrease IPI numbers.