Re: [PATCH v2 07/10] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm

2015-10-26 Thread Huang Rui
On Fri, Oct 23, 2015 at 10:20:59PM +0800, Guenter Roeck wrote: > On 10/19/2015 07:28 PM, Huang Rui wrote: > > This patch introduces an algorithm that computes the average power by > > reading a delta value of “core power accumulator” register during > > measurement interval, and then dividing

Re: [PATCH v2 07/10] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm

2015-10-26 Thread Huang Rui
On Fri, Oct 23, 2015 at 10:20:59PM +0800, Guenter Roeck wrote: > On 10/19/2015 07:28 PM, Huang Rui wrote: > > This patch introduces an algorithm that computes the average power by > > reading a delta value of “core power accumulator” register during > > measurement interval, and then dividing

Re: [PATCH v2 07/10] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm

2015-10-25 Thread Borislav Petkov
On Mon, Oct 26, 2015 at 11:46:16AM +0800, Huang Rui wrote: > Actually, yes. I found it too long, so... :) Yeah, just try to apply some good, old-fashioned human common sense when looking at longer lines and deciding whether actually letting them stick out would be better for readability than

Re: [PATCH v2 07/10] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm

2015-10-25 Thread Huang Rui
On Fri, Oct 23, 2015 at 03:28:02PM +0200, Borislav Petkov wrote: > On Tue, Oct 20, 2015 at 10:28:26AM +0800, Huang Rui wrote: > > This patch introduces an algorithm that computes the average power by > > reading a delta value of “core power accumulator” register during > > measurement interval,

Re: [PATCH v2 07/10] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm

2015-10-25 Thread Huang Rui
On Fri, Oct 23, 2015 at 03:28:02PM +0200, Borislav Petkov wrote: > On Tue, Oct 20, 2015 at 10:28:26AM +0800, Huang Rui wrote: > > This patch introduces an algorithm that computes the average power by > > reading a delta value of “core power accumulator” register during > > measurement interval,

Re: [PATCH v2 07/10] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm

2015-10-25 Thread Borislav Petkov
On Mon, Oct 26, 2015 at 11:46:16AM +0800, Huang Rui wrote: > Actually, yes. I found it too long, so... :) Yeah, just try to apply some good, old-fashioned human common sense when looking at longer lines and deciding whether actually letting them stick out would be better for readability than

Re: [PATCH v2 07/10] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm

2015-10-23 Thread Guenter Roeck
On 10/19/2015 07:28 PM, Huang Rui wrote: This patch introduces an algorithm that computes the average power by reading a delta value of “core power accumulator” register during measurement interval, and then dividing delta value by the length of the time interval. User is able to use

Re: [PATCH v2 07/10] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm

2015-10-23 Thread Borislav Petkov
On Tue, Oct 20, 2015 at 10:28:26AM +0800, Huang Rui wrote: > This patch introduces an algorithm that computes the average power by > reading a delta value of “core power accumulator” register during > measurement interval, and then dividing delta value by the length of > the time interval. > >

Re: [PATCH v2 07/10] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm

2015-10-23 Thread Borislav Petkov
On Tue, Oct 20, 2015 at 10:28:26AM +0800, Huang Rui wrote: > This patch introduces an algorithm that computes the average power by > reading a delta value of “core power accumulator” register during > measurement interval, and then dividing delta value by the length of > the time interval. > >

Re: [PATCH v2 07/10] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm

2015-10-23 Thread Guenter Roeck
On 10/19/2015 07:28 PM, Huang Rui wrote: This patch introduces an algorithm that computes the average power by reading a delta value of “core power accumulator” register during measurement interval, and then dividing delta value by the length of the time interval. User is able to use

[PATCH v2 07/10] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm

2015-10-19 Thread Huang Rui
This patch introduces an algorithm that computes the average power by reading a delta value of “core power accumulator” register during measurement interval, and then dividing delta value by the length of the time interval. User is able to use power1_average entry to measure the processor power

[PATCH v2 07/10] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm

2015-10-19 Thread Huang Rui
This patch introduces an algorithm that computes the average power by reading a delta value of “core power accumulator” register during measurement interval, and then dividing delta value by the length of the time interval. User is able to use power1_average entry to measure the processor power