Re: [PATCH v2 10/11] drm/qxl: rework cursor plane

Hi, > > Well. I suspect I could easily spend a month cleaning up and party > > redesign the qxl driver (specifically qxl_draw.c + qxl_image.c). > > > > I'm not sure I'll find the time to actually do that anytime soon. > > I have plenty of other stuff on my TODO list, and given that the > >

Re: [PATCH v2 10/11] drm/qxl: rework cursor plane

Hi Am 18.02.21 um 12:50 schrieb Gerd Hoffmann: Hi, I'm still trying to wrap my head around the qxl cursor code. Getting vmap out of the commit tail is good, but I feel like this isn't going in the right direction overall. In ast, these helper functions were only good when converting the

Re: [PATCH v2 10/11] drm/qxl: rework cursor plane

Hi, > I'm still trying to wrap my head around the qxl cursor code. > > Getting vmap out of the commit tail is good, but I feel like this isn't > going in the right direction overall. > > In ast, these helper functions were only good when converting the drvier to > atomic modesetting. So I

Re: [PATCH v2 10/11] drm/qxl: rework cursor plane

Hi Am 17.02.21 um 13:32 schrieb Gerd Hoffmann: Add helper functions to create and move the cursor. Create the cursor_bo in prepare_fb callback, in the atomic_commit callback we only send the update command to the host. I'm still trying to wrap my head around the qxl cursor code. Getting vmap

[PATCH v2 10/11] drm/qxl: rework cursor plane

Add helper functions to create and move the cursor. Create the cursor_bo in prepare_fb callback, in the atomic_commit callback we only send the update command to the host. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_display.c | 248 -- 1 file changed,