Re: [PATCH v2 10/21] ipmi: kcs_bmc: Turn the driver data-structures inside-out

2021-04-11 Thread Andrew Jeffery
On Sat, 10 Apr 2021, at 04:56, Zev Weiss wrote: > On Fri, Apr 09, 2021 at 01:25:26AM CDT, Zev Weiss wrote: > >On Fri, Apr 09, 2021 at 12:59:09AM CDT, Andrew Jeffery wrote: > >>On Fri, 9 Apr 2021, at 13:27, Zev Weiss wrote: > >>>On Fri, Mar 19, 2021 at 01:27:41AM CDT, Andrew Jeffery wrote: >

Re: [PATCH v2 10/21] ipmi: kcs_bmc: Turn the driver data-structures inside-out

2021-04-09 Thread Zev Weiss
On Fri, Apr 09, 2021 at 01:25:26AM CDT, Zev Weiss wrote: >On Fri, Apr 09, 2021 at 12:59:09AM CDT, Andrew Jeffery wrote: >> >> >>On Fri, 9 Apr 2021, at 13:27, Zev Weiss wrote: >>>On Fri, Mar 19, 2021 at 01:27:41AM CDT, Andrew Jeffery wrote: Make the KCS device drivers responsible for allocating

Re: [PATCH v2 10/21] ipmi: kcs_bmc: Turn the driver data-structures inside-out

2021-04-09 Thread Zev Weiss
On Fri, Apr 09, 2021 at 12:59:09AM CDT, Andrew Jeffery wrote: > > >On Fri, 9 Apr 2021, at 13:27, Zev Weiss wrote: >> On Fri, Mar 19, 2021 at 01:27:41AM CDT, Andrew Jeffery wrote: >> >Make the KCS device drivers responsible for allocating their own memory. >> > >> >Until now the private data for

Re: [PATCH v2 10/21] ipmi: kcs_bmc: Turn the driver data-structures inside-out

2021-04-08 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 13:27, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:41AM CDT, Andrew Jeffery wrote: > >Make the KCS device drivers responsible for allocating their own memory. > > > >Until now the private data for the device driver was allocated internal > >to the private data for

Re: [PATCH v2 10/21] ipmi: kcs_bmc: Turn the driver data-structures inside-out

2021-04-08 Thread Zev Weiss
On Fri, Mar 19, 2021 at 01:27:41AM CDT, Andrew Jeffery wrote: >Make the KCS device drivers responsible for allocating their own memory. > >Until now the private data for the device driver was allocated internal >to the private data for the chardev interface. This coupling required >the slightly

[PATCH v2 10/21] ipmi: kcs_bmc: Turn the driver data-structures inside-out

2021-03-19 Thread Andrew Jeffery
Make the KCS device drivers responsible for allocating their own memory. Until now the private data for the device driver was allocated internal to the private data for the chardev interface. This coupling required the slightly awkward API of passing through the struct size for the driver private