Re: [PATCH v2 2/2] phy: intel-lgm-emmc: Add support for eMMC PHY

2019-08-20 Thread Ramuthevar, Vadivel MuruganX
On 20/8/2019 9:59 PM, Andy Shevchenko wrote: On Tue, Aug 20, 2019 at 04:56:02PM +0300, Andy Shevchenko wrote: On Tue, Aug 20, 2019 at 06:31:33PM +0800, Ramuthevar,Vadivel MuruganX wrote: +#define DR_TY_50OHM(x) ((~(x) << 28) & DR_TY_MASK) For consistency it should be #define

Re: [PATCH v2 2/2] phy: intel-lgm-emmc: Add support for eMMC PHY

2019-08-20 Thread Ramuthevar, Vadivel MuruganX
On 20/8/2019 9:56 PM, Andy Shevchenko wrote: On Tue, Aug 20, 2019 at 06:31:33PM +0800, Ramuthevar,Vadivel MuruganX wrote: From: Ramuthevar Vadivel Murugan Add support for eMMC PHY on Intel's Lightning Mountain SoC. Thanks for an update. Looks better though several minor comments below.

Re: [PATCH v2 2/2] phy: intel-lgm-emmc: Add support for eMMC PHY

2019-08-20 Thread Andy Shevchenko
On Tue, Aug 20, 2019 at 04:56:02PM +0300, Andy Shevchenko wrote: > On Tue, Aug 20, 2019 at 06:31:33PM +0800, Ramuthevar,Vadivel MuruganX wrote: > > +#define DR_TY_50OHM(x) ((~(x) << 28) & DR_TY_MASK) > > For consistency it should be > > #define DR_TY_SHIFT(x)(((x) <<

Re: [PATCH v2 2/2] phy: intel-lgm-emmc: Add support for eMMC PHY

2019-08-20 Thread Andy Shevchenko
On Tue, Aug 20, 2019 at 06:31:33PM +0800, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan > > Add support for eMMC PHY on Intel's Lightning Mountain SoC. Thanks for an update. Looks better though several minor comments below. > +/* eMMC phy register definitions */ >

[PATCH v2 2/2] phy: intel-lgm-emmc: Add support for eMMC PHY

2019-08-20 Thread Ramuthevar,Vadivel MuruganX
From: Ramuthevar Vadivel Murugan Add support for eMMC PHY on Intel's Lightning Mountain SoC. Signed-off-by: Ramuthevar Vadivel Murugan --- changes in v2: - optimize IS_CALDONE() and IS_DLLRDY() macro - remove unneccessary comment - remove redundant assignment - add return the error ptr