Re: [PATCH v2 2/2] platform/x86/drivers/acerhdf: Check the interval value when it is set

2020-12-07 Thread Daniel Lezcano
On 07/12/2020 15:54, Hans de Goede wrote: > Hi, > > On 12/4/20 12:43 PM, Daniel Lezcano wrote: >> On 03/12/2020 22:22, Peter Kästle wrote: >>> 3. Dezember 2020 08:17, "Daniel Lezcano" >>> schrieb: >>> Currently the code checks the interval value when the temperature is read which is

Re: [PATCH v2 2/2] platform/x86/drivers/acerhdf: Check the interval value when it is set

2020-12-07 Thread Hans de Goede
Hi, On 12/4/20 12:43 PM, Daniel Lezcano wrote: > On 03/12/2020 22:22, Peter Kästle wrote: >> 3. Dezember 2020 08:17, "Daniel Lezcano" schrieb: >> >>> Currently the code checks the interval value when the temperature is >>> read which is bad for two reasons: >>> >>> - checking and setting the

Re: [PATCH v2 2/2] platform/x86/drivers/acerhdf: Check the interval value when it is set

2020-12-04 Thread Daniel Lezcano
On 03/12/2020 22:22, Peter Kästle wrote: > 3. Dezember 2020 08:17, "Daniel Lezcano" schrieb: > >> Currently the code checks the interval value when the temperature is >> read which is bad for two reasons: >> >> - checking and setting the interval in the get_temp callback is >> inaccurate and

Re: [PATCH v2 2/2] platform/x86/drivers/acerhdf: Check the interval value when it is set

2020-12-03 Thread Peter Kästle
3. Dezember 2020 08:17, "Daniel Lezcano" schrieb: > Currently the code checks the interval value when the temperature is > read which is bad for two reasons: > > - checking and setting the interval in the get_temp callback is > inaccurate and awful, that can be done when changing the value. >

[PATCH v2 2/2] platform/x86/drivers/acerhdf: Check the interval value when it is set

2020-12-02 Thread Daniel Lezcano
Currently the code checks the interval value when the temperature is read which is bad for two reasons: - checking and setting the interval in the get_temp callback is inaccurate and awful, that can be done when changing the value. - Changing the thermal zone structure internals is an abuse