Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-10-14 Thread Dilip Kota
Hi Philipp, On 10/8/2019 11:56 PM, Philipp Zabel wrote: Hi Martin, On Mon, 2019-10-07 at 21:53 +0200, Martin Blumenstingl wrote: Hi Philipp, On Thu, Oct 3, 2019 at 4:19 PM Philipp Zabel wrote: [...] because the register layout was greatly simplified for the newer SoCs (for which there is

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-10-08 Thread Philipp Zabel
Hi Martin, On Mon, 2019-10-07 at 21:53 +0200, Martin Blumenstingl wrote: > Hi Philipp, > > On Thu, Oct 3, 2019 at 4:19 PM Philipp Zabel wrote: > [...] > > > because the register layout was greatly simplified for the newer SoCs > > > (for which there is reset-intel) compared to the older ones >

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-10-07 Thread Dilip Kota
Hi Martin,Philipp, On 10/8/2019 3:53 AM, Martin Blumenstingl wrote: Hi Philipp, On Thu, Oct 3, 2019 at 4:19 PM Philipp Zabel wrote: [...] because the register layout was greatly simplified for the newer SoCs (for which there is reset-intel) compared to the older ones (reset-lantiq). Dilip's

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-10-07 Thread Martin Blumenstingl
Hi Philipp, On Thu, Oct 3, 2019 at 4:19 PM Philipp Zabel wrote: [...] > > because the register layout was greatly simplified for the newer SoCs > > (for which there is reset-intel) compared to the older ones > > (reset-lantiq). > > Dilip's suggestion (in my own words) is that you take his new >

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-10-03 Thread Philipp Zabel
Hi Martin, Dilip, On Thu, Sep 19, 2019 at 09:51:48PM +0200, Martin Blumenstingl wrote: > Hi Dilip, > > (sorry for the late reply) Same, sorry for the delay. > On Thu, Sep 12, 2019 at 8:38 AM Dilip Kota > wrote: > [...] > > The major difference between the vrx200 and lgm is: > > 1.) RCU in

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-10-03 Thread Dilip Kota
Hi Martin and Philipp, On 20/9/2019 10:47 AM, Dilip Kota wrote: Hi Martin, On 9/20/2019 3:51 AM, Martin Blumenstingl wrote: Hi Dilip, (sorry for the late reply) On Thu, Sep 12, 2019 at 8:38 AM Dilip Kota wrote: [...] The major difference between the vrx200 and lgm is: 1.) RCU in vrx200

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-09-19 Thread Dilip Kota
Hi Martin, On 9/20/2019 3:51 AM, Martin Blumenstingl wrote: Hi Dilip, (sorry for the late reply) On Thu, Sep 12, 2019 at 8:38 AM Dilip Kota wrote: [...] The major difference between the vrx200 and lgm is: 1.) RCU in vrx200 is having multiple register regions wheres RCU in lgm has one single

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-09-19 Thread Martin Blumenstingl
Hi Dilip, (sorry for the late reply) On Thu, Sep 12, 2019 at 8:38 AM Dilip Kota wrote: [...] > The major difference between the vrx200 and lgm is: > 1.) RCU in vrx200 is having multiple register regions wheres RCU in lgm > has one single register region. > 2.) Register offsets and bit offsets

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-09-19 Thread Dilip Kota
; linux- ker...@vger.kernel.org; p.za...@pengutronix.de; Wu, Qiming ; r...@kernel.org; Hauke Mehrtens Subject: Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC Hi Martin, On 9/12/2019 2:38 PM, Dilip Kota wrote: Re-sending the mail, because of delivery failure. sorry for the spam

RE: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-09-19 Thread Langer, Thomas
nel.org; linux- > ker...@vger.kernel.org; p.za...@pengutronix.de; Wu, Qiming ming...@intel.com>; r...@kernel.org; Hauke Mehrtens > Subject: Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM > SoC > > Hi Martin, > > On 9/12/2019 2:38 PM, Dilip Kota wrote: > &g

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-09-19 Thread Dilip Kota
Hi Martin, On 9/12/2019 2:38 PM, Dilip Kota wrote: Re-sending the mail, because of delivery failure. sorry for the spam. Hi Martin, On 9/6/2019 4:53 AM, Martin Blumenstingl wrote: Hi, On Thu, Sep 5, 2019 at 4:38 AM Chuan Hua, Lei wrote: [...] I'm not surprised that we got some of the IP

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-09-12 Thread Dilip Kota
Re-sending the mail, because of delivery failure. sorry for the spam. Hi Martin, On 9/6/2019 4:53 AM, Martin Blumenstingl wrote: Hi, On Thu, Sep 5, 2019 at 4:38 AM Chuan Hua, Lei wrote: [...] I'm not surprised that we got some of the IP block layout for the VRX200 RCU "wrong" - all

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-09-05 Thread Martin Blumenstingl
Hi, On Thu, Sep 5, 2019 at 4:38 AM Chuan Hua, Lei wrote: [...] > >>> I'm not surprised that we got some of the IP block layout for the > >>> VRX200 RCU "wrong" - all "documentation" we have is the old Lantiq UGW > >>> (BSP). > >>> with proper documentation (as in a "public

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-09-04 Thread Chuan Hua, Lei
Hi Martin, On 9/3/2019 6:04 AM, Martin Blumenstingl wrote: Hi, On Mon, Sep 2, 2019 at 11:45 AM Chuan Hua, Lei wrote: Hi Martin, On 9/2/2019 5:38 AM, Martin Blumenstingl wrote: Hi, On Fri, Aug 30, 2019 at 5:02 AM Chuan Hua, Lei wrote: Hi Martin, On 8/30/2019 5:40 AM, Martin

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-09-02 Thread Martin Blumenstingl
Hi, On Mon, Sep 2, 2019 at 11:45 AM Chuan Hua, Lei wrote: > > Hi Martin, > > > On 9/2/2019 5:38 AM, Martin Blumenstingl wrote: > > Hi, > > > > On Fri, Aug 30, 2019 at 5:02 AM Chuan Hua, Lei > > wrote: > >> Hi Martin, > >> > >> On 8/30/2019 5:40 AM, Martin Blumenstingl wrote: > >>> Hi, > >>> >

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-09-02 Thread Chuan Hua, Lei
Hi Martin, On 9/2/2019 5:38 AM, Martin Blumenstingl wrote: Hi, On Fri, Aug 30, 2019 at 5:02 AM Chuan Hua, Lei wrote: Hi Martin, On 8/30/2019 5:40 AM, Martin Blumenstingl wrote: Hi, On Thu, Aug 29, 2019 at 4:51 AM Chuan Hua, Lei wrote: I'm not surprised that we got some of the IP block

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-09-01 Thread Martin Blumenstingl
Hi, On Fri, Aug 30, 2019 at 5:02 AM Chuan Hua, Lei wrote: > > Hi Martin, > > On 8/30/2019 5:40 AM, Martin Blumenstingl wrote: > > Hi, > > > > On Thu, Aug 29, 2019 at 4:51 AM Chuan Hua, Lei > > wrote: > > > >>> I'm not surprised that we got some of the IP block layout for the > >>> VRX200 RCU

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-29 Thread Chuan Hua, Lei
Hi Martin, On 8/30/2019 5:40 AM, Martin Blumenstingl wrote: Hi, On Thu, Aug 29, 2019 at 4:51 AM Chuan Hua, Lei wrote: I'm not surprised that we got some of the IP block layout for the VRX200 RCU "wrong" - all "documentation" we have is the old Lantiq UGW (BSP). with proper documentation (as

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-29 Thread Martin Blumenstingl
Hi, On Thu, Aug 29, 2019 at 4:51 AM Chuan Hua, Lei wrote: > > > > I'm not surprised that we got some of the IP block layout for the > > VRX200 RCU "wrong" - all "documentation" we have is the old Lantiq UGW > > (BSP). > > with proper documentation (as in a "public datasheet for the SoC") it > >

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-28 Thread Chuan Hua, Lei
On 8/29/2019 4:01 AM, Martin Blumenstingl wrote: Hi, On Wed, Aug 28, 2019 at 3:53 AM Chuan Hua, Lei wrote: [...] 1. reset-lantiq.c use index instead of register offset + bit position. index reset is good for a small system (< 64). However, it will become very difficult to use if you have >

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-28 Thread Martin Blumenstingl
Hi, On Wed, Aug 28, 2019 at 3:53 AM Chuan Hua, Lei wrote: [...] > 1. reset-lantiq.c use index instead of register offset + bit position. > index reset is good for a small system (< 64). However, it will become > very > difficult to use if you have > 100 reset. So we use

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-27 Thread Chuan Hua, Lei
Hi Martin, On 8/28/2019 5:15 AM, Martin Blumenstingl wrote: Hi, On Tue, Aug 27, 2019 at 4:23 AM Chuan Hua, Lei wrote: [...] 1. reset-lantiq.c use index instead of register offset + bit position. index reset is good for a small system (< 64). However, it will become very difficult to use if

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-27 Thread Martin Blumenstingl
Hi, On Tue, Aug 27, 2019 at 4:23 AM Chuan Hua, Lei wrote: [...] > >> 1. reset-lantiq.c use index instead of register offset + bit position. > >> index reset is good for a small system (< 64). However, it will become very > >> difficult to use if you have > 100 reset. So we use register offset +

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-26 Thread Chuan Hua, Lei
Hi Martin, Please check the reply below. On 8/27/2019 5:49 AM, Martin Blumenstingl wrote: Hi, On Mon, Aug 26, 2019 at 6:01 AM Chuan Hua, Lei wrote: Hi Martin, Thanks for your comment. thank you for the quick reply On 8/25/2019 5:11 AM, Martin Blumenstingl wrote: Hi Dilip, Add driver

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-26 Thread Martin Blumenstingl
Hi, On Mon, Aug 26, 2019 at 6:01 AM Chuan Hua, Lei wrote: > > Hi Martin, > > Thanks for your comment. thank you for the quick reply > On 8/25/2019 5:11 AM, Martin Blumenstingl wrote: > > Hi Dilip, > > > >> Add driver for the reset controller present on Intel > >> Lightening Mountain (LGM) SoC

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-26 Thread Dilip Kota
On 8/23/2019 6:09 PM, Philipp Zabel wrote: On Fri, 2019-08-23 at 17:47 +0800, Dilip Kota wrote: [...] Thanks for pointing it out. Reset is not supported on LGM platform. I will update the reset_device() definition to "return -EOPNOTSUPP" In that case you can just drop intel_reset_device()

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-25 Thread Chuan Hua, Lei
Hi Martin, Thanks for your comment. On 8/25/2019 5:11 AM, Martin Blumenstingl wrote: Hi Dilip, Add driver for the reset controller present on Intel Lightening Mountain (LGM) SoC for performing reset management of the devices present on the SoC. Driver also registers a reset handler to peform

RE: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-24 Thread Martin Blumenstingl
Hi Dilip, > Add driver for the reset controller present on Intel > Lightening Mountain (LGM) SoC for performing reset > management of the devices present on the SoC. Driver also > registers a reset handler to peform the entire device reset. [...] > +static const struct of_device_id

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-23 Thread Philipp Zabel
On Fri, 2019-08-23 at 17:47 +0800, Dilip Kota wrote: [...] > Thanks for pointing it out. > Reset is not supported on LGM platform. > I will update the reset_device() definition to "return -EOPNOTSUPP" In that case you can just drop intel_reset_device() completely, the core checks whether

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-23 Thread Dilip Kota
Hi Philipp, On 8/23/2019 4:43 PM, Philipp Zabel wrote: Hi Dilip, On Fri, 2019-08-23 at 13:28 +0800, Dilip Kota wrote: Add driver for the reset controller present on Intel Lightening Mountain (LGM) SoC for performing reset management of the devices present on the SoC. Driver also registers a

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-23 Thread Philipp Zabel
Hi Dilip, On Fri, 2019-08-23 at 13:28 +0800, Dilip Kota wrote: > Add driver for the reset controller present on Intel > Lightening Mountain (LGM) SoC for performing reset > management of the devices present on the SoC. Driver also > registers a reset handler to peform the entire device reset. >

[PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-08-22 Thread Dilip Kota
Add driver for the reset controller present on Intel Lightening Mountain (LGM) SoC for performing reset management of the devices present on the SoC. Driver also registers a reset handler to peform the entire device reset. Signed-off-by: Dilip Kota --- Changes on v2: No changes