Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-23 Thread Masahiro Yamada
2015-10-23 0:34 GMT+09:00 Rob Herring : > On Tue, Oct 20, 2015 at 8:20 PM, Masahiro Yamada > wrote: >> Hi Peter, >> (+ Rob Herring, Stefan Agner) >> >> 2015-10-20 23:00 GMT+09:00 Peter Hurley : >>> On 10/19/2015 11:36 PM, Masahiro Yamada wrote: The input clock frequency varies from device to

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-23 Thread Masahiro Yamada
2015-10-23 0:34 GMT+09:00 Rob Herring : > On Tue, Oct 20, 2015 at 8:20 PM, Masahiro Yamada > wrote: >> Hi Peter, >> (+ Rob Herring, Stefan Agner) >> >> 2015-10-20 23:00 GMT+09:00 Peter Hurley : >>> On 10/19/2015 11:36 PM,

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-22 Thread Rob Herring
On Tue, Oct 20, 2015 at 8:20 PM, Masahiro Yamada wrote: > Hi Peter, > (+ Rob Herring, Stefan Agner) > > 2015-10-20 23:00 GMT+09:00 Peter Hurley : >> On 10/19/2015 11:36 PM, Masahiro Yamada wrote: >>> The input clock frequency varies from device to device, but the >>> earlycon uses the fixed

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-22 Thread Rob Herring
On Tue, Oct 20, 2015 at 8:20 PM, Masahiro Yamada wrote: > Hi Peter, > (+ Rob Herring, Stefan Agner) > > 2015-10-20 23:00 GMT+09:00 Peter Hurley : >> On 10/19/2015 11:36 PM, Masahiro Yamada wrote: >>> The input clock frequency varies from

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-21 Thread Masahiro Yamada
Hi Peter, 2015-10-22 0:35 GMT+09:00 Peter Hurley : > Hi Masahiro, > > On 10/21/2015 11:31 AM, Masahiro Yamada wrote: >> If it is always correct to preserve the initialization done by boot-loader, >> the following code in 8250_early.c does not make sense. > > It's not always correct to preserve

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-21 Thread Peter Hurley
Hi Masahiro, On 10/21/2015 11:31 AM, Masahiro Yamada wrote: > If it is always correct to preserve the initialization done by boot-loader, > the following code in 8250_early.c does not make sense. It's not always correct to preserve the initialization by the bootloader. For example, on my legacy

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-21 Thread Masahiro Yamada
Hi Peter. 2015-10-21 21:27 GMT+09:00 Peter Hurley : > On 10/20/2015 09:20 PM, Masahiro Yamada wrote: >> Hi Peter, >> (+ Rob Herring, Stefan Agner) >> >> 2015-10-20 23:00 GMT+09:00 Peter Hurley : >>> On 10/19/2015 11:36 PM, Masahiro Yamada wrote: The input clock frequency varies from device

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-21 Thread Peter Hurley
On 10/20/2015 09:20 PM, Masahiro Yamada wrote: > Hi Peter, > (+ Rob Herring, Stefan Agner) > > 2015-10-20 23:00 GMT+09:00 Peter Hurley : >> On 10/19/2015 11:36 PM, Masahiro Yamada wrote: >>> The input clock frequency varies from device to device, but the >>> earlycon uses the fixed frequency

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-21 Thread Masahiro Yamada
Hi Peter, 2015-10-22 0:35 GMT+09:00 Peter Hurley : > Hi Masahiro, > > On 10/21/2015 11:31 AM, Masahiro Yamada wrote: >> If it is always correct to preserve the initialization done by boot-loader, >> the following code in 8250_early.c does not make sense. > > It's not

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-21 Thread Masahiro Yamada
Hi Peter. 2015-10-21 21:27 GMT+09:00 Peter Hurley : > On 10/20/2015 09:20 PM, Masahiro Yamada wrote: >> Hi Peter, >> (+ Rob Herring, Stefan Agner) >> >> 2015-10-20 23:00 GMT+09:00 Peter Hurley : >>> On 10/19/2015 11:36 PM, Masahiro Yamada

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-21 Thread Peter Hurley
Hi Masahiro, On 10/21/2015 11:31 AM, Masahiro Yamada wrote: > If it is always correct to preserve the initialization done by boot-loader, > the following code in 8250_early.c does not make sense. It's not always correct to preserve the initialization by the bootloader. For example, on my legacy

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-21 Thread Peter Hurley
On 10/20/2015 09:20 PM, Masahiro Yamada wrote: > Hi Peter, > (+ Rob Herring, Stefan Agner) > > 2015-10-20 23:00 GMT+09:00 Peter Hurley : >> On 10/19/2015 11:36 PM, Masahiro Yamada wrote: >>> The input clock frequency varies from device to device, but the >>> earlycon

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-20 Thread Masahiro Yamada
Hi Peter, (+ Rob Herring, Stefan Agner) 2015-10-20 23:00 GMT+09:00 Peter Hurley : > On 10/19/2015 11:36 PM, Masahiro Yamada wrote: >> The input clock frequency varies from device to device, but the >> earlycon uses the fixed frequency (BASE_BAUD * 16). It makes >> impossible to set the correct

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-20 Thread Peter Hurley
On 10/19/2015 11:36 PM, Masahiro Yamada wrote: > The input clock frequency varies from device to device, but the > earlycon uses the fixed frequency (BASE_BAUD * 16). It makes > impossible to set the correct divisor to the register. So the bootloader hasn't setup the serial port? > This commit

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-20 Thread Peter Hurley
On 10/19/2015 11:36 PM, Masahiro Yamada wrote: > The input clock frequency varies from device to device, but the > earlycon uses the fixed frequency (BASE_BAUD * 16). It makes > impossible to set the correct divisor to the register. So the bootloader hasn't setup the serial port? > This commit

Re: [PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-20 Thread Masahiro Yamada
Hi Peter, (+ Rob Herring, Stefan Agner) 2015-10-20 23:00 GMT+09:00 Peter Hurley : > On 10/19/2015 11:36 PM, Masahiro Yamada wrote: >> The input clock frequency varies from device to device, but the >> earlycon uses the fixed frequency (BASE_BAUD * 16). It makes >>

[PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-19 Thread Masahiro Yamada
The input clock frequency varies from device to device, but the earlycon uses the fixed frequency (BASE_BAUD * 16). It makes impossible to set the correct divisor to the register. This commit allows to specify the input clock frequency from the kernel-parameter. [Example]

[PATCH v2 2/2] serial: earlycon: allow to specify uartclk in earlycon kernel-parameter

2015-10-19 Thread Masahiro Yamada
The input clock frequency varies from device to device, but the earlycon uses the fixed frequency (BASE_BAUD * 16). It makes impossible to set the correct divisor to the register. This commit allows to specify the input clock frequency from the kernel-parameter. [Example]