Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-22 Thread Luck, Tony
On Thu, Aug 22, 2019 at 12:29:55PM +0200, Peter Zijlstra wrote: > On Wed, Aug 21, 2019 at 01:18:46PM -0700, Luck, Tony wrote: > > On Tue, Aug 20, 2019 at 04:57:35PM +0200, Peter Zijlstra wrote: > > > As I mentioned above, there are some folks internally that think > > NP == Network Processor is

Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-22 Thread Peter Zijlstra
On Wed, Aug 21, 2019 at 01:18:46PM -0700, Luck, Tony wrote: > On Tue, Aug 20, 2019 at 04:57:35PM +0200, Peter Zijlstra wrote: > As I mentioned above, there are some folks internally that think > NP == Network Processor is too narrow a pigeonhole for this CPU. > > But _NPAOS (Network Processor

Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-21 Thread Thomas Gleixner
On Wed, 21 Aug 2019, Luck, Tony wrote: > On Tue, Aug 20, 2019 at 04:57:35PM +0200, Peter Zijlstra wrote: > > On Tue, Aug 20, 2019 at 12:48:05PM +, Luck, Tony wrote: > > > > > > >> +#define INTEL_FAM6_ATOM_AIRMONT_NP0x75 /* Lightning Mountain */ > > > > > > > > What's _NP ? > > > > > >

Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-21 Thread Luck, Tony
On Tue, Aug 20, 2019 at 04:57:35PM +0200, Peter Zijlstra wrote: > On Tue, Aug 20, 2019 at 12:48:05PM +, Luck, Tony wrote: > > > > >> +#define INTEL_FAM6_ATOM_AIRMONT_NP0x75 /* Lightning Mountain */ > > > > > > What's _NP ? > > > > Network Processor. But that is too narrow a descriptor.

Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-21 Thread Peter Zijlstra
On Wed, Aug 21, 2019 at 11:21:43AM +0800, Tanwar, Rahul wrote: > On 20/8/2019 10:57 PM, Peter Zijlstra wrote: > > What would describe the special sause that warranted a new SOC? If this > > thing is marketed as 'Network Processor' then I suppose we can actually > > use it, esp. if we're going to

Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-20 Thread Tanwar, Rahul
On 20/8/2019 10:57 PM, Peter Zijlstra wrote: On Tue, Aug 20, 2019 at 12:48:05PM +, Luck, Tony wrote: +#define INTEL_FAM6_ATOM_AIRMONT_NP0x75 /* Lightning Mountain */ What's _NP ? Network Processor. But that is too narrow a descriptor. This is going to be used in other areas besides

Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-20 Thread Peter Zijlstra
On Tue, Aug 20, 2019 at 12:48:05PM +, Luck, Tony wrote: > > >> +#define INTEL_FAM6_ATOM_AIRMONT_NP0x75 /* Lightning Mountain */ > > > > What's _NP ? > > Network Processor. But that is too narrow a descriptor. This is going to be > used in > other areas besides networking. > > I’m

Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-20 Thread Luck, Tony
> Author: Peter Zijlstra > Date: Tue Aug 7 10:17:27 2018 -0700 > >x86/cpu: Sanitize FAM6_ATOM naming > > > What 2 or 3 or other number means? In this case I want it to mean “This is an Airmont derived core. Mostly like original Airmont, so you might see some places where we have the

Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-20 Thread Shevchenko, Andriy
On Tue, Aug 20, 2019 at 03:48:05PM +0300, Luck, Tony wrote: > > >> +#define INTEL_FAM6_ATOM_AIRMONT_NP0x75 /* Lightning Mountain */ > > > > What's _NP ? > > Network Processor. But that is too narrow a descriptor. This is going to be > used in > other areas besides networking. > > I’m

Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-20 Thread Thomas Gleixner
On Tue, 20 Aug 2019, Peter Zijlstra wrote: > On Fri, Aug 16, 2019 at 04:18:58PM +0800, Rahul Tanwar wrote: > > Add a new variant of Intel Atom Airmont CPU model. > > > > Signed-off-by: Rahul Tanwar > > --- > > arch/x86/include/asm/intel-family.h | 1 + > > 1 file changed, 1 insertion(+) > > >

Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-20 Thread Luck, Tony
>> +#define INTEL_FAM6_ATOM_AIRMONT_NP0x75 /* Lightning Mountain */ > > What's _NP ? Network Processor. But that is too narrow a descriptor. This is going to be used in other areas besides networking. I’m contemplating calling it AIRMONT2 -Tony

Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-20 Thread Peter Zijlstra
On Fri, Aug 16, 2019 at 04:18:58PM +0800, Rahul Tanwar wrote: > Add a new variant of Intel Atom Airmont CPU model. > > Signed-off-by: Rahul Tanwar > --- > arch/x86/include/asm/intel-family.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/include/asm/intel-family.h >

[PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name

2019-08-16 Thread Rahul Tanwar
Add a new variant of Intel Atom Airmont CPU model. Signed-off-by: Rahul Tanwar --- arch/x86/include/asm/intel-family.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h index 0278aa66ef62..cbbb8250370f 100644 ---