Re: [PATCH v20 1/2] scsi: ufs: Enable power management for wlun

2021-04-20 Thread Adrian Hunter
On 20/04/21 7:15 am, Adrian Hunter wrote: > On 20/04/21 12:53 am, Asutosh Das (asd) wrote: >> On 4/19/2021 11:37 AM, Adrian Hunter wrote: >>> On 16/04/21 10:49 pm, Asutosh Das wrote: Co-developed-by: Can Guo Signed-off-by: Can Guo Signed-off-by: Asutosh Das --- >>> >>>

Re: [PATCH v20 1/2] scsi: ufs: Enable power management for wlun

2021-04-19 Thread Adrian Hunter
On 20/04/21 12:53 am, Asutosh Das (asd) wrote: > On 4/19/2021 11:37 AM, Adrian Hunter wrote: >> On 16/04/21 10:49 pm, Asutosh Das wrote: >>> >>> Co-developed-by: Can Guo >>> Signed-off-by: Can Guo >>> Signed-off-by: Asutosh Das >>> --- >> >> I came across 3 issues while testing.  See comments

Re: [PATCH v20 1/2] scsi: ufs: Enable power management for wlun

2021-04-19 Thread Asutosh Das (asd)
On 4/19/2021 11:37 AM, Adrian Hunter wrote: On 16/04/21 10:49 pm, Asutosh Das wrote: Co-developed-by: Can Guo Signed-off-by: Can Guo Signed-off-by: Asutosh Das --- I came across 3 issues while testing. See comments below. Hi Adrian Thanks for the comments. @@ -5794,7 +5839,7 @@

Re: [PATCH v20 1/2] scsi: ufs: Enable power management for wlun

2021-04-19 Thread Adrian Hunter
On 16/04/21 10:49 pm, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU (START_STOP_UNIT) to wlun > during its runtime-suspend. > During the process blk_queue_enter checks if

[PATCH v20 1/2] scsi: ufs: Enable power management for wlun

2021-04-16 Thread Asutosh Das
During runtime-suspend of ufs host, the scsi devices are already suspended and so are the queues associated with them. But the ufs host sends SSU (START_STOP_UNIT) to wlun during its runtime-suspend. During the process blk_queue_enter checks if the queue is not in suspended state. If so, it waits