Re: [PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-03-24 Thread Andy Shevchenko
On Tue, Mar 23, 2021 at 11:53 PM Wesley Cheng wrote: > > > > On 3/23/2021 10:27 AM, Andy Shevchenko wrote: > > On Tue, Mar 23, 2021 at 1:19 AM Wesley Cheng wrote: > >> > >> Hi Andy, > >> > >> On 3/22/2021 2:14 PM, Andy Shevchenko wrote: > >>> On Mon, Mar 22, 2021 at 10:06 PM Wesley Cheng > >>>

Re: [PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-03-24 Thread Marek Szyprowski
Hi Wesley, On 23.03.2021 22:53, Wesley Cheng wrote: > On 3/23/2021 10:27 AM, Andy Shevchenko wrote: >> On Tue, Mar 23, 2021 at 1:19 AM Wesley Cheng wrote: >>> On 3/22/2021 2:14 PM, Andy Shevchenko wrote: On Mon, Mar 22, 2021 at 10:06 PM Wesley Cheng wrote: > On 3/22/2021 12:34

Re: [PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-03-23 Thread Wesley Cheng
On 3/23/2021 10:27 AM, Andy Shevchenko wrote: > On Tue, Mar 23, 2021 at 1:19 AM Wesley Cheng wrote: >> >> Hi Andy, >> >> On 3/22/2021 2:14 PM, Andy Shevchenko wrote: >>> On Mon, Mar 22, 2021 at 10:06 PM Wesley Cheng wrote: Hi Andy, On 3/22/2021 12:34 PM, Andy Shevchenko

Re: [PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-03-23 Thread Wesley Cheng
On 3/23/2021 10:27 AM, Andy Shevchenko wrote: > On Tue, Mar 23, 2021 at 1:19 AM Wesley Cheng wrote: >> >> Hi Andy, >> >> On 3/22/2021 2:14 PM, Andy Shevchenko wrote: >>> On Mon, Mar 22, 2021 at 10:06 PM Wesley Cheng wrote: Hi Andy, On 3/22/2021 12:34 PM, Andy Shevchenko

Re: [PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-03-23 Thread Andy Shevchenko
On Tue, Mar 23, 2021 at 1:19 AM Wesley Cheng wrote: > > Hi Andy, > > On 3/22/2021 2:14 PM, Andy Shevchenko wrote: > > On Mon, Mar 22, 2021 at 10:06 PM Wesley Cheng wrote: > >> > >> Hi Andy, > >> > >> On 3/22/2021 12:34 PM, Andy Shevchenko wrote: > >>> On Mon, Mar 22, 2021 at 8:49 PM Wesley Cheng

Re: [PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-03-22 Thread Wesley Cheng
Hi Andy, On 3/22/2021 2:14 PM, Andy Shevchenko wrote: > On Mon, Mar 22, 2021 at 10:06 PM Wesley Cheng wrote: >> >> Hi Andy, >> >> On 3/22/2021 12:34 PM, Andy Shevchenko wrote: >>> On Mon, Mar 22, 2021 at 8:49 PM Wesley Cheng wrote: Hi Andy, On 3/22/2021 5:48 AM, Andy

Re: [PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-03-22 Thread Andy Shevchenko
On Mon, Mar 22, 2021 at 10:06 PM Wesley Cheng wrote: > > Hi Andy, > > On 3/22/2021 12:34 PM, Andy Shevchenko wrote: > > On Mon, Mar 22, 2021 at 8:49 PM Wesley Cheng wrote: > >> > >> Hi Andy, > >> > >> On 3/22/2021 5:48 AM, Andy Shevchenko wrote: > >>> On Fri, Mar 12, 2021 at 2:01 AM Wesley Cheng

Re: [PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-03-22 Thread Wesley Cheng
Hi Andy, On 3/22/2021 12:34 PM, Andy Shevchenko wrote: > On Mon, Mar 22, 2021 at 8:49 PM Wesley Cheng wrote: >> >> Hi Andy, >> >> On 3/22/2021 5:48 AM, Andy Shevchenko wrote: >>> On Fri, Mar 12, 2021 at 2:01 AM Wesley Cheng wrote: In the situations where the DWC3 gadget stops active

Re: [PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-03-22 Thread Andy Shevchenko
On Mon, Mar 22, 2021 at 8:49 PM Wesley Cheng wrote: > > Hi Andy, > > On 3/22/2021 5:48 AM, Andy Shevchenko wrote: > > On Fri, Mar 12, 2021 at 2:01 AM Wesley Cheng wrote: > >> > >> In the situations where the DWC3 gadget stops active transfers, once > >> calling the dwc3_gadget_giveback(), there

Re: [PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-03-22 Thread Wesley Cheng
Hi Andy, On 3/22/2021 5:48 AM, Andy Shevchenko wrote: > On Fri, Mar 12, 2021 at 2:01 AM Wesley Cheng wrote: >> >> In the situations where the DWC3 gadget stops active transfers, once >> calling the dwc3_gadget_giveback(), there is a chance where a function >> driver can queue a new USB request

Re: [PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-03-22 Thread Andy Shevchenko
On Fri, Mar 12, 2021 at 2:01 AM Wesley Cheng wrote: > > In the situations where the DWC3 gadget stops active transfers, once > calling the dwc3_gadget_giveback(), there is a chance where a function > driver can queue a new USB request in between the time where the dwc3 > lock has been released

[PATCH v3] usb: dwc3: gadget: Prevent EP queuing while stopping transfers

2021-03-11 Thread Wesley Cheng
In the situations where the DWC3 gadget stops active transfers, once calling the dwc3_gadget_giveback(), there is a chance where a function driver can queue a new USB request in between the time where the dwc3 lock has been released and re-aquired. This occurs after we've already issued an