On Thu, Jan 18, 2018 at 04:21:34PM +0100, Christoph Hellwig wrote:
> On Wed, Jan 17, 2018 at 11:53:35AM +0100, Johannes Thumshirn wrote:
> > +nvme-core-y:= trace.o core.o
>
> trace.o should be conditional on CONFIG_TRACEPOINTS.
Doesn't do too much of a difference
On Thu, Jan 18, 2018 at 04:21:34PM +0100, Christoph Hellwig wrote:
> On Wed, Jan 17, 2018 at 11:53:35AM +0100, Johannes Thumshirn wrote:
> > +nvme-core-y:= trace.o core.o
>
> trace.o should be conditional on CONFIG_TRACEPOINTS.
Doesn't do too much of a difference
On Wed, Jan 17, 2018 at 11:53:35AM +0100, Johannes Thumshirn wrote:
> +nvme-core-y := trace.o core.o
trace.o should be conditional on CONFIG_TRACEPOINTS.
> +TRACE_EVENT(nvme_setup_cmd,
> + TP_PROTO(struct nvme_command *cmd),
> + TP_ARGS(cmd),
> +
On Wed, Jan 17, 2018 at 11:53:35AM +0100, Johannes Thumshirn wrote:
> +nvme-core-y := trace.o core.o
trace.o should be conditional on CONFIG_TRACEPOINTS.
> +TRACE_EVENT(nvme_setup_cmd,
> + TP_PROTO(struct nvme_command *cmd),
> + TP_ARGS(cmd),
> +
Looks good.
Reviewed-by: Keith Busch
Looks good.
Reviewed-by: Keith Busch
Johannes,
Very nice!
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Johannes,
Very nice!
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Signed-off-by: Johannes Thumshirn
---
Changes to v2:
* Don't cast le64_to_cpu() conversions to unsigned long long (Christoph)
* Add proper copyright header (Christoph)
* Move trace decoding into own file (Christoph)
* Include the src directory in the Makefile for trace
Signed-off-by: Johannes Thumshirn
---
Changes to v2:
* Don't cast le64_to_cpu() conversions to unsigned long long (Christoph)
* Add proper copyright header (Christoph)
* Move trace decoding into own file (Christoph)
* Include the src directory in the Makefile for trace (Christoph)
* Removed
10 matches
Mail list logo