Re: [PATCH v3 2/4] Documentation: devres: Add pcim_alloc_irq_vectors()

2021-02-17 Thread Andy Shevchenko
On Wed, Feb 17, 2021 at 06:50:04PM +0800, Dejin Zheng wrote: > On Tue, Feb 16, 2021 at 06:10:52PM +0100, Krzysztof Wilczyński wrote: ... > > Having said that, people might ask - how does it simplify the error > > handling path? > > > > You might have to back this with a line of two to explain

Re: [PATCH v3 2/4] Documentation: devres: Add pcim_alloc_irq_vectors()

2021-02-17 Thread Dejin Zheng
On Tue, Feb 16, 2021 at 06:10:52PM +0100, Krzysztof Wilczyński wrote: > Hi Dejin, > > Thank you again for all the work here! > > > Add pcim_alloc_irq_vectors(), a device-managed version of > > pci_alloc_irq_vectors(). introducing this function can simplify > > the error handling path in many

Re: [PATCH v3 2/4] Documentation: devres: Add pcim_alloc_irq_vectors()

2021-02-16 Thread Krzysztof Wilczyński
Hi Dejin, Thank you again for all the work here! > Add pcim_alloc_irq_vectors(), a device-managed version of > pci_alloc_irq_vectors(). introducing this function can simplify > the error handling path in many drivers. The second sentence should most likely start with a capital letter. Having

[PATCH v3 2/4] Documentation: devres: Add pcim_alloc_irq_vectors()

2021-02-16 Thread Dejin Zheng
Add pcim_alloc_irq_vectors(), a device-managed version of pci_alloc_irq_vectors(). introducing this function can simplify the error handling path in many drivers. Signed-off-by: Dejin Zheng --- v2 -> v3: - No change v1 -> v2: - Modify some commit messages.