Re: [PATCH v3 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding

2020-06-22 Thread Wesley Cheng
On 6/18/2020 3:23 PM, Rob Herring wrote: > On Thu, Jun 18, 2020 at 2:09 PM Wesley Cheng wrote: >> >> >> On 6/18/2020 11:33 AM, Rob Herring wrote: >>> On Wed, Jun 17, 2020 at 12:02 PM Wesley Cheng wrote: >>> >>> You are duplicating everything in usb-connector.yaml. You should have >>> a $ref

Re: [PATCH v3 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding

2020-06-18 Thread Rob Herring
On Thu, Jun 18, 2020 at 2:09 PM Wesley Cheng wrote: > > > On 6/18/2020 11:33 AM, Rob Herring wrote: > > On Wed, Jun 17, 2020 at 12:02 PM Wesley Cheng wrote: > > > > You are duplicating everything in usb-connector.yaml. You should have > > a $ref to it. > > > > Hi Rob, > > Sure, I will add a

Re: [PATCH v3 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding

2020-06-18 Thread Wesley Cheng
On 6/18/2020 11:33 AM, Rob Herring wrote: > On Wed, Jun 17, 2020 at 12:02 PM Wesley Cheng wrote: > > You are duplicating everything in usb-connector.yaml. You should have > a $ref to it. > Hi Rob, Sure, I will add a reference to that doc. > > This is wrong. The connector binding says port

Re: [PATCH v3 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding

2020-06-18 Thread Rob Herring
On Wed, Jun 17, 2020 at 12:02 PM Wesley Cheng wrote: > > Introduce the dt-binding for enabling USB type C orientation and role > detection using the PM8150B. The driver will be responsible for receiving > the interrupt at a state change on the CC lines, reading the orientation/role, > and

[PATCH v3 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding

2020-06-17 Thread Wesley Cheng
Introduce the dt-binding for enabling USB type C orientation and role detection using the PM8150B. The driver will be responsible for receiving the interrupt at a state change on the CC lines, reading the orientation/role, and communicating this information to the remote clients, which can