Re: [PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-29 Thread Jonathan Cameron
On Mon, 29 Mar 2021 09:38:38 +0200 Oleksij Rempel wrote: > On Mon, Mar 22, 2021 at 02:27:22PM +, Jonathan Cameron wrote: > > > > > +static DECLARE_TI_TSC2046_8_CHANNELS(tsc2046_adc, 12); > > > > > + > > > > > +static const struct tsc2046_adc_dcfg tsc2046_adc_dcfg_tsc2046e = { > > > > > +

Re: [PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-29 Thread Oleksij Rempel
On Mon, Mar 22, 2021 at 02:27:22PM +, Jonathan Cameron wrote: > > > > +static DECLARE_TI_TSC2046_8_CHANNELS(tsc2046_adc, 12); > > > > + > > > > +static const struct tsc2046_adc_dcfg tsc2046_adc_dcfg_tsc2046e = { > > > > + .channels = tsc2046_adc_channels, > > > > + .num_channels =

Re: [PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-22 Thread Jonathan Cameron
> > > > > + /* > > > + * Lock to protect the layout and the spi transfer buffer. > > > + * tsc2046_adc_group_layout can be changed within update_scan_mode(), > > > + * in this case the l[] and tx/rx buffer will be out of sync to each > > > + * other. > > > + */ > > > + struct mutex

Re: [PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-22 Thread Oleksij Rempel
On Mon, Mar 22, 2021 at 03:41:22PM +0200, Andy Shevchenko wrote: > On Mon, Mar 22, 2021 at 12:30 PM Oleksij Rempel > wrote: > > On Fri, Mar 19, 2021 at 07:42:41PM +0200, Andy Shevchenko wrote: > > > On Fri, Mar 19, 2021 at 4:45 PM Oleksij Rempel > > > wrote: > > ... > > > > > +static u16

Re: [PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-22 Thread Andy Shevchenko
On Mon, Mar 22, 2021 at 12:30 PM Oleksij Rempel wrote: > On Fri, Mar 19, 2021 at 07:42:41PM +0200, Andy Shevchenko wrote: > > On Fri, Mar 19, 2021 at 4:45 PM Oleksij Rempel > > wrote: ... > > > +static u16 tsc2046_adc_get_value(struct tsc2046_adc_atom *buf) > > > +{ > > > + /* Last 3

Re: [PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-22 Thread Oleksij Rempel
Hi, On Sat, Mar 20, 2021 at 03:46:01PM +, Jonathan Cameron wrote: > On Fri, 19 Mar 2021 15:45:09 +0100 > Oleksij Rempel wrote: > > > Basically the TI TSC2046 touchscreen controller is 8 channel ADC optimized > > for > > the touchscreen use case. By implementing it as an IIO ADC device, we

Re: [PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-22 Thread Oleksij Rempel
On Fri, Mar 19, 2021 at 07:42:41PM +0200, Andy Shevchenko wrote: > On Fri, Mar 19, 2021 at 4:45 PM Oleksij Rempel > wrote: > > > > Basically the TI TSC2046 touchscreen controller is 8 channel ADC optimized > > for > > the touchscreen use case. By implementing it as an IIO ADC device, we can > >

Re: [PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-20 Thread Jonathan Cameron
On Fri, 19 Mar 2021 15:45:09 +0100 Oleksij Rempel wrote: > Basically the TI TSC2046 touchscreen controller is 8 channel ADC optimized for > the touchscreen use case. By implementing it as an IIO ADC device, we can > make use of resistive-adc-touch and iio-hwmon drivers. > > So far, this driver

Re: [PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-19 Thread Andy Shevchenko
On Fri, Mar 19, 2021 at 4:45 PM Oleksij Rempel wrote: > > Basically the TI TSC2046 touchscreen controller is 8 channel ADC optimized for > the touchscreen use case. By implementing it as an IIO ADC device, we can > make use of resistive-adc-touch and iio-hwmon drivers. > > So far, this driver was

Re: [PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-19 Thread kernel test robot
Hi Oleksij, I love your patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.12-rc3 next-20210319] [cannot apply to iio/togreg] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch,

[PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-19 Thread Oleksij Rempel
Basically the TI TSC2046 touchscreen controller is 8 channel ADC optimized for the touchscreen use case. By implementing it as an IIO ADC device, we can make use of resistive-adc-touch and iio-hwmon drivers. So far, this driver was tested with a custom version of resistive-adc-touch driver,