Re: [PATCH v3 3/4] i2c: designware: Use the correct name of device-managed function

2021-02-18 Thread Dejin Zheng
On Wed, Feb 17, 2021 at 03:47:01PM +0200, Andy Shevchenko wrote: > On Wed, Feb 17, 2021 at 07:40:14PM +0800, Dejin Zheng wrote: > > On Tue, Feb 16, 2021 at 06:46:01PM +0100, Krzysztof Wilczyński wrote: > > ... > > > > The change simplifies the error handling path, how? A line of two which > > >

Re: [PATCH v3 3/4] i2c: designware: Use the correct name of device-managed function

2021-02-17 Thread Andy Shevchenko
On Wed, Feb 17, 2021 at 07:40:14PM +0800, Dejin Zheng wrote: > On Tue, Feb 16, 2021 at 06:46:01PM +0100, Krzysztof Wilczyński wrote: ... > > The change simplifies the error handling path, how? A line of two which > > explains how it has been achieved might help should someone reads the > >

Re: [PATCH v3 3/4] i2c: designware: Use the correct name of device-managed function

2021-02-17 Thread Dejin Zheng
On Tue, Feb 16, 2021 at 06:46:01PM +0100, Krzysztof Wilczyński wrote: Hi Krzysztof, > Hi Dejin, > > Thank you for all the changes, looks good! > > You could improve the subject line, as it is very vague - what is the > new function name more correct? Was the other and/or the previous one > not

Re: [PATCH v3 3/4] i2c: designware: Use the correct name of device-managed function

2021-02-16 Thread Krzysztof Wilczyński
Hi Dejin, Thank you for all the changes, looks good! You could improve the subject line, as it is very vague - what is the new function name more correct? Was the other and/or the previous one not correct? Seems like you are correcting a typo of sorts, rather than introducing a new function in

[PATCH v3 3/4] i2c: designware: Use the correct name of device-managed function

2021-02-16 Thread Dejin Zheng
Use the new function pcim_alloc_irq_vectors() to allocate IRQ vectors, the pcim_alloc_irq_vectors() function, an explicit device-managed version of pci_alloc_irq_vectors(). If pcim_enable_device() has been called before, then pci_alloc_irq_vectors() is actually a device-managed function. It is