Re: [PATCH v4 10/10] selftests/vm: test faulting in kernel, and verify pinnable pages

2020-12-19 Thread John Hubbard
On 12/19/20 7:22 AM, Pavel Tatashin wrote: ... Add a new test to gup_test, to verify that only "pinnable" pages are pinned. Also, use gup/pup + FOLL_TOUCH to fault in the pages, rather than faulting them in from user space. OK ? But I don't know why that second point is important. Is it

Re: [PATCH v4 10/10] selftests/vm: test faulting in kernel, and verify pinnable pages

2020-12-19 Thread Pavel Tatashin
On Sat, Dec 19, 2020 at 12:57 AM John Hubbard wrote: > > On 12/17/20 10:52 AM, Pavel Tatashin wrote: > > > > Hi Pavel, > > This all looks good pretty good to me, with just a couple of minor > doubts interleaved with the documentation tweaks: > > a) I'm not yet sure if the is_pinnable_page()

Re: [PATCH v4 10/10] selftests/vm: test faulting in kernel, and verify pinnable pages

2020-12-18 Thread John Hubbard
On 12/17/20 10:52 AM, Pavel Tatashin wrote: > Hi Pavel, This all looks good pretty good to me, with just a couple of minor doubts interleaved with the documentation tweaks: a) I'm not yet sure if the is_pinnable_page() concept is a keeper. If it's not for some reason, then we should revisit

[PATCH v4 10/10] selftests/vm: test faulting in kernel, and verify pinnable pages

2020-12-17 Thread Pavel Tatashin
When pages are pinned they can be faulted in userland and migrated, and they can be faulted right in kernel without migration. In either case, the pinned pages must end-up being pinnable (not movable). Add a new test without touching pages in userland, and use FOLL_TOUCH instead. Also, verify