Re: Re: Re: Re: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

2020-07-17 Thread Sameer Pujar
Hi Mark, On 7/2/2020 5:56 PM, Mark Brown wrote: On Thu, Jul 02, 2020 at 04:06:14PM +0530, Sameer Pujar wrote: For the HW I am using, there are no fixed endpoints and I am not sure if it is allowed to have empty endpoints in audio-graph-card. Crossbar/router provides the flexibility to

Re: Re: Re: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

2020-07-02 Thread Mark Brown
On Thu, Jul 02, 2020 at 04:06:14PM +0530, Sameer Pujar wrote: > For the HW I am using, there are no fixed endpoints and I am not sure if it > is allowed to have empty endpoints in audio-graph-card. Crossbar/router > provides the flexibility to connect the components in any required order. > Patch

Re: Re: Re: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

2020-07-02 Thread Sameer Pujar
On 6/30/2020 9:02 PM, Mark Brown wrote: On Tue, Jun 30, 2020 at 06:23:49PM +0530, Sameer Pujar wrote: On 6/30/2020 4:31 PM, Mark Brown wrote: Why simple-card and not audio-graph-card? Frankly speaking I have not used audio-graph-card before. I had a brief look at the related binding. It

Re: Re: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

2020-06-30 Thread Mark Brown
On Tue, Jun 30, 2020 at 06:23:49PM +0530, Sameer Pujar wrote: > On 6/30/2020 4:31 PM, Mark Brown wrote: > > Why simple-card and not audio-graph-card? > Frankly speaking I have not used audio-graph-card before. I had a brief look > at the related binding. It seems it can use similar DT properties

Re: Re: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

2020-06-30 Thread Sameer Pujar
On 6/30/2020 4:31 PM, Mark Brown wrote: On Tue, Jun 30, 2020 at 01:22:29PM +0530, Sameer Pujar wrote: Yes there are complex use cases, but if we look at the amount of changes required in simple-card driver that is not too much. Existing binding for simple-card driver would still work fine

Re: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

2020-06-30 Thread Mark Brown
On Tue, Jun 30, 2020 at 01:22:29PM +0530, Sameer Pujar wrote: > Yes there are complex use cases, but if we look at the amount of changes > required in simple-card driver that is not too much. Existing binding for > simple-card driver would still work fine for our cases. Yes there are some >

Re: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

2020-06-30 Thread Sameer Pujar
On 6/30/2020 12:25 PM, Kuninori Morimoto wrote: External email: Use caution opening links or attachments Hi Sameer Thank you for explaining detail at off-list mail. Your issue happen on (C) case, and you are tring to solve it. It is easy to understand if it was indicated at log area. I

Re: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

2020-06-30 Thread Kuninori Morimoto
Hi Sameer Thank you for explaining detail at off-list mail. Your issue happen on (C) case, and you are tring to solve it. It is easy to understand if it was indicated at log area. I have imagined other system from "multiple CPU/Codec support". (A)(B) FE <-> BE (C)

Re: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

2020-06-29 Thread Sameer Pujar
On 6/30/2020 6:54 AM, Kuninori Morimoto wrote: External email: Use caution opening links or attachments Hi Sameer Maybe base issue for multiple codec support is that simple_for_each_link() is caring first codec only ? (snip) Ideally I wanted to remove above two lines and allow empty

Re: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

2020-06-29 Thread Kuninori Morimoto
Hi Sameer > > Maybe base issue for multiple codec support > > is that simple_for_each_link() is caring first codec only ? (snip) > Ideally I wanted to remove above two lines and allow empty codec > list. But some users may expect the parsing to fail if no 'Codec' is > found in the DAI link,

Re: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

2020-06-29 Thread Sameer Pujar
On 6/29/2020 6:54 AM, Kuninori Morimoto wrote: External email: Use caution opening links or attachments Hi Sameer The simple-card driver supports multiple CPU and single Codec entries for DPCM DAI links. In some cases it is required to have multiple CPU/Codecs. Currently parsing logic for

Re: [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

2020-06-28 Thread Kuninori Morimoto
Hi Sameer > The simple-card driver supports multiple CPU and single Codec entries > for DPCM DAI links. In some cases it is required to have multiple > CPU/Codecs. Currently parsing logic for DPCM link loops over all > children of DAI link but assumes that there is a single Codec entry. > When

[PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs

2020-06-26 Thread Sameer Pujar
The simple-card driver supports multiple CPU and single Codec entries for DPCM DAI links. In some cases it is required to have multiple CPU/Codecs. Currently parsing logic for DPCM link loops over all children of DAI link but assumes that there is a single Codec entry. When DAI link has multiple