Re: [PATCH v5 09/19] gpio: support ROHM BD71815 GPOs

2021-03-30 Thread Andy Shevchenko
On Tue, Mar 30, 2021 at 3:06 PM Vaittinen, Matti wrote: > On Tue, 2021-03-30 at 13:11 +0300, Andy Shevchenko wrote: > > On Mon, Mar 29, 2021 at 3:58 PM Matti Vaittinen > > wrote: > > > > > > +struct bd71815_gpio { > > > + struct gpio_chip chip; > > > + struct device *dev; > > > >

Re: [PATCH v5 09/19] gpio: support ROHM BD71815 GPOs

2021-03-30 Thread Vaittinen, Matti
On Tue, 2021-03-30 at 13:11 +0300, Andy Shevchenko wrote: > On Mon, Mar 29, 2021 at 3:58 PM Matti Vaittinen > wrote: > > > > +struct bd71815_gpio { > > + struct gpio_chip chip; > > + struct device *dev; > > Wondering why you need this. Is it the same as chip.parent? > This is

Re: [PATCH v5 09/19] gpio: support ROHM BD71815 GPOs

2021-03-30 Thread Vaittinen, Matti
On Tue, 2021-03-30 at 13:54 +0300, Andy Shevchenko wrote: > On Tue, Mar 30, 2021 at 1:43 PM Matti Vaittinen > wrote: > > On Tue, 2021-03-30 at 13:11 +0300, Andy Shevchenko wrote: > > ... > > > Andy, how fatal do you think these issues are? I did put these > > comments > > on my 'things to

Re: [PATCH v5 09/19] gpio: support ROHM BD71815 GPOs

2021-03-30 Thread Andy Shevchenko
On Tue, Mar 30, 2021 at 1:43 PM Matti Vaittinen wrote: > On Tue, 2021-03-30 at 13:11 +0300, Andy Shevchenko wrote: ... > Andy, how fatal do you think these issues are? I did put these comments > on my 'things to clean-up' list. > > If you don't see them as fatal, then I rather not resend whole

Re: [PATCH v5 09/19] gpio: support ROHM BD71815 GPOs

2021-03-30 Thread Matti Vaittinen
Hi Andy, On Tue, 2021-03-30 at 13:11 +0300, Andy Shevchenko wrote: > On Mon, Mar 29, 2021 at 3:58 PM Matti Vaittinen > wrote: > > Support GPO(s) found from ROHM BD71815 power management IC. The IC > > has two > > GPO pins but only one is properly documented in data-sheet. The > > driver > > in

Re: [PATCH v5 09/19] gpio: support ROHM BD71815 GPOs

2021-03-30 Thread Andy Shevchenko
On Mon, Mar 29, 2021 at 3:58 PM Matti Vaittinen wrote: > > Support GPO(s) found from ROHM BD71815 power management IC. The IC has two > GPO pins but only one is properly documented in data-sheet. The driver in the datasheet > exposes by default only the documented GPO. The second GPO is

[PATCH v5 09/19] gpio: support ROHM BD71815 GPOs

2021-03-29 Thread Matti Vaittinen
Support GPO(s) found from ROHM BD71815 power management IC. The IC has two GPO pins but only one is properly documented in data-sheet. The driver exposes by default only the documented GPO. The second GPO is connected to E5 pin and is marked as GND in data-sheet. Control for this undocumented pin