Re: [PATCH v5 09/22] media: camss: Refactor CSID HW version support

2021-02-22 Thread Robert Foss
On Sun, 21 Feb 2021 at 18:50, Andrey Konovalov wrote: > > Hi Robert, > > After reviewing the [PATCH v5 10/22], I noticed that this patch also > has a problematic test_pattern control implementation. > > See below. > > On 21.02.2021 18:15, Andrey Konovalov wrote: > > Hi Robert, > > > > Thank you

Re: [PATCH v5 09/22] media: camss: Refactor CSID HW version support

2021-02-21 Thread Andrey Konovalov
Hi Robert, After reviewing the [PATCH v5 10/22], I noticed that this patch also has a problematic test_pattern control implementation. See below. On 21.02.2021 18:15, Andrey Konovalov wrote: Hi Robert, Thank you for your patch! Reviewed-by: Andrey Konovalov Thanks, Andrey On 17.02.2021

Re: [PATCH v5 09/22] media: camss: Refactor CSID HW version support

2021-02-21 Thread Andrey Konovalov
Hi Robert, Thank you for your patch! Reviewed-by: Andrey Konovalov Thanks, Andrey On 17.02.2021 14:21, Robert Foss wrote: In order to support Qualcomm ISP hardware architectures that diverge from older architectures, the CSID subdevice drivers needs to be refactored to better abstract the

[PATCH v5 09/22] media: camss: Refactor CSID HW version support

2021-02-17 Thread Robert Foss
In order to support Qualcomm ISP hardware architectures that diverge from older architectures, the CSID subdevice drivers needs to be refactored to better abstract the different ISP hardware architectures. Signed-off-by: Robert Foss --- Changes since v1 - kernel test robot: Add missing