Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-16 Thread Viresh Kumar
On 12-03-21, 13:41, Viresh Kumar wrote: > > > > +static struct i2c_adapter virtio_adapter = { > > > > + .owner = THIS_MODULE, > > > > + .name = "Virtio I2C Adapter", > > > > + .class = I2C_CLASS_DEPRECATED, > > > What happened to this discussion ? > > > > > >

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-15 Thread Jie Deng
On 2021/3/15 15:52, Arnd Bergmann wrote: On Mon, Mar 15, 2021 at 6:54 AM Jie Deng wrote: On 2021/3/15 11:13, Jason Wang wrote: On 2021/3/15 9:14 上午, Jie Deng wrote: On 2021/3/12 16:58, Arnd Bergmann wrote: Then do you think it is necessary to mark the virtio bufs with

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-15 Thread Arnd Bergmann
On Mon, Mar 15, 2021 at 6:54 AM Jie Deng wrote: > On 2021/3/15 11:13, Jason Wang wrote: > > On 2021/3/15 9:14 上午, Jie Deng wrote: > >> On 2021/3/12 16:58, Arnd Bergmann wrote: > > > Then do you think it is necessary to mark the virtio bufs with > cacheline_aligned ? I think so, yes. > I

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-14 Thread Jie Deng
On 2021/3/15 11:13, Jason Wang wrote: On 2021/3/15 9:14 上午, Jie Deng wrote: On 2021/3/12 16:58, Arnd Bergmann wrote: On Fri, Mar 12, 2021 at 2:33 PM Jie Deng wrote: + +/** + * struct virtio_i2c_req - the virtio I2C request structure + * @out_hdr: the OUT header of the virtio I2C message

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-14 Thread Jason Wang
On 2021/3/15 9:14 上午, Jie Deng wrote: On 2021/3/12 16:58, Arnd Bergmann wrote: On Fri, Mar 12, 2021 at 2:33 PM Jie Deng wrote: + +/** + * struct virtio_i2c_req - the virtio I2C request structure + * @out_hdr: the OUT header of the virtio I2C message + * @buf: the buffer into which data is

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-14 Thread Jie Deng
On 2021/3/12 16:58, Arnd Bergmann wrote: On Fri, Mar 12, 2021 at 2:33 PM Jie Deng wrote: + +/** + * struct virtio_i2c_req - the virtio I2C request structure + * @out_hdr: the OUT header of the virtio I2C message + * @buf: the buffer into which data is read, or from which it's written + *

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-12 Thread Arnd Bergmann
On Fri, Mar 12, 2021 at 2:33 PM Jie Deng wrote: > + > +/** > + * struct virtio_i2c_req - the virtio I2C request structure > + * @out_hdr: the OUT header of the virtio I2C message > + * @buf: the buffer into which data is read, or from which it's written > + * @in_hdr: the IN header of the virtio

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-12 Thread Jie Deng
On 2021/3/12 16:11, Viresh Kumar wrote: On 12-03-21, 15:51, Jie Deng wrote: On 2021/3/12 14:10, Viresh Kumar wrote: I saw your email about wrong version being sent, I already wrote some reviews. Sending them anyway for FWIW :) On 12-03-21, 21:33, Jie Deng wrote: +struct virtio_i2c { +

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-12 Thread Viresh Kumar
On 12-03-21, 15:51, Jie Deng wrote: > > On 2021/3/12 14:10, Viresh Kumar wrote: > > I saw your email about wrong version being sent, I already wrote some > > reviews. Sending them anyway for FWIW :) > > > > On 12-03-21, 21:33, Jie Deng wrote: > > > +struct virtio_i2c { > > > + struct

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-11 Thread Jie Deng
On 2021/3/12 14:10, Viresh Kumar wrote: I saw your email about wrong version being sent, I already wrote some reviews. Sending them anyway for FWIW :) On 12-03-21, 21:33, Jie Deng wrote: +struct virtio_i2c { + struct virtio_device *vdev; + struct completion completion; +

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-11 Thread Viresh Kumar
I saw your email about wrong version being sent, I already wrote some reviews. Sending them anyway for FWIW :) On 12-03-21, 21:33, Jie Deng wrote: > diff --git a/drivers/i2c/busses/i2c-virtio.c b/drivers/i2c/busses/i2c-virtio.c > new file mode 100644 > index 000..bbde8de > --- /dev/null > +++

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-11 Thread Jie Deng
Sorry , sent the wrong version. Please ignore this. I will resend.

[PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-11 Thread Jie Deng
Add an I2C bus driver for virtio para-virtualization. The controller can be emulated by the backend driver in any device model software by following the virtio protocol. The device specification can be found on https://lists.oasis-open.org/archives/virtio-comment/202101/msg8.html. By