Re: [PATCH v7 19/36] function_graph: Implement fgraph_reserve_data() and fgraph_retrieve_data()

2024-02-15 Thread Google
On Wed, 14 Feb 2024 18:54:07 -0500 Steven Rostedt wrote: > On Thu, 15 Feb 2024 08:45:52 +0900 > Masami Hiramatsu (Google) wrote: > > > > Hmm, the above is a fast path. I wonder if we should add a patch to make > > > that into: > > > > > > if (unlikely(size_bytes & (sizeof(long) - 1))) > >

Re: [PATCH v7 19/36] function_graph: Implement fgraph_reserve_data() and fgraph_retrieve_data()

2024-02-14 Thread Steven Rostedt
On Thu, 15 Feb 2024 08:45:52 +0900 Masami Hiramatsu (Google) wrote: > > Hmm, the above is a fast path. I wonder if we should add a patch to make > > that into: > > > > if (unlikely(size_bytes & (sizeof(long) - 1))) > > data_size = DIV_ROUND_UP(size_bytes, sizeof(long)); > >

Re: [PATCH v7 19/36] function_graph: Implement fgraph_reserve_data() and fgraph_retrieve_data()

2024-02-14 Thread Google
On Wed, 14 Feb 2024 13:59:58 -0500 Steven Rostedt wrote: > On Wed, 7 Feb 2024 00:11:01 +0900 > "Masami Hiramatsu (Google)" wrote: > > > From: Ste > > +/** > > + * fgraph_reserve_data - Reserve storage on the task's ret_stack > > + * @idx: The index of fgraph_array > > + * @size_bytes: The

Re: [PATCH v7 19/36] function_graph: Implement fgraph_reserve_data() and fgraph_retrieve_data()

2024-02-14 Thread Steven Rostedt
On Wed, 7 Feb 2024 00:11:01 +0900 "Masami Hiramatsu (Google)" wrote: > From: Ste > +/** > + * fgraph_reserve_data - Reserve storage on the task's ret_stack > + * @idx: The index of fgraph_array > + * @size_bytes: The size in bytes to reserve > + * > + * Reserves space of up to

[PATCH v7 19/36] function_graph: Implement fgraph_reserve_data() and fgraph_retrieve_data()

2024-02-06 Thread Masami Hiramatsu (Google)
From: Steven Rostedt (VMware) Added functions that can be called by a fgraph_ops entryfunc and retfunc to store state between the entry of the function being traced to the exit of the same function. The fgraph_ops entryfunc() may call fgraph_reserve_data() to store up to 32 words onto the task's