Re: [PATCH v8 1/2] scsi: ufs: Enable power management for wlun

2021-03-01 Thread Adrian Hunter
On 1/03/21 8:10 pm, Asutosh Das wrote: > On Mon, Mar 01 2021 at 05:23 -0800, Adrian Hunter wrote: >> On 26/02/21 1:37 am, Asutosh Das wrote: >>> @@ -8901,43 +9125,14 @@ static int ufshcd_resume(struct ufs_hba *hba, enum >>> ufs_pm_op pm_op) >>> goto vendor_suspend; >>> } >> >>

Re: [PATCH v8 1/2] scsi: ufs: Enable power management for wlun

2021-03-01 Thread Asutosh Das
On Mon, Mar 01 2021 at 05:23 -0800, Adrian Hunter wrote: Hi A couple of minor things, but also a potential issue with when link state transitions are done. Please see comments below. On 26/02/21 1:37 am, Asutosh Das wrote: Hi Adrian Thanks for your comments. During runtime-suspend of ufs

Re: [PATCH v8 1/2] scsi: ufs: Enable power management for wlun

2021-03-01 Thread Adrian Hunter
Hi A couple of minor things, but also a potential issue with when link state transitions are done. Please see comments below. On 26/02/21 1:37 am, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But

[PATCH v8 1/2] scsi: ufs: Enable power management for wlun

2021-02-25 Thread Asutosh Das
During runtime-suspend of ufs host, the scsi devices are already suspended and so are the queues associated with them. But the ufs host sends SSU to wlun during its runtime-suspend. During the process blk_queue_enter checks if the queue is not in suspended state. If so, it waits for the queue to