Re: [RESEND PATCH v3 08/20] mtd: spi-nor: Split spi_nor_init_params()

2019-08-27 Thread Tudor.Ambarus
On 08/27/2019 09:00 AM, Vignesh Raghavendra wrote: >> + *Please not that there is a ->post_bfpt() fixup hook that can >> overwrite the > s/not/note > >> + *flash parameters and settings imediately after parsing the Basic Flash > s/imediately/immediately > will update, thanks!

Re: [RESEND PATCH v3 08/20] mtd: spi-nor: Split spi_nor_init_params()

2019-08-26 Thread Vignesh Raghavendra
On 26/08/19 5:38 PM, tudor.amba...@microchip.com wrote: > From: Tudor Ambarus > > Add functions to delimit what the chunks of code do: > > static void spi_nor_init_params() > { > spi_nor_info_init_params() > spi_nor_manufacturer_init_params() > spi_nor_sfdp_init_params() >

[RESEND PATCH v3 08/20] mtd: spi-nor: Split spi_nor_init_params()

2019-08-26 Thread Tudor.Ambarus
From: Tudor Ambarus Add functions to delimit what the chunks of code do: static void spi_nor_init_params() { spi_nor_info_init_params() spi_nor_manufacturer_init_params() spi_nor_sfdp_init_params() } Add descriptions to all methods. spi_nor_init_params() becomes of