Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-09-06 Thread Juri Lelli
Hi, On 30/08/19 13:24, Peter Zijlstra wrote: > On Thu, Aug 08, 2019 at 11:45:46AM +0200, Juri Lelli wrote: > > I'd like to take this last sentence back, I was able to run a few boot + > > hackbench + shutdown cycles with the following applied (guess too much > > debug printks around before). > >

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-30 Thread Peter Zijlstra
On Thu, Aug 08, 2019 at 11:45:46AM +0200, Juri Lelli wrote: > I'd like to take this last sentence back, I was able to run a few boot + > hackbench + shutdown cycles with the following applied (guess too much > debug printks around before). I've changed that slightly; the merged delta looks like:

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-09 Thread Juri Lelli
On 09/08/19 11:17, Dietmar Eggemann wrote: > On 7/26/19 4:54 PM, Peter Zijlstra wrote: > > [...] > > > +void dl_server_init(struct sched_dl_entity *dl_se, struct rq *rq, > > + dl_server_has_tasks_f has_tasks, > > + dl_server_pick_f pick) > > +{ > > +

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-09 Thread Dietmar Eggemann
On 7/26/19 4:54 PM, Peter Zijlstra wrote: [...] > +void dl_server_init(struct sched_dl_entity *dl_se, struct rq *rq, > + dl_server_has_tasks_f has_tasks, > + dl_server_pick_f pick) > +{ > + dl_se->dl_server = 1; > + dl_se->rq = rq; > +

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-09 Thread Juri Lelli
On 08/08/19 12:31, Peter Zijlstra wrote: > On Thu, Aug 08, 2019 at 10:46:52AM +0200, Juri Lelli wrote: > > On 08/08/19 10:11, Dietmar Eggemann wrote: > > > > What about the fast path in pick_next_task()? > > > > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > > index

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-08 Thread Peter Zijlstra
On Thu, Aug 08, 2019 at 10:46:52AM +0200, Juri Lelli wrote: > On 08/08/19 10:11, Dietmar Eggemann wrote: > > What about the fast path in pick_next_task()? > > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index bffe849b5a42..f1ea6ae16052 100644 > > --- a/kernel/sched/core.c > >

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-08 Thread Juri Lelli
On 08/08/19 11:27, Juri Lelli wrote: > On 08/08/19 10:57, Dietmar Eggemann wrote: > > On 8/8/19 10:46 AM, Juri Lelli wrote: > > > On 08/08/19 10:11, Dietmar Eggemann wrote: > > >> On 8/8/19 9:56 AM, Peter Zijlstra wrote: > > >>> On Wed, Aug 07, 2019 at 06:31:59PM +0200, Dietmar Eggemann wrote: > >

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-08 Thread Juri Lelli
On 08/08/19 10:57, Dietmar Eggemann wrote: > On 8/8/19 10:46 AM, Juri Lelli wrote: > > On 08/08/19 10:11, Dietmar Eggemann wrote: > >> On 8/8/19 9:56 AM, Peter Zijlstra wrote: > >>> On Wed, Aug 07, 2019 at 06:31:59PM +0200, Dietmar Eggemann wrote: > On 7/26/19 4:54 PM, Peter Zijlstra wrote: >

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-08 Thread Dietmar Eggemann
On 8/8/19 10:46 AM, Juri Lelli wrote: > On 08/08/19 10:11, Dietmar Eggemann wrote: >> On 8/8/19 9:56 AM, Peter Zijlstra wrote: >>> On Wed, Aug 07, 2019 at 06:31:59PM +0200, Dietmar Eggemann wrote: On 7/26/19 4:54 PM, Peter Zijlstra wrote: > > > Signed-off-by: Peter Zijlstra

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-08 Thread Juri Lelli
On 08/08/19 10:11, Dietmar Eggemann wrote: > On 8/8/19 9:56 AM, Peter Zijlstra wrote: > > On Wed, Aug 07, 2019 at 06:31:59PM +0200, Dietmar Eggemann wrote: > >> On 7/26/19 4:54 PM, Peter Zijlstra wrote: > >>> > >>> > >>> Signed-off-by: Peter Zijlstra (Intel) > >> > >> [...] > >> > >>> @@ -889,6

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-08 Thread Dietmar Eggemann
On 8/8/19 9:56 AM, Peter Zijlstra wrote: > On Wed, Aug 07, 2019 at 06:31:59PM +0200, Dietmar Eggemann wrote: >> On 7/26/19 4:54 PM, Peter Zijlstra wrote: >>> >>> >>> Signed-off-by: Peter Zijlstra (Intel) >> >> [...] >> >>> @@ -889,6 +891,8 @@ static void update_curr(struct cfs_rq *c >>>

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-08 Thread Peter Zijlstra
On Wed, Aug 07, 2019 at 06:31:59PM +0200, Dietmar Eggemann wrote: > On 7/26/19 4:54 PM, Peter Zijlstra wrote: > > > > > > Signed-off-by: Peter Zijlstra (Intel) > > [...] > > > @@ -889,6 +891,8 @@ static void update_curr(struct cfs_rq *c > > trace_sched_stat_runtime(curtask,

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-08 Thread Dietmar Eggemann
On 8/8/19 8:52 AM, Juri Lelli wrote: > Hi Dietmar, > > On 07/08/19 18:31, Dietmar Eggemann wrote: >> On 7/26/19 4:54 PM, Peter Zijlstra wrote: >>> >>> >>> Signed-off-by: Peter Zijlstra (Intel) >> >> [...] >> >>> @@ -889,6 +891,8 @@ static void update_curr(struct cfs_rq *c >>>

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-08 Thread Juri Lelli
Hi, On 26/07/19 16:54, Peter Zijlstra wrote: [...] > +void dl_server_init(struct sched_dl_entity *dl_se, struct rq *rq, > + dl_server_has_tasks_f has_tasks, > + dl_server_pick_f pick) > +{ > + dl_se->dl_server = 1; > + dl_se->rq = rq; > +

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-08 Thread Juri Lelli
Hi Dietmar, On 07/08/19 18:31, Dietmar Eggemann wrote: > On 7/26/19 4:54 PM, Peter Zijlstra wrote: > > > > > > Signed-off-by: Peter Zijlstra (Intel) > > [...] > > > @@ -889,6 +891,8 @@ static void update_curr(struct cfs_rq *c > > trace_sched_stat_runtime(curtask, delta_exec,

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-08-07 Thread Dietmar Eggemann
On 7/26/19 4:54 PM, Peter Zijlstra wrote: > > > Signed-off-by: Peter Zijlstra (Intel) [...] > @@ -889,6 +891,8 @@ static void update_curr(struct cfs_rq *c > trace_sched_stat_runtime(curtask, delta_exec, curr->vruntime); > cgroup_account_cputime(curtask,

[RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

2019-07-26 Thread Peter Zijlstra
Signed-off-by: Peter Zijlstra (Intel) --- include/linux/sched.h | 26 +++ kernel/sched/core.c |5 kernel/sched/deadline.c | 327 +++- kernel/sched/fair.c |4 kernel/sched/sched.h| 29 5 files changed, 277