Re: [RFC PATCH 22/68] vfs: Convert binderfs to use the new mount API

2019-04-10 Thread David Howells
Dan Carpenter wrote: > > + struct ipc_namespace *ipc_ns = fc->s_fs_info; > > + put_ipc_ns(ipc_ns); > > I feel like put_ipc_ns(info->ipc_ns) would be more readable. Not so much more readable as more correct. David

Re: [RFC PATCH 22/68] vfs: Convert binderfs to use the new mount API

2019-03-28 Thread Dan Carpenter
On Wed, Mar 27, 2019 at 11:43:20PM +, David Howells wrote: > +static void binderfs_free_fc(struct fs_context *fc) > +{ > + struct binderfs_info *info = fc->s_fs_info; > + > + if (info) { > + struct ipc_namespace *ipc_ns = fc->s_fs_info; > + put_ipc_ns(ipc_ns);

[RFC PATCH 22/68] vfs: Convert binderfs to use the new mount API

2019-03-27 Thread David Howells
Convert the binderfs filesystem to the new internal mount API as the old one will be obsoleted and removed. This allows greater flexibility in communication of mount parameters between userspace, the VFS and the filesystem. See Documentation/filesystems/mount_api.txt for more information.