Re: [External] Re: [RFC PATCH v2 09/18] mm: vmscan: remove noinline_for_stack

2021-04-10 Thread Shakeel Butt
On Fri, Apr 9, 2021 at 9:34 PM Muchun Song wrote: > > On Sat, Apr 10, 2021 at 2:31 AM Johannes Weiner wrote: > > > > On Fri, Apr 09, 2021 at 08:29:50PM +0800, Muchun Song wrote: > > > The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: > > > set up pagevec as late as possible

Re: [External] Re: [RFC PATCH v2 09/18] mm: vmscan: remove noinline_for_stack

2021-04-09 Thread Muchun Song
On Sat, Apr 10, 2021 at 2:31 AM Johannes Weiner wrote: > > On Fri, Apr 09, 2021 at 08:29:50PM +0800, Muchun Song wrote: > > The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: > > set up pagevec as late as possible in shrink_inactive_list()"), its > > purpose is to delay the

Re: [RFC PATCH v2 09/18] mm: vmscan: remove noinline_for_stack

2021-04-09 Thread Roman Gushchin
On Fri, Apr 09, 2021 at 08:29:50PM +0800, Muchun Song wrote: > The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: > set up pagevec as late as possible in shrink_inactive_list()"), its > purpose is to delay the allocation of pagevec as late as possible to > save stack memory. But

Re: [RFC PATCH v2 09/18] mm: vmscan: remove noinline_for_stack

2021-04-09 Thread Johannes Weiner
On Fri, Apr 09, 2021 at 08:29:50PM +0800, Muchun Song wrote: > The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: > set up pagevec as late as possible in shrink_inactive_list()"), its > purpose is to delay the allocation of pagevec as late as possible to > save stack memory. But

[RFC PATCH v2 09/18] mm: vmscan: remove noinline_for_stack

2021-04-09 Thread Muchun Song
The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: set up pagevec as late as possible in shrink_inactive_list()"), its purpose is to delay the allocation of pagevec as late as possible to save stack memory. But the commit 2bcf88796381 ("mm: take pagevecs off reclaim stack")