Re: [RFC PATCH v2 10/10] firmware: arm_scmi: Add virtio transport

2021-04-07 Thread Viresh Kumar
On Fri, Nov 6, 2020 at 2:59 AM Peter Hilber wrote: > +static int scmi_vio_probe(struct virtio_device *vdev) > +{ > + struct device *dev = >dev; > + struct scmi_vio_channel **vioch; > + bool have_vq_rx; > + int vq_cnt; > + int i; > + struct virtqueue

Re: [RFC PATCH v2 10/10] firmware: arm_scmi: Add virtio transport

2020-11-17 Thread Cristian Marussi
On Thu, Nov 12, 2020 at 11:57:09AM +0100, Peter Hilber wrote: > On 10.11.20 22:32, Cristian Marussi wrote: > > Hi Peter/Igor, > > > > I went through this series while trying to grasp a bit more of all the > > virtio inner workings and needs and I'll leave a few detailed comments > > down below. >

Re: [RFC PATCH v2 10/10] firmware: arm_scmi: Add virtio transport

2020-11-12 Thread Peter Hilber
On 10.11.20 22:32, Cristian Marussi wrote: > Hi Peter/Igor, > > I went through this series while trying to grasp a bit more of all the > virtio inner workings and needs and I'll leave a few detailed comments > down below. > > In short at first, I think I can say that there are a couple of places

Re: [RFC PATCH v2 10/10] firmware: arm_scmi: Add virtio transport

2020-11-10 Thread Cristian Marussi
Hi Peter/Igor, I went through this series while trying to grasp a bit more of all the virtio inner workings and needs and I'll leave a few detailed comments down below. In short at first, I think I can say that there are a couple of places where I noticed you had to play all sort of tricks to

[RFC PATCH v2 10/10] firmware: arm_scmi: Add virtio transport

2020-11-05 Thread Peter Hilber
From: Igor Skalkin This transport enables accessing an SCMI platform as a virtio device. Implement an SCMI virtio driver according to the virtio SCMI device spec patch v5 [1]. Virtio device id 32 has been reserved for the SCMI device [2]. The virtio transport has one tx channel (virtio cmdq,