Re: [RFC Part1 PATCH 07/13] x86/compressed: register GHCB memory when SNP is active

2021-04-08 Thread Borislav Petkov
On Wed, Apr 07, 2021 at 12:34:59PM -0500, Brijesh Singh wrote: > The feature is part of the GHCB version 2 and is enforced by the > hypervisor. I guess it can be extended for the ES. Since this feature > was not available in GHCB version 1 (base ES) so it should be presented > as an optional for

Re: [RFC Part1 PATCH 07/13] x86/compressed: register GHCB memory when SNP is active

2021-04-07 Thread Tom Lendacky
On 4/7/21 12:34 PM, Brijesh Singh wrote: > > On 4/7/21 6:59 AM, Borislav Petkov wrote: >> On Wed, Mar 24, 2021 at 11:44:18AM -0500, Brijesh Singh wrote: >>> The SEV-SNP guest is required to perform GHCB GPA registration. This is >> Why does it need to do that? Some additional security so as to

Re: [RFC Part1 PATCH 07/13] x86/compressed: register GHCB memory when SNP is active

2021-04-07 Thread Brijesh Singh
On 4/7/21 6:59 AM, Borislav Petkov wrote: > On Wed, Mar 24, 2021 at 11:44:18AM -0500, Brijesh Singh wrote: >> The SEV-SNP guest is required to perform GHCB GPA registration. This is > Why does it need to do that? Some additional security so as to not allow > changing the GHCB once it is

Re: [RFC Part1 PATCH 07/13] x86/compressed: register GHCB memory when SNP is active

2021-04-07 Thread Borislav Petkov
On Wed, Mar 24, 2021 at 11:44:18AM -0500, Brijesh Singh wrote: > The SEV-SNP guest is required to perform GHCB GPA registration. This is Why does it need to do that? Some additional security so as to not allow changing the GHCB once it is established? I'm guessing that's enforced by the SNP fw

[RFC Part1 PATCH 07/13] x86/compressed: register GHCB memory when SNP is active

2021-03-24 Thread Brijesh Singh
The SEV-SNP guest is required to perform GHCB GPA registration. This is because the hypervisor may prefer that a guest use a consistent and/or specific GPA for the GHCB associated with a vCPU. For more information, see the GHCB specification section 2.5.2. Currently, we do not support working