Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio

2021-03-08 Thread Andy Shevchenko
On Mon, Mar 8, 2021 at 6:28 PM Calvin Johnson wrote: > On Mon, Mar 08, 2021 at 04:57:35PM +0200, Andy Shevchenko wrote: > I thought of including device.h instead of dev_printk.h because, it is the > only file that includes dev_printk.h and device.h is widely used. Of course, > it will mean

Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio

2021-03-08 Thread Calvin Johnson
On Mon, Mar 08, 2021 at 04:57:35PM +0200, Andy Shevchenko wrote: > On Mon, Mar 8, 2021 at 4:11 PM Calvin Johnson > wrote: > > On Thu, Feb 18, 2021 at 05:08:05PM +0200, Andy Shevchenko wrote: > > > On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson > > > wrote: > > > > > Define

Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio

2021-03-08 Thread Andy Shevchenko
On Mon, Mar 8, 2021 at 4:11 PM Calvin Johnson wrote: > On Thu, Feb 18, 2021 at 05:08:05PM +0200, Andy Shevchenko wrote: > > On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson > > wrote: > > > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for > > > each ACPI child node. > > > >

Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio

2021-03-08 Thread Calvin Johnson
On Thu, Feb 18, 2021 at 05:08:05PM +0200, Andy Shevchenko wrote: > On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson > wrote: > > > > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for > > each ACPI child node. > > > +#include > > +#include > > Perhaps it's better to provide

Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio

2021-02-18 Thread Andy Shevchenko
On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson wrote: > > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for > each ACPI child node. > +#include > +#include Perhaps it's better to provide the headers that this file is direct user of, i.e. bits.h dev_printk.h module.h

[net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio

2021-02-17 Thread Calvin Johnson
Define acpi_mdiobus_register() to Register mii_bus and create PHYs for each ACPI child node. Signed-off-by: Calvin Johnson --- Changes in v6: - use GENMASK() and ACPI_COMPANION_SET() - some cleanup - remove unwanted header inclusion Changes in v5: - add missing MODULE_LICENSE() - replace