Re: [ofa-general] [PATCH 1/5] ehca: Supports large page MRs

2007-07-21 Thread Hoang-Nam Nguyen
Hi Roland! > I applied this, but I agree with checkpatch.pl: > > > WARNING: externs should be avoided in .c files > > #227: FILE: drivers/infiniband/hw/ehca/ehca_mrmw.c:67: > > +extern int ehca_mr_largepage; > > > > WARNING: externs should be avoided in .c files > > #949: FILE:

Re: [ofa-general] [PATCH 1/5] ehca: Supports large page MRs

2007-07-21 Thread Hoang-Nam Nguyen
Hi Roland! I applied this, but I agree with checkpatch.pl: WARNING: externs should be avoided in .c files #227: FILE: drivers/infiniband/hw/ehca/ehca_mrmw.c:67: +extern int ehca_mr_largepage; WARNING: externs should be avoided in .c files #949: FILE:

Re: [ofa-general] [PATCH 1/5] ehca: Supports large page MRs

2007-07-20 Thread Roland Dreier
I applied this, but I agree with checkpatch.pl: > WARNING: externs should be avoided in .c files > #227: FILE: drivers/infiniband/hw/ehca/ehca_mrmw.c:67: > +extern int ehca_mr_largepage; > > WARNING: externs should be avoided in .c files > #949: FILE:

Re: [ofa-general] [PATCH 1/5] ehca: Supports large page MRs

2007-07-20 Thread Roland Dreier
I applied this, but I agree with checkpatch.pl: WARNING: externs should be avoided in .c files #227: FILE: drivers/infiniband/hw/ehca/ehca_mrmw.c:67: +extern int ehca_mr_largepage; WARNING: externs should be avoided in .c files #949: FILE: drivers/infiniband/hw/ehca/hcp_if.c:753: +