RE: [EXT] Re: [v4] rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

2019-08-27 Thread Biwen Li
> > On 8/27/19 7:37 AM, Biwen Li wrote: > > - In drivers/rtc/rtc-pcf85363.c, CTRL_STOP_EN is 0x2e, but DT_100THS > >is 0, max_regiter is 0x2f, then reg will be equal to 0x30, > >'0x30 < 0x2f' is false,so regmap_writeable will return false. > > > > - The pcf85363/pcf85263

Re: [v4] rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

2019-08-27 Thread Nandor Han
On 8/27/19 7:37 AM, Biwen Li wrote: - In drivers/rtc/rtc-pcf85363.c, CTRL_STOP_EN is 0x2e, but DT_100THS is 0, max_regiter is 0x2f, then reg will be equal to 0x30, '0x30 < 0x2f' is false,so regmap_writeable will return false. - The pcf85363/pcf85263 has the capability of

[v4] rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

2019-08-26 Thread Biwen Li
Issue: - # hwclock -w hwclock: RTC_SET_TIME: Invalid argument Why: - Relative commit: 8b9f9d4dc511309918c4f6793bae7387c0c638af, this patch will always check for unwritable registers, it will compare reg with max_register in regmap_writeable. - In