Re: PROBLEM: Recent raid10 block discard patchset causes filesystem corruption on fstrim

2021-02-02 Thread Xiao Ni
On 02/02/2021 11:42 AM, Matthew Ruffell wrote: Hi Xiao, On 24/12/20 11:18 pm, Xiao Ni wrote:> The root cause is found. Now we use a similar way with raid0 to handle discard request for raid10. Because the discard region is very big, we can calculate the start/end address for each disk.

Re: PROBLEM: Recent raid10 block discard patchset causes filesystem corruption on fstrim

2021-02-01 Thread Matthew Ruffell
Hi Xiao, On 24/12/20 11:18 pm, Xiao Ni wrote:> The root cause is found. Now we use a similar way with raid0 to handle discard request > for raid10. Because the discard region is very big, we can calculate the > start/end address > for each disk. Then we can submit the discard request to each

Re: PROBLEM: Recent raid10 block discard patchset causes filesystem corruption on fstrim

2020-12-27 Thread Song Liu
Hi Xiao, On Thu, Dec 24, 2020 at 2:18 AM Xiao Ni wrote: > > > [...] > > [ 789.709501] discard bio start : 70968, size : 191176 > [ 789.709507] first stripe index 69, start disk index 0, start disk > offset 70968 > [ 789.709509] last stripe index 256, end disk index 0, end disk offset > 262144

Re: PROBLEM: Recent raid10 block discard patchset causes filesystem corruption on fstrim

2020-12-24 Thread Xiao Ni
On 12/09/2020 12:17 PM, Song Liu wrote: Hi Matthew, On Dec 8, 2020, at 7:46 PM, Matthew Ruffell wrote: Hello, I recently backported the following patches into the Ubuntu stable kernels: md: add md_submit_discard_bio() for submitting discard bio md/raid10: extend r10bio devs to raid

Re: PROBLEM: Recent raid10 block discard patchset causes filesystem corruption on fstrim

2020-12-09 Thread Xiao Ni
On 12/09/2020 12:17 PM, Song Liu wrote: Hi Matthew, On Dec 8, 2020, at 7:46 PM, Matthew Ruffell wrote: Hello, I recently backported the following patches into the Ubuntu stable kernels: md: add md_submit_discard_bio() for submitting discard bio md/raid10: extend r10bio devs to raid

Re: PROBLEM: Recent raid10 block discard patchset causes filesystem corruption on fstrim

2020-12-09 Thread Song Liu
> On Dec 8, 2020, at 8:17 PM, Song Liu wrote: > > Hi Matthew, > >> On Dec 8, 2020, at 7:46 PM, Matthew Ruffell >> wrote: >> >> Hello, >> >> I recently backported the following patches into the Ubuntu stable kernels: >> >> md: add md_submit_discard_bio() for submitting discard bio >>

Re: PROBLEM: Recent raid10 block discard patchset causes filesystem corruption on fstrim

2020-12-08 Thread Song Liu
Hi Matthew, > On Dec 8, 2020, at 7:46 PM, Matthew Ruffell > wrote: > > Hello, > > I recently backported the following patches into the Ubuntu stable kernels: > > md: add md_submit_discard_bio() for submitting discard bio > md/raid10: extend r10bio devs to raid disks > md/raid10: pull codes

PROBLEM: Recent raid10 block discard patchset causes filesystem corruption on fstrim

2020-12-08 Thread Matthew Ruffell
Hello, I recently backported the following patches into the Ubuntu stable kernels: md: add md_submit_discard_bio() for submitting discard bio md/raid10: extend r10bio devs to raid disks md/raid10: pull codes that wait for blocked dev into one function md/raid10: improve raid10 discard request