On Thu, 2020-12-03 at 07:27 +, Avri Altman wrote:
> >
> > From: Bean Huo
> >
> > Keep device power mode as active power mode and VCC supply only if
> > fWriteBoosterBufferFlushDuringHibernate setting 1 is successful.
>
Hi Avri
Thanks so much taking time reiew.
> Why would it fail?
During
On Fri, 2020-12-04 at 11:26 +0800, Can Guo wrote:
> >
> >if (!ufshcd_is_wb_allowed(hba))
> >return false;
> > +
> > + if (!hba->dev_info.is_hibern8_wb_flush)
> > + return false;
>
> The check is in the wrong place - even if say
>
On 2020-12-01 02:11, Bean Huo wrote:
From: Bean Huo
Keep device power mode as active power mode and VCC supply only if
fWriteBoosterBufferFlushDuringHibernate setting 1 is successful.
Signed-off-by: Bean Huo
---
drivers/scsi/ufs/ufs.h| 2 ++
drivers/scsi/ufs/ufshcd.c | 11 ++-
On Thu, 2020-12-03 at 12:15 +, Avri Altman wrote:
> > so, you agree the possiblity of failure exists.
>
> I was more relating to the lottery part.
It doesn't matter. even the possibility of winning a lottery is very
low, but still there is.
> >
> > > Hence we need-not any extra logic
> On Thu, 2020-12-03 at 10:46 +, Avri Altman wrote:
> > > > > From: Bean Huo
> > > > >
> > > > > Keep device power mode as active power mode and VCC supply only
> > > > > if
> > > > > fWriteBoosterBufferFlushDuringHibernate setting 1 is
> > > > > successful.
> > >
> > > Hi Avri
> > > Thanks
On Thu, 2020-12-03 at 10:46 +, Avri Altman wrote:
> > > > From: Bean Huo
> > > >
> > > > Keep device power mode as active power mode and VCC supply only
> > > > if
> > > > fWriteBoosterBufferFlushDuringHibernate setting 1 is
> > > > successful.
> >
> > Hi Avri
> > Thanks so much taking time
>
> On Thu, 2020-12-03 at 07:27 +, Avri Altman wrote:
> > >
> > > From: Bean Huo
> > >
> > > Keep device power mode as active power mode and VCC supply only if
> > > fWriteBoosterBufferFlushDuringHibernate setting 1 is successful.
>
> Hi Avri
> Thanks so much taking time reiew.
>
> > Why
On Thu, 2020-12-03 at 07:27 +, Avri Altman wrote:
> >
> > From: Bean Huo
> >
> > Keep device power mode as active power mode and VCC supply only if
> > fWriteBoosterBufferFlushDuringHibernate setting 1 is successful.
Hi Avri
Thanks so much taking time reiew.
> Why would it fail?
During
>
> From: Bean Huo
>
> Keep device power mode as active power mode and VCC supply only if
> fWriteBoosterBufferFlushDuringHibernate setting 1 is successful.
Why would it fail?
Since UFSHCD_CAP_WB_EN is toggled off on ufshcd_wb_probe If the device doesn't
support wb,
The check
9 matches
Mail list logo
