RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-07-02 Thread Anson Huang
Hi, Arnd/Stephen > Subject: Re: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > Quoting Arnd Bergmann (2020-06-29 01:19:44) > > On Mon, Jun 29, 2020 at 9:18 AM Dong Aisheng > wrote: > > > On Thu, Jun 25, 2020 at 6:43 AM Stephen Boyd &g

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-29 Thread Anson Huang
> Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > > From: Arnd Bergmann > > Sent: Monday, June 29, 2020 4:20 PM > > > > On Mon, Jun 29, 2020 at 9:18 AM Dong Aisheng > > wrote: > > > On Thu, Jun 25, 2020 a

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-29 Thread Aisheng Dong
> From: Arnd Bergmann > Sent: Monday, June 29, 2020 4:20 PM > > On Mon, Jun 29, 2020 at 9:18 AM Dong Aisheng > wrote: > > On Thu, Jun 25, 2020 at 6:43 AM Stephen Boyd wrote: > > > Quoting Aisheng Dong (2020-06-23 19:59:09) Why aren't there options > > > to enable clk-imx6q and clk-imx6sl in

Re: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-29 Thread Arnd Bergmann
On Mon, Jun 29, 2020 at 9:18 AM Dong Aisheng wrote: > On Thu, Jun 25, 2020 at 6:43 AM Stephen Boyd wrote: > > Quoting Aisheng Dong (2020-06-23 19:59:09) > > Why aren't there options to enable clk-imx6q and clk-imx6sl in the > > clk/imx/Kconfig file? Those can be bool or tristate depending on if

Re: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-29 Thread Dong Aisheng
On Thu, Jun 25, 2020 at 6:43 AM Stephen Boyd wrote: > > Quoting Aisheng Dong (2020-06-23 19:59:09) > > > > > > - bool > > > > > > - def_bool ARCH_MXC > > > > > > + tristate "IMX clock" > > > > > > + depends on ARCH_MXC > > > > > > > > > > > > But user can still set MXC_CLK

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-24 Thread Stephen Boyd
Quoting Aisheng Dong (2020-06-23 19:59:09) > > > > > - bool > > > > > - def_bool ARCH_MXC > > > > > + tristate "IMX clock" > > > > > + depends on ARCH_MXC > > > > > > > > > > But user can still set MXC_CLK to be m, either via make menuconfig > > > > > or > > > > defconfig.

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-24 Thread Aisheng Dong
> From: Arnd Bergmann > Sent: Wednesday, June 24, 2020 3:47 PM > > On Wed, Jun 24, 2020 at 4:19 AM Aisheng Dong > wrote: > > > Isn't that what we want? > > > > No, if user set MXC_CLK to m, the build will break for i.MX6&7. > > > > > Why does ARCH_MXC being enabled mandate that it is builtin?

Re: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-24 Thread Arnd Bergmann
On Wed, Jun 24, 2020 at 4:19 AM Aisheng Dong wrote: > > Isn't that what we want? > > No, if user set MXC_CLK to m, the build will break for i.MX6&7. > > > Why does ARCH_MXC being enabled mandate that it is > > builtin? Is some architecture level code calling into the clk driver? > > > It's mainly

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-23 Thread Aisheng Dong
> From: Anson Huang > Sent: Wednesday, June 24, 2020 10:36 AM > > > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock > > driver as module > > > > > From: Stephen Boyd > > > Sent: Wednesday, June 24, 2020 8:58 AM > > > Subj

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-23 Thread Anson Huang
> Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > > From: Stephen Boyd > > Sent: Wednesday, June 24, 2020 8:58 AM > > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock > > driver as module > > > &

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-23 Thread Aisheng Dong
> From: Stephen Boyd > Sent: Wednesday, June 24, 2020 8:58 AM > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > Quoting Aisheng Dong (2020-06-23 02:00:47) > > > From: Stephen Boyd > > > Sent: Tuesday, June 23, 2020 4:34

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-23 Thread Stephen Boyd
Quoting Aisheng Dong (2020-06-23 02:00:47) > > From: Stephen Boyd > > Sent: Tuesday, June 23, 2020 4:34 PM > > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > > module > > > > Quoting Aisheng Dong (2020-06-22 20:42:19) >

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-23 Thread Aisheng Dong
> From: Stephen Boyd > Sent: Tuesday, June 23, 2020 4:34 PM > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > Quoting Aisheng Dong (2020-06-22 20:42:19) > > > From: Stephen Boyd > > > Sent: Saturday, June 20, 2020 11:28

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-23 Thread Stephen Boyd
Quoting Aisheng Dong (2020-06-22 20:42:19) > > From: Stephen Boyd > > Sent: Saturday, June 20, 2020 11:28 AM > > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > > module > > > > Quoting Aisheng Dong (2020-06-17 18:58:51) > &g

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-22 Thread Aisheng Dong
> From: Stephen Boyd > Sent: Saturday, June 20, 2020 11:28 AM > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > Quoting Aisheng Dong (2020-06-17 18:58:51) > > > From: Anson Huang > > > > > +obj-$(CONFIG_MXC_CLK_

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-19 Thread Stephen Boyd
Quoting Aisheng Dong (2020-06-17 18:58:51) > > From: Anson Huang > > > > +obj-$(CONFIG_MXC_CLK_SCU) += mxc-clk-scu.o > > > > > > Like i.MX pinctrl, I'm not sure if it's really necessary to build core > > > libraries as modules. Probably the simplest way is only building > > > platform drivers

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-17 Thread Aisheng Dong
> From: Anson Huang > Sent: Wednesday, June 17, 2020 8:27 PM > > > > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock > > driver as module > > > > > From: Anson Huang > > > Sent: Tuesday, June 9, 2020 3:32 PM > > > &

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-17 Thread Anson Huang
> Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > > From: Anson Huang > > Sent: Tuesday, June 9, 2020 3:32 PM > > > > There are more and more requirements of building SoC specific drivers > > as modules, add support

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-17 Thread Aisheng Dong
> From: Anson Huang > Sent: Tuesday, June 9, 2020 3:32 PM > > There are more and more requirements of building SoC specific drivers as > modules, add support for building SCU clock driver as module to meet the > requirement. > > Signed-off-by: Anson Huang > --- > Changes since V1: > -