Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Mark Brown
On Thu, Mar 21, 2024 at 08:14:44PM +0100, Karel Balej wrote: > Mark Brown, 2024-03-21T19:00:24+00:00: > > I would expect that if you have two separate register maps they would > > have separate configurations that describe the corresponding physical > > register maps, as far as I can tell this

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Karel Balej
Mark Brown, 2024-03-21T19:00:24+00:00: > On Thu, Mar 21, 2024 at 07:16:43PM +0100, Karel Balej wrote: > > Mark Brown, 2024-03-21T17:48:28+00:00: > > > > > They do according to the downstream driver which is my only reference. > > > > In fact, there the driver defines the configs separately for

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Mark Brown
On Thu, Mar 21, 2024 at 07:16:43PM +0100, Karel Balej wrote: > Mark Brown, 2024-03-21T17:48:28+00:00: > > > They do according to the downstream driver which is my only reference. > > > In fact, there the driver defines the configs separately for each regmap > > > but with the same values. > >

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Karel Balej
Mark Brown, 2024-03-21T17:48:28+00:00: > On Thu, Mar 21, 2024 at 06:32:03PM +0100, Karel Balej wrote: > > Mark Brown, 2024-03-21T17:17:40+00:00: > > > > Do they both genuinely have the same maximum register? > > > They do according to the downstream driver which is my only reference. > > In fact,

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Mark Brown
On Thu, Mar 21, 2024 at 06:32:03PM +0100, Karel Balej wrote: > Mark Brown, 2024-03-21T17:17:40+00:00: > > Do they both genuinely have the same maximum register? > They do according to the downstream driver which is my only reference. > In fact, there the driver defines the configs separately for

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Karel Balej
Mark Brown, 2024-03-21T17:17:40+00:00: > On Thu, Mar 21, 2024 at 06:08:16PM +0100, Karel Balej wrote: > > Mark Brown, 2024-03-21T16:58:44+00:00: > > > > > > > > > +static const struct regmap_config pm886_i2c_regmap = { > > > > > > > > + .reg_bits = 8, > > > > > > > > + .val_bits = 8, >

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Mark Brown
On Thu, Mar 21, 2024 at 06:08:16PM +0100, Karel Balej wrote: > Mark Brown, 2024-03-21T16:58:44+00:00: > > > > > > > +static const struct regmap_config pm886_i2c_regmap = { > > > > > > > + .reg_bits = 8, > > > > > > > + .val_bits = 8, > > > > > > > + .max_register = PM886_REGMAP_CONF_MAX_REG, > >

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Karel Balej
Mark Brown, 2024-03-21T16:58:44+00:00: > On Thu, Mar 21, 2024 at 05:55:17PM +0100, Karel Balej wrote: > > Lee Jones, 2024-03-21T16:20:45+00:00: > > > On Thu, 21 Mar 2024, Karel Balej wrote: > > > > > > > +static const struct regmap_config pm886_i2c_regmap = { > > > > > > + .reg_bits = 8, > > > >

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Mark Brown
On Thu, Mar 21, 2024 at 05:55:17PM +0100, Karel Balej wrote: > Lee Jones, 2024-03-21T16:20:45+00:00: > > On Thu, 21 Mar 2024, Karel Balej wrote: > > > > > +static const struct regmap_config pm886_i2c_regmap = { > > > > > + .reg_bits = 8, > > > > > + .val_bits = 8, > > > > > +

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Karel Balej
Lee Jones, 2024-03-21T16:20:45+00:00: > On Thu, 21 Mar 2024, Karel Balej wrote: > > > Lee Jones, 2024-03-21T15:42:11+00:00: > > > On Mon, 11 Mar 2024, Karel Balej wrote: > > > > diff --git a/include/linux/mfd/88pm886.h b/include/linux/mfd/88pm886.h > > > > new file mode 100644 > > > > index

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Lee Jones
On Thu, 21 Mar 2024, Karel Balej wrote: > Lee Jones, 2024-03-21T15:42:11+00:00: > > On Mon, 11 Mar 2024, Karel Balej wrote: > > > > > From: Karel Balej > > > > > > Marvell 88PM886 is a PMIC which provides various functions such as > > > onkey, battery, charger and regulators. It is found for

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Karel Balej
Lee Jones, 2024-03-21T15:42:11+00:00: > On Mon, 11 Mar 2024, Karel Balej wrote: > > > From: Karel Balej > > > > Marvell 88PM886 is a PMIC which provides various functions such as > > onkey, battery, charger and regulators. It is found for instance in the > > samsung,coreprimevelte smartphone

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Lee Jones
On Mon, 11 Mar 2024, Karel Balej wrote: > From: Karel Balej > > Marvell 88PM886 is a PMIC which provides various functions such as > onkey, battery, charger and regulators. It is found for instance in the > samsung,coreprimevelte smartphone with which this was tested. Implement > basic support