Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-23 Thread Andrea Parri
> I am not suggesting to remove all comments. Some human readable > explanation is important as long as the code is developed by humans. > > I think that I'll have to accept also the extra comments if you are > really going to use them to check the consistency by a tool. Or > if they are really

Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-23 Thread Petr Mladek
On Thu 2019-08-22 19:38:01, Andrea Parri wrote: > On Thu, Aug 22, 2019 at 03:50:52PM +0200, Petr Mladek wrote: > > On Wed 2019-08-21 07:46:28, John Ogness wrote: > > > On 2019-08-20, Sergey Senozhatsky > > > wrote: > > > > [..] > > > >> > + * > > > >> > + * Memory barrier involvement: >

Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-23 Thread Petr Mladek
On Fri 2019-08-23 14:54:45, Sergey Senozhatsky wrote: > On (08/21/19 07:46), John Ogness wrote: > [..] > > The labels are necessary for the technical documentation of the > > barriers. And, after spending much time in this, I find them very > > useful. But I agree that there needs to be a better

Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-23 Thread Sergey Senozhatsky
On (08/22/19 15:50), Petr Mladek wrote: [..] > I could understand that you spend a lot of time on creating the > labels and that they are somehow useful for you. > > But I am not using them and I hope that I will not have to: > > + Grepping takes a lot of time, especially over several files.

Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-22 Thread Sergey Senozhatsky
On (08/21/19 07:46), John Ogness wrote: [..] > The labels are necessary for the technical documentation of the > barriers. And, after spending much time in this, I find them very > useful. But I agree that there needs to be a better way to assign label > names. [..] > > Where dp stands for

Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-22 Thread Andrea Parri
On Thu, Aug 22, 2019 at 03:50:52PM +0200, Petr Mladek wrote: > On Wed 2019-08-21 07:46:28, John Ogness wrote: > > On 2019-08-20, Sergey Senozhatsky wrote: > > > [..] > > >> > + * > > >> > + * Memory barrier involvement: > > >> > + * > > >> > + * If dB reads from gA, then

Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-22 Thread Petr Mladek
On Wed 2019-08-21 07:46:28, John Ogness wrote: > On 2019-08-20, Sergey Senozhatsky wrote: > > [..] > >> > + * > >> > + * Memory barrier involvement: > >> > + * > >> > + * If dB reads from gA, then dC reads from fG. > >> > + * If dB reads from gA, then dD

Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-22 Thread Petr Mladek
On Wed 2019-08-21 07:42:57, John Ogness wrote: > On 2019-08-20, Petr Mladek wrote: > >> --- /dev/null > >> +++ b/kernel/printk/dataring.c > >> +/** > >> + * _datablock_valid() - Check if given positions yield a valid data block. > >> + * > >> + * @dr: The associated data ringbuffer. > >>

Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-20 Thread John Ogness
On 2019-08-20, Sergey Senozhatsky wrote: > [..] >> > + * >> > + * Memory barrier involvement: >> > + * >> > + * If dB reads from gA, then dC reads from fG. >> > + * If dB reads from gA, then dD reads from fH. >> > + * If dB reads from gA, then dE reads from fE. >> > + * >> > + *

Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-20 Thread John Ogness
On 2019-08-20, Petr Mladek wrote: >> --- /dev/null >> +++ b/kernel/printk/dataring.c >> +/** >> + * _datablock_valid() - Check if given positions yield a valid data block. >> + * >> + * @dr: The associated data ringbuffer. >> + * >> + * @head_lpos: The newest data logical position. >> +

Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-20 Thread Sergey Senozhatsky
On (08/20/19 10:55), Petr Mladek wrote: [..] > > +* > > +* Memory barrier involvement: > > +* > > +* If dB reads from gA, then dC reads from fG. > > +* If dB reads from gA, then dD reads from fH. > > +* If dB reads from gA, then dE reads from fE. > > +* > > +* Note

comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-20 Thread Petr Mladek
On Thu 2019-08-08 00:32:26, John Ogness wrote: > --- /dev/null > +++ b/kernel/printk/dataring.c > +/** > + * _datablock_valid() - Check if given positions yield a valid data block. > + * > + * @dr: The associated data ringbuffer. > + * > + * @head_lpos: The newest data logical position. >