Re: numlist_pop(): Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-09-04 Thread Peter Zijlstra
On Tue, Aug 20, 2019 at 10:15:18AM +0200, Petr Mladek wrote: > do { > tail_id = atomic_long_read(>tail_id); > > /* >* Read might fail when the tail node has been removed >* and reused in parallel. >*/ >

Re: numlist_pop(): Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-20 Thread John Ogness
On 2019-08-20, Petr Mladek wrote: >> --- /dev/null >> +++ b/kernel/printk/numlist.c >> +/** >> + * numlist_pop() - Remove the oldest node from the list. >> + * >> + * @nl: The numbered list from which to remove the tail node. >> + * >> + * The tail node can only be removed if two conditions are

numlist_pop(): Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-20 Thread Petr Mladek
On Thu 2019-08-08 00:32:26, John Ogness wrote: > --- /dev/null > +++ b/kernel/printk/numlist.c > +/** > + * numlist_pop() - Remove the oldest node from the list. > + * > + * @nl: The numbered list from which to remove the tail node. > + * > + * The tail node can only be removed if two conditions