Re: poisoned pages do not play well in the buddy allocator

2019-08-30 Thread Oscar Salvador
On Fri, Aug 30, 2019 at 02:36:56PM +0200, Michal Hocko wrote: > > - Free page: remove it from the buddy allocator and set it as > > PageReserved|PageHWPoison. > > - Used page: migrate it and do not release it (skip put_page in > > unmap_and_move for MR_MEMORY_FAILURE > > reason). Set it

Re: poisoned pages do not play well in the buddy allocator

2019-08-30 Thread Michal Hocko
On Fri 30-08-19 12:45:35, Oscar Salvador wrote: > On Tue, Aug 27, 2019 at 09:28:13AM +0200, Oscar Salvador wrote: > > On Tue, Aug 27, 2019 at 01:34:29AM +, Naoya Horiguchi wrote: > > > > @Naoya: I could give it a try if you are busy. > > > > > > Thanks for raising hand. That's really

Re: poisoned pages do not play well in the buddy allocator

2019-08-30 Thread Oscar Salvador
On Tue, Aug 27, 2019 at 09:28:13AM +0200, Oscar Salvador wrote: > On Tue, Aug 27, 2019 at 01:34:29AM +, Naoya Horiguchi wrote: > > > @Naoya: I could give it a try if you are busy. > > > > Thanks for raising hand. That's really wonderful. I think that the series > > [1] is not > > merge yet

Re: poisoned pages do not play well in the buddy allocator

2019-08-27 Thread Oscar Salvador
On Tue, Aug 27, 2019 at 01:34:29AM +, Naoya Horiguchi wrote: > > @Naoya: I could give it a try if you are busy. > > Thanks for raising hand. That's really wonderful. I think that the series [1] > is not > merge yet but not rejected yet, so feel free to reuse/update/revamp it. I will

Re: poisoned pages do not play well in the buddy allocator

2019-08-26 Thread Naoya Horiguchi
On Mon, Aug 26, 2019 at 12:41:50PM +0200, Oscar Salvador wrote: > Hi, > > When analyzing a problem reported by one of our customers, I stumbbled upon > an issue > that origins from the fact that poisoned pages end up in the buddy allocator. > > Let me break down the stepts that lie to the

Re: poisoned pages do not play well in the buddy allocator

2019-08-26 Thread Michal Hocko
On Mon 26-08-19 12:41:50, Oscar Salvador wrote: [...] > I checked [1], and it seems that [2] was going towards fixing this kind of > issue. > > I think it is about time to revamp the whole thing. I completely agree. The current state of hwpoison is just too fragile to be practically usable. We

poisoned pages do not play well in the buddy allocator

2019-08-26 Thread Oscar Salvador
Hi, When analyzing a problem reported by one of our customers, I stumbbled upon an issue that origins from the fact that poisoned pages end up in the buddy allocator. Let me break down the stepts that lie to the problem: 1) We soft-offline a page 2) Page gets flagged as HWPoison and is being