Re: rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang)QUILT

2019-08-26 Thread Geert Uytterhoeven
Hi Linus, On Wed, Aug 21, 2019 at 2:41 AM Linus Torvalds wrote: > On Tue, Aug 20, 2019 at 4:37 PM Joe Perches wrote: > > > So I'm putting my foot down on yet another broken string copy > > > interface from people who do not understand this fundamental issue. > > > > I think you are mistaken

Re: rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang)QUILT

2019-08-20 Thread Willy Tarreau
On Tue, Aug 20, 2019 at 05:43:27PM -0700, Linus Torvalds wrote: > I would seriously suggest doing something like > >copy_string( dst, dstsize, src, srcsize, FLAGS ); > > where FLAGS migth be "pad" or whatever. Make it return the size of the > resulting string, because while it can be

Re: rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang)QUILT

2019-08-20 Thread Linus Torvalds
On Tue, Aug 20, 2019 at 5:20 PM Joe Perches wrote: > > Umm, btw: have you actually looked at stracpy? Yes, Joe, I have. What part of "there are now so many of them that no human being can keep track of them" didn't you see as a problem? How many broken string functions are we going to do,

Re: rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang)QUILT

2019-08-20 Thread Linus Torvalds
On Tue, Aug 20, 2019 at 4:37 PM Joe Perches wrote: > > > So I'm putting my foot down on yet another broken string copy > > interface from people who do not understand this fundamental issue. > > I think you are mistaken about the stracpy limits as > the only limit is not the source size but the

Re: rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang)QUILT

2019-08-20 Thread Stephen Rothwell
Hi Joe, On Mon, 19 Aug 2019 17:08:00 -0700 Joe Perches wrote: > > A few examples: > > 1: a patch just to MAINTAINERS done via bash script: > > https://lore.kernel.org/lkml/904551f1f198ffac9a0f9c3c99aa966b0a7c76c1.ca...@perches.com/ > > $ git grep -h "^[FX]:" MAINTAINERS | \ > cut -f2- |

Re: rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang)QUILT

2019-08-20 Thread Joe Perches
On Tue, 2019-08-20 at 16:28 -0700, Linus Torvalds wrote: > On Mon, Aug 19, 2019 at 5:08 PM Joe Perches wrote: > > 2: would be Julia Lawall's stracpy change done > > with coccinelle: (attached) > > I'm not actually convinced about stracpy() and friends. > > It seems to be yet another badly

Re: rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang)QUILT

2019-08-20 Thread Joe Perches
On Tue, 2019-08-20 at 16:28 -0700, Linus Torvalds wrote: > On Mon, Aug 19, 2019 at 5:08 PM Joe Perches wrote: > > 2: would be Julia Lawall's stracpy change done > > with coccinelle: (attached) > > I'm not actually convinced about stracpy() and friends. > > It seems to be yet another badly

Re: rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang)QUILT

2019-08-20 Thread Linus Torvalds
On Mon, Aug 19, 2019 at 5:08 PM Joe Perches wrote: > > 2: would be Julia Lawall's stracpy change done > with coccinelle: (attached) I'm not actually convinced about stracpy() and friends. It seems to be yet another badly thought out string interface, and there are now so many of them that no

Re: rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang)QUILT

2019-08-19 Thread Joe Perches
On Tue, 2019-08-20 at 09:24 +1000, Stephen Rothwell wrote: > Hi Joe, Hi Stephen > Sorry for the slow response. No worries. thanks for picking up the thread. > On Fri, 16 Aug 2019 12:58:27 -0700 Joe Perches wrote: > > On Sat, 2019-08-10 at 13:33 -0700, Joe Perches wrote: > > > On Sat,

Re: rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang)QUILT

2019-08-19 Thread Stephen Rothwell
Hi Joe, Sorry for the slow response. On Fri, 16 Aug 2019 12:58:27 -0700 Joe Perches wrote: > > On Sat, 2019-08-10 at 13:33 -0700, Joe Perches wrote: > > On Sat, 2019-08-10 at 13:18 -0700, Joe Perches wrote: > [] > > > There are classes of patches generated by scripts that have > > > no real