Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-11-02 Thread Hugh Dickins
On Thu, 1 Nov 2012, Dave Jones wrote: > On Thu, Nov 01, 2012 at 04:48:41PM -0700, Hugh Dickins wrote: > > > > Fedora turns on CONFIG_DEBUG_VM? > > Yes. > > > All mm developers should thank you for the wider testing exposure; > > but I'm not so sure that Fedora users should thank you for

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-11-02 Thread Hugh Dickins
On Thu, 1 Nov 2012, Dave Jones wrote: On Thu, Nov 01, 2012 at 04:48:41PM -0700, Hugh Dickins wrote: Fedora turns on CONFIG_DEBUG_VM? Yes. All mm developers should thank you for the wider testing exposure; but I'm not so sure that Fedora users should thank you for turning it

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-11-01 Thread Dave Jones
On Thu, Nov 01, 2012 at 04:48:41PM -0700, Hugh Dickins wrote: > On Thu, 1 Nov 2012, Dave Jones wrote: > > On Thu, Nov 01, 2012 at 04:03:40PM -0700, Hugh Dickins wrote: > > > > > > Except... earlier in the thread you explained how you hacked > > > #define VM_BUG_ON(cond) WARN_ON(cond) > >

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-11-01 Thread Hugh Dickins
On Thu, 1 Nov 2012, Dave Jones wrote: > On Thu, Nov 01, 2012 at 04:03:40PM -0700, Hugh Dickins wrote: > > > > Except... earlier in the thread you explained how you hacked > > #define VM_BUG_ON(cond) WARN_ON(cond) > > to get this to come out as a warning instead of a bug, > > and now it looks

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-11-01 Thread Dave Jones
On Thu, Nov 01, 2012 at 04:03:40PM -0700, Hugh Dickins wrote: > > I just noticed we had a user report hitting this same warning, but > > with a different trace.. > > > > : [] warn_slowpath_common+0x7f/0xc0 > > : [] warn_slowpath_null+0x1a/0x20 > > : [] shmem_getpage_gfp+0x7f3/0x830 > > :

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-11-01 Thread Hugh Dickins
On Thu, 1 Nov 2012, Dave Jones wrote: > On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: > > On Wed, 24 Oct 2012, Dave Jones wrote: > > > > > Machine under significant load (4gb memory used, swap usage fluctuating) > > > triggered this... > > > > > > WARNING: at

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-11-01 Thread Dave Jones
On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: > On Wed, 24 Oct 2012, Dave Jones wrote: > > > Machine under significant load (4gb memory used, swap usage fluctuating) > > triggered this... > > > > WARNING: at mm/shmem.c:1151 shmem_getpage_gfp+0xa5c/0xa70() > > Pid: 29795,

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-11-01 Thread Dave Jones
On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: On Wed, 24 Oct 2012, Dave Jones wrote: Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at mm/shmem.c:1151 shmem_getpage_gfp+0xa5c/0xa70() Pid: 29795, comm:

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-11-01 Thread Hugh Dickins
On Thu, 1 Nov 2012, Dave Jones wrote: On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: On Wed, 24 Oct 2012, Dave Jones wrote: Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at mm/shmem.c:1151

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-11-01 Thread Dave Jones
On Thu, Nov 01, 2012 at 04:03:40PM -0700, Hugh Dickins wrote: I just noticed we had a user report hitting this same warning, but with a different trace.. : [8105b84f] warn_slowpath_common+0x7f/0xc0 : [8105b8aa] warn_slowpath_null+0x1a/0x20 : [81143c73]

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-11-01 Thread Hugh Dickins
On Thu, 1 Nov 2012, Dave Jones wrote: On Thu, Nov 01, 2012 at 04:03:40PM -0700, Hugh Dickins wrote: Except... earlier in the thread you explained how you hacked #define VM_BUG_ON(cond) WARN_ON(cond) to get this to come out as a warning instead of a bug, and now it looks as if a

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-11-01 Thread Dave Jones
On Thu, Nov 01, 2012 at 04:48:41PM -0700, Hugh Dickins wrote: On Thu, 1 Nov 2012, Dave Jones wrote: On Thu, Nov 01, 2012 at 04:03:40PM -0700, Hugh Dickins wrote: Except... earlier in the thread you explained how you hacked #define VM_BUG_ON(cond) WARN_ON(cond) to get this

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Ni zhan Chen
On 10/26/2012 05:48 AM, Hugh Dickins wrote: On Thu, 25 Oct 2012, Johannes Weiner wrote: On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: On Wed, 24 Oct 2012, Dave Jones wrote: Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Ni zhan Chen
On 10/26/2012 05:27 AM, Hugh Dickins wrote: On Thu, 25 Oct 2012, Ni zhan Chen wrote: On 10/25/2012 02:59 PM, Hugh Dickins wrote: On Thu, 25 Oct 2012, Ni zhan Chen wrote: I think it maybe caused by your commit [d189922862e03ce: shmem: fix negative rss in memcg memory.stat], one question:

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Hugh Dickins
On Thu, 25 Oct 2012, Johannes Weiner wrote: > On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: > > On Wed, 24 Oct 2012, Dave Jones wrote: > > > > > Machine under significant load (4gb memory used, swap usage fluctuating) > > > triggered this... > > > > > > WARNING: at

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Hugh Dickins
On Thu, 25 Oct 2012, Dave Jones wrote: > On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: > > > Clutching at straws, I expect this is entirely irrelevant, but: > > there isn't a warning on line 1151 of mm/shmem.c in 3.7.0-rc2 nor > > in current linux.git; rather, there's a

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Hugh Dickins
On Thu, 25 Oct 2012, Ni zhan Chen wrote: > On 10/25/2012 02:59 PM, Hugh Dickins wrote: > > On Thu, 25 Oct 2012, Ni zhan Chen wrote: > > > > > > I think it maybe caused by your commit [d189922862e03ce: shmem: fix > > > negative > > > rss in memcg memory.stat], one question: > > Well, yes, I added

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Johannes Weiner
On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: > On Wed, 24 Oct 2012, Dave Jones wrote: > > > Machine under significant load (4gb memory used, swap usage fluctuating) > > triggered this... > > > > WARNING: at mm/shmem.c:1151 shmem_getpage_gfp+0xa5c/0xa70() > > Pid: 29795, comm:

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Dave Jones
On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: > > 1148 error = shmem_add_to_page_cache(page, > > mapping, index, > > 1149 gfp, > > swp_to_radix_entry(swap)); > > 1150 /* We

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Ni zhan Chen
On 10/25/2012 02:59 PM, Hugh Dickins wrote: On Thu, 25 Oct 2012, Ni zhan Chen wrote: On 10/25/2012 12:36 PM, Hugh Dickins wrote: On Wed, 24 Oct 2012, Dave Jones wrote: Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at mm/shmem.c:1151

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Hugh Dickins
On Thu, 25 Oct 2012, Ni zhan Chen wrote: > On 10/25/2012 12:36 PM, Hugh Dickins wrote: > > On Wed, 24 Oct 2012, Dave Jones wrote: > > > > > Machine under significant load (4gb memory used, swap usage fluctuating) > > > triggered this... > > > > > > WARNING: at mm/shmem.c:1151

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Hugh Dickins
On Thu, 25 Oct 2012, Ni zhan Chen wrote: On 10/25/2012 12:36 PM, Hugh Dickins wrote: On Wed, 24 Oct 2012, Dave Jones wrote: Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at mm/shmem.c:1151 shmem_getpage_gfp+0xa5c/0xa70()

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Ni zhan Chen
On 10/25/2012 02:59 PM, Hugh Dickins wrote: On Thu, 25 Oct 2012, Ni zhan Chen wrote: On 10/25/2012 12:36 PM, Hugh Dickins wrote: On Wed, 24 Oct 2012, Dave Jones wrote: Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at mm/shmem.c:1151

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Dave Jones
On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: 1148 error = shmem_add_to_page_cache(page, mapping, index, 1149 gfp, swp_to_radix_entry(swap)); 1150 /* We already

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Johannes Weiner
On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: On Wed, 24 Oct 2012, Dave Jones wrote: Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at mm/shmem.c:1151 shmem_getpage_gfp+0xa5c/0xa70() Pid: 29795, comm: trinity-child4

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Hugh Dickins
On Thu, 25 Oct 2012, Ni zhan Chen wrote: On 10/25/2012 02:59 PM, Hugh Dickins wrote: On Thu, 25 Oct 2012, Ni zhan Chen wrote: I think it maybe caused by your commit [d189922862e03ce: shmem: fix negative rss in memcg memory.stat], one question: Well, yes, I added the VM_BUG_ON in

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Hugh Dickins
On Thu, 25 Oct 2012, Dave Jones wrote: On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: Clutching at straws, I expect this is entirely irrelevant, but: there isn't a warning on line 1151 of mm/shmem.c in 3.7.0-rc2 nor in current linux.git; rather, there's a VM_BUG_ON on

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Hugh Dickins
On Thu, 25 Oct 2012, Johannes Weiner wrote: On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: On Wed, 24 Oct 2012, Dave Jones wrote: Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at mm/shmem.c:1151

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Ni zhan Chen
On 10/26/2012 05:27 AM, Hugh Dickins wrote: On Thu, 25 Oct 2012, Ni zhan Chen wrote: On 10/25/2012 02:59 PM, Hugh Dickins wrote: On Thu, 25 Oct 2012, Ni zhan Chen wrote: I think it maybe caused by your commit [d189922862e03ce: shmem: fix negative rss in memcg memory.stat], one question:

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-25 Thread Ni zhan Chen
On 10/26/2012 05:48 AM, Hugh Dickins wrote: On Thu, 25 Oct 2012, Johannes Weiner wrote: On Wed, Oct 24, 2012 at 09:36:27PM -0700, Hugh Dickins wrote: On Wed, 24 Oct 2012, Dave Jones wrote: Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-24 Thread Ni zhan Chen
On 10/25/2012 12:36 PM, Hugh Dickins wrote: On Wed, 24 Oct 2012, Dave Jones wrote: Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at mm/shmem.c:1151 shmem_getpage_gfp+0xa5c/0xa70() Pid: 29795, comm: trinity-child4 Not tainted 3.7.0-rc2+ #49

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-24 Thread Hugh Dickins
On Wed, 24 Oct 2012, Dave Jones wrote: > Machine under significant load (4gb memory used, swap usage fluctuating) > triggered this... > > WARNING: at mm/shmem.c:1151 shmem_getpage_gfp+0xa5c/0xa70() > Pid: 29795, comm: trinity-child4 Not tainted 3.7.0-rc2+ #49 > Call Trace: > []

shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-24 Thread Dave Jones
Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at mm/shmem.c:1151 shmem_getpage_gfp+0xa5c/0xa70() Pid: 29795, comm: trinity-child4 Not tainted 3.7.0-rc2+ #49 Call Trace: [] warn_slowpath_common+0x7f/0xc0 [] warn_slowpath_null+0x1a/0x20 []

shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-24 Thread Dave Jones
Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at mm/shmem.c:1151 shmem_getpage_gfp+0xa5c/0xa70() Pid: 29795, comm: trinity-child4 Not tainted 3.7.0-rc2+ #49 Call Trace: [8107100f] warn_slowpath_common+0x7f/0xc0 [8107106a]

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-24 Thread Hugh Dickins
On Wed, 24 Oct 2012, Dave Jones wrote: Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at mm/shmem.c:1151 shmem_getpage_gfp+0xa5c/0xa70() Pid: 29795, comm: trinity-child4 Not tainted 3.7.0-rc2+ #49 Call Trace: [8107100f]

Re: shmem_getpage_gfp VM_BUG_ON triggered. [3.7rc2]

2012-10-24 Thread Ni zhan Chen
On 10/25/2012 12:36 PM, Hugh Dickins wrote: On Wed, 24 Oct 2012, Dave Jones wrote: Machine under significant load (4gb memory used, swap usage fluctuating) triggered this... WARNING: at mm/shmem.c:1151 shmem_getpage_gfp+0xa5c/0xa70() Pid: 29795, comm: trinity-child4 Not tainted 3.7.0-rc2+ #49