Re: usb: dwc3: gadget: skip pullup and set_speed after suspend

2021-01-31 Thread Jung Daehwan
On Sun, Jan 24, 2021 at 05:31:57PM +0200, Felipe Balbi wrote: > > Hi, > > Daehwan Jung writes: > > Sometimes dwc3_gadget_pullup and dwc3_gadget_set_speed are called after > > entering suspend. That's why it needs to check whether suspend > > > > 1. dwc3 sends disconnect uevent and turn off.

Re: usb: dwc3: gadget: skip pullup and set_speed after suspend

2021-01-26 Thread Wesley Cheng
On 1/21/2021 11:15 PM, Jung Daehwan wrote: > On Fri, Jan 22, 2021 03:32, Wesley cheng wrote: >> Hi Daehwan, >> >> If this is an unexpected event where userspace initiates the UDC bind >> sequence, then after the above sequence occurs, the DWC3 device should >> still be able to re-enter runtime

Re: usb: dwc3: gadget: skip pullup and set_speed after suspend

2021-01-24 Thread Felipe Balbi
Hi, Daehwan Jung writes: > Sometimes dwc3_gadget_pullup and dwc3_gadget_set_speed are called after > entering suspend. That's why it needs to check whether suspend > > 1. dwc3 sends disconnect uevent and turn off. (suspend) > 2. Platform side causes pullup or set_speed(e.g., adbd closes ffs

Re: usb: dwc3: gadget: skip pullup and set_speed after suspend

2021-01-21 Thread Jung Daehwan
On Fri, Jan 22, 2021 03:32, Wesley cheng wrote: > Hi Daehwan, > > If this is an unexpected event where userspace initiates the UDC bind > sequence, then after the above sequence occurs, the DWC3 device should > still be able to re-enter runtime suspend after the autosuspend timer > expires.

Re: usb: dwc3: gadget: skip pullup and set_speed after suspend

2021-01-21 Thread Wesley Cheng
On 1/21/2021 12:13 AM, Jung Daehwan wrote: > On Wed, Jan 20, 2021 at 11:44:05PM -0800, Wesley Cheng wrote: >> >> >> On 1/20/2021 10:49 PM, Jung Daehwan wrote: >>> Hi, >>> >>> On Thu, Jan 21, 2021 at 01:00:32AM +, Thinh Nguyen wrote: Hi, Daehwan Jung wrote: > Sometimes

Re: usb: dwc3: gadget: skip pullup and set_speed after suspend

2021-01-21 Thread Jung Daehwan
On Wed, Jan 20, 2021 at 11:44:05PM -0800, Wesley Cheng wrote: > > > On 1/20/2021 10:49 PM, Jung Daehwan wrote: > > Hi, > > > > On Thu, Jan 21, 2021 at 01:00:32AM +, Thinh Nguyen wrote: > >> Hi, > >> > >> Daehwan Jung wrote: > >>> Sometimes dwc3_gadget_pullup and dwc3_gadget_set_speed are

Re: usb: dwc3: gadget: skip pullup and set_speed after suspend

2021-01-20 Thread Wesley Cheng
On 1/20/2021 10:49 PM, Jung Daehwan wrote: > Hi, > > On Thu, Jan 21, 2021 at 01:00:32AM +, Thinh Nguyen wrote: >> Hi, >> >> Daehwan Jung wrote: >>> Sometimes dwc3_gadget_pullup and dwc3_gadget_set_speed are called after >>> entering suspend. That's why it needs to check whether suspend >>>

Re: usb: dwc3: gadget: skip pullup and set_speed after suspend

2021-01-20 Thread Jung Daehwan
Hi, On Thu, Jan 21, 2021 at 01:00:32AM +, Thinh Nguyen wrote: > Hi, > > Daehwan Jung wrote: > > Sometimes dwc3_gadget_pullup and dwc3_gadget_set_speed are called after > > entering suspend. That's why it needs to check whether suspend > > > > 1. dwc3 sends disconnect uevent and turn off.

Re: usb: dwc3: gadget: skip pullup and set_speed after suspend

2021-01-20 Thread Jung Daehwan
Hi, On Thu, Jan 21, 2021 at 01:00:32AM +, Thinh Nguyen wrote: > Hi, > > Daehwan Jung wrote: > > Sometimes dwc3_gadget_pullup and dwc3_gadget_set_speed are called after > > entering suspend. That's why it needs to check whether suspend > > > > 1. dwc3 sends disconnect uevent and turn off.

Re: usb: dwc3: gadget: skip pullup and set_speed after suspend

2021-01-20 Thread Thinh Nguyen
Hi, Daehwan Jung wrote: > Sometimes dwc3_gadget_pullup and dwc3_gadget_set_speed are called after > entering suspend. That's why it needs to check whether suspend > > 1. dwc3 sends disconnect uevent and turn off. (suspend) > 2. Platform side causes pullup or set_speed(e.g., adbd closes ffs node)

usb: dwc3: gadget: skip pullup and set_speed after suspend

2021-01-19 Thread Daehwan Jung
Sometimes dwc3_gadget_pullup and dwc3_gadget_set_speed are called after entering suspend. That's why it needs to check whether suspend 1. dwc3 sends disconnect uevent and turn off. (suspend) 2. Platform side causes pullup or set_speed(e.g., adbd closes ffs node) 3. It causes unexpected behavior