Re: [PATCH v4 4/8] PCI: brcmstb: Add dma-range mapping for inbound traffic

2018-01-17 Thread Rob Herring
On Mon, Jan 15, 2018 at 5:28 PM, Jim Quinlan wrote: > The Broadcom STB PCIe host controller is intimately related to the > memory subsystem. This close relationship adds complexity to how cpu > system memory is mapped to PCIe memory. Ideally, this mapping is an > identity

Re: [PATCH v4 4/8] PCI: brcmstb: Add dma-range mapping for inbound traffic

2018-01-17 Thread Rob Herring
On Mon, Jan 15, 2018 at 5:28 PM, Jim Quinlan wrote: > The Broadcom STB PCIe host controller is intimately related to the > memory subsystem. This close relationship adds complexity to how cpu > system memory is mapped to PCIe memory. Ideally, this mapping is an > identity mapping, or an

Re: kexec reboot fails with extra wbinvd introduced for AME SME

2018-01-17 Thread Linus Torvalds
On Wed, Jan 17, 2018 at 5:47 PM, Dave Young wrote: > > It does not work with just once wbinvd(), and it only works with > removing the wbinvd() for me. Tom's new post works for me as well > since my cpu is an Intel i5-4200U. Intriguing. It's not like the wbinvd really should

Re: kexec reboot fails with extra wbinvd introduced for AME SME

2018-01-17 Thread Linus Torvalds
On Wed, Jan 17, 2018 at 5:47 PM, Dave Young wrote: > > It does not work with just once wbinvd(), and it only works with > removing the wbinvd() for me. Tom's new post works for me as well > since my cpu is an Intel i5-4200U. Intriguing. It's not like the wbinvd really should be that much of a

Re: [PATCH] rcu: Use wrapper for lockdep asserts

2018-01-17 Thread Paul E. McKenney
On Wed, Jan 17, 2018 at 04:41:43PM -0800, Matthew Wilcox wrote: > On Wed, Jan 17, 2018 at 03:29:13PM -0800, Paul E. McKenney wrote: > > On Wed, Jan 17, 2018 at 06:24:30AM -0800, Matthew Wilcox wrote: > > > > > > From: Matthew Wilcox > > > > > > Commits c0b334c5bfa9 and

Re: [PATCH] rcu: Use wrapper for lockdep asserts

2018-01-17 Thread Paul E. McKenney
On Wed, Jan 17, 2018 at 04:41:43PM -0800, Matthew Wilcox wrote: > On Wed, Jan 17, 2018 at 03:29:13PM -0800, Paul E. McKenney wrote: > > On Wed, Jan 17, 2018 at 06:24:30AM -0800, Matthew Wilcox wrote: > > > > > > From: Matthew Wilcox > > > > > > Commits c0b334c5bfa9 and ea9b0c8a26a2 introduced

Re: [PATCH v2 1/2] nvmem: add driver for JZ4780 efuse

2018-01-17 Thread Rob Herring
On Wed, Jan 17, 2018 at 11:31 AM, PrasannaKumar Muralidharan wrote: > Hi Rob, > > On 11 January 2018 at 20:38, Rob Herring wrote: >> On Sat, Jan 6, 2018 at 6:43 AM, PrasannaKumar Muralidharan >> wrote: >>> Hi Rob, >>> >>>

Re: [PATCH v2 1/2] nvmem: add driver for JZ4780 efuse

2018-01-17 Thread Rob Herring
On Wed, Jan 17, 2018 at 11:31 AM, PrasannaKumar Muralidharan wrote: > Hi Rob, > > On 11 January 2018 at 20:38, Rob Herring wrote: >> On Sat, Jan 6, 2018 at 6:43 AM, PrasannaKumar Muralidharan >> wrote: >>> Hi Rob, >>> >>> On 4 January 2018 at 01:32, Rob Herring wrote: On Thu, Dec 28, 2017

Re: [PATCH v3 11/16] mmc: tmio: deprecate "toshiba,mmc-wrprotect-disable" DT property

2018-01-17 Thread Masahiro Yamada
2018-01-18 1:28 GMT+09:00 Masahiro Yamada : > This property is equivalent to "disable-wp" defined in > Documentation/devicetree/bindings/mmc/tmio_mmc.txt This is mistake. "disable-wp" is defined in Documentation/devicetree/bindings/mmc/mmc.txt > The TMIO MMC

Re: [PATCH v3 11/16] mmc: tmio: deprecate "toshiba,mmc-wrprotect-disable" DT property

2018-01-17 Thread Masahiro Yamada
2018-01-18 1:28 GMT+09:00 Masahiro Yamada : > This property is equivalent to "disable-wp" defined in > Documentation/devicetree/bindings/mmc/tmio_mmc.txt This is mistake. "disable-wp" is defined in Documentation/devicetree/bindings/mmc/mmc.txt > The TMIO MMC core calls mmc_of_parse(), and

Re: [PATCH] perf/core: Fix installing cgroup event into cpu

2018-01-17 Thread Lin Xiulei
Hi Peter Could you please have a look of this thanks 2018-01-11 11:09 GMT+08:00 : > From: "leilei.lin" > > Do not install cgroup event into the CPU context if the cgroup > is not running on this CPU > > While there is no task of cgroup running

Re: [PATCH] perf/core: Fix installing cgroup event into cpu

2018-01-17 Thread Lin Xiulei
Hi Peter Could you please have a look of this thanks 2018-01-11 11:09 GMT+08:00 : > From: "leilei.lin" > > Do not install cgroup event into the CPU context if the cgroup > is not running on this CPU > > While there is no task of cgroup running specified CPU, current > kernel still install

Re: [PATCH v5 1/2] printk: Add console owner and waiter logic to load balance console writes

2018-01-17 Thread Byungchul Park
On 1/18/2018 10:53 AM, Byungchul Park wrote: Hello, This is a thing simulating a wait for an event e.g. wait_for_completion() doing spinning instead of sleep, rather than a spinlock. I mean:    This context       while (READ_ONCE(console_waiter)) /* Wait for the event */  

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-17 Thread Dave Young
On 01/17/18 at 02:42pm, Petr Mladek wrote: > On Wed 2018-01-17 20:32:44, Dave Young wrote: > > Hi, > > > > Thanks for your comments. > > On 01/17/18 at 09:57am, Petr Mladek wrote: > > > On Wed 2018-01-17 12:50:57, Dave Young wrote: > > > > It is useful to print kdump kernel loaded status in

Re: [PATCH v5 1/2] printk: Add console owner and waiter logic to load balance console writes

2018-01-17 Thread Byungchul Park
On 1/18/2018 10:53 AM, Byungchul Park wrote: Hello, This is a thing simulating a wait for an event e.g. wait_for_completion() doing spinning instead of sleep, rather than a spinlock. I mean:    This context       while (READ_ONCE(console_waiter)) /* Wait for the event */  

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-17 Thread Dave Young
On 01/17/18 at 02:42pm, Petr Mladek wrote: > On Wed 2018-01-17 20:32:44, Dave Young wrote: > > Hi, > > > > Thanks for your comments. > > On 01/17/18 at 09:57am, Petr Mladek wrote: > > > On Wed 2018-01-17 12:50:57, Dave Young wrote: > > > > It is useful to print kdump kernel loaded status in

Re: [PATCH v3 2/2] nvme: add tracepoint for nvme_complete_rq

2018-01-17 Thread Martin K. Petersen
Johannes, Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 1/2] nvme: add tracepoint for nvme_setup_cmd

2018-01-17 Thread Martin K. Petersen
Johannes, Very nice! Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 2/2] nvme: add tracepoint for nvme_complete_rq

2018-01-17 Thread Martin K. Petersen
Johannes, Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 1/2] nvme: add tracepoint for nvme_setup_cmd

2018-01-17 Thread Martin K. Petersen
Johannes, Very nice! Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Yang, Shunyong
Hi, Marc On Wed, 2018-01-17 at 10:43 +, Marc Zyngier wrote: > On 17/01/18 10:20, Yang, Shunyong wrote: > > > > Hi, Thomas and Marc, > > > > On Wed, 2018-01-17 at 11:01 +0100, Thomas Gleixner wrote: > > > > > > On Wed, 17 Jan 2018, Yang, Shunyong wrote: > > > > > > > > > > > > On Wed,

Re: [PATCH v5 1/2] printk: Add console owner and waiter logic to load balance console writes

2018-01-17 Thread Byungchul Park
On 1/17/2018 9:04 PM, Petr Mladek wrote: On Wed 2018-01-17 11:19:53, Byungchul Park wrote: On 1/10/2018 10:24 PM, Petr Mladek wrote: From: Steven Rostedt [...] diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index b9006617710f..7e6459abba43 100644 ---

Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Yang, Shunyong
Hi, Marc On Wed, 2018-01-17 at 10:43 +, Marc Zyngier wrote: > On 17/01/18 10:20, Yang, Shunyong wrote: > > > > Hi, Thomas and Marc, > > > > On Wed, 2018-01-17 at 11:01 +0100, Thomas Gleixner wrote: > > > > > > On Wed, 17 Jan 2018, Yang, Shunyong wrote: > > > > > > > > > > > > On Wed,

Re: [PATCH v5 1/2] printk: Add console owner and waiter logic to load balance console writes

2018-01-17 Thread Byungchul Park
On 1/17/2018 9:04 PM, Petr Mladek wrote: On Wed 2018-01-17 11:19:53, Byungchul Park wrote: On 1/10/2018 10:24 PM, Petr Mladek wrote: From: Steven Rostedt [...] diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index b9006617710f..7e6459abba43 100644 --- a/kernel/printk/printk.c

Re: kexec reboot fails with extra wbinvd introduced for AME SME

2018-01-17 Thread Dave Young
On 01/17/18 at 09:06am, Tom Lendacky wrote: > On 1/17/2018 1:22 AM, Dave Young wrote: > > [Modify the subject since this is a new problem, original io vector > > issue has been fixed with one commit from Thomas] > > > > Add more cc according to below old discussion: > >

Re: kexec reboot fails with extra wbinvd introduced for AME SME

2018-01-17 Thread Dave Young
On 01/17/18 at 09:06am, Tom Lendacky wrote: > On 1/17/2018 1:22 AM, Dave Young wrote: > > [Modify the subject since this is a new problem, original io vector > > issue has been fixed with one commit from Thomas] > > > > Add more cc according to below old discussion: > >

Re: kexec reboot fails with extra wbinvd introduced for AME SME

2018-01-17 Thread Dave Young
On 01/17/18 at 11:42am, Linus Torvalds wrote: > On Tue, Jan 16, 2018 at 11:22 PM, Dave Young wrote: > > > > For the kexec reboot hang, if I remove the wbinvd in stop_this_cpu() > > then kexec works fine. like this: > > Honestly, I think we should apply that patch regardless. >

Re: kexec reboot fails with extra wbinvd introduced for AME SME

2018-01-17 Thread Dave Young
On 01/17/18 at 11:42am, Linus Torvalds wrote: > On Tue, Jan 16, 2018 at 11:22 PM, Dave Young wrote: > > > > For the kexec reboot hang, if I remove the wbinvd in stop_this_cpu() > > then kexec works fine. like this: > > Honestly, I think we should apply that patch regardless. > > Using 'wbinvd'

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-17 Thread Eric Biggers
On Wed, Jan 17, 2018 at 05:18:17PM -0800, Joe Perches wrote: > On Wed, 2018-01-17 at 20:09 -0500, Theodore Ts'o wrote: > > get_maintainer.pl, which is often not accurate > > Examples please. > Well, the primary problem is that place the crash occurs is not necessarily responsible for the bug.

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-17 Thread Eric Biggers
On Wed, Jan 17, 2018 at 05:18:17PM -0800, Joe Perches wrote: > On Wed, 2018-01-17 at 20:09 -0500, Theodore Ts'o wrote: > > get_maintainer.pl, which is often not accurate > > Examples please. > Well, the primary problem is that place the crash occurs is not necessarily responsible for the bug.

[PATCH net-next] net: hns: Fix for variable may be used uninitialized warnings

2018-01-17 Thread Huazhong Tan
When !CONFIG_REGMAP hns throws compiler warnings since dsaf_read_syscon ignores the return result from regmap_read, which allows val to be uninitialized. Fixes: 86897c960b49 ("net: hns: add syscon operation for dsaf") Reported-by: Jason Gunthorpe Signed-off-by: Huazhong Tan

[PATCH net-next] net: hns: Fix for variable may be used uninitialized warnings

2018-01-17 Thread Huazhong Tan
When !CONFIG_REGMAP hns throws compiler warnings since dsaf_read_syscon ignores the return result from regmap_read, which allows val to be uninitialized. Fixes: 86897c960b49 ("net: hns: add syscon operation for dsaf") Reported-by: Jason Gunthorpe Signed-off-by: Huazhong Tan Signed-off-by:

[PATCH v2] Remove silentoldconfig from "make help"; fix kconfig/conf's help

2018-01-17 Thread Marc Herbert
As explained by Michal Marek at https://lkml.org/lkml/2011/8/31/189 silentoldconfig has become a misnomer. It has become an internal interface so remove it from "make help" to stop confusing people trying to use it as seen for instance at https://chromium-review.googlesource.com/835632 On the

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-17 Thread Yang Shi
On 1/17/18 4:21 AM, Thomas Gleixner wrote: On Thu, 4 Jan 2018, Yang Shi wrote: There are nested loops on debug objects free path, sometimes it may take over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT occasionally, like below: Please trim back traces. The whole

[PATCH v2] Remove silentoldconfig from "make help"; fix kconfig/conf's help

2018-01-17 Thread Marc Herbert
As explained by Michal Marek at https://lkml.org/lkml/2011/8/31/189 silentoldconfig has become a misnomer. It has become an internal interface so remove it from "make help" to stop confusing people trying to use it as seen for instance at https://chromium-review.googlesource.com/835632 On the

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-17 Thread Yang Shi
On 1/17/18 4:21 AM, Thomas Gleixner wrote: On Thu, 4 Jan 2018, Yang Shi wrote: There are nested loops on debug objects free path, sometimes it may take over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT occasionally, like below: Please trim back traces. The whole

[PATCH -next v2] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-17 Thread Wei Yongjun
Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Fixes: dce143c3381c ("ipmi/powernv: Convert to irq event interface") Signed-off-by: Wei Yongjun --- v1 -> v2: add fixes. ---

[PATCH -next v2] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-17 Thread Wei Yongjun
Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Fixes: dce143c3381c ("ipmi/powernv: Convert to irq event interface") Signed-off-by: Wei Yongjun --- v1 -> v2: add fixes. --- drivers/char/ipmi/ipmi_powernv.c | 5

Re: [PATCH] net/mlx5e: Fix trailing semicolon

2018-01-17 Thread Saeed Mahameed
On 01/17/2018 04:09 AM, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt Looks Good, Thanks Luis. Reviewed-by: Saeed Mahameed

Re: [PATCH] net/mlx5e: Fix trailing semicolon

2018-01-17 Thread Saeed Mahameed
On 01/17/2018 04:09 AM, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt Looks Good, Thanks Luis. Reviewed-by: Saeed Mahameed

Re: [PATCH] MIPS: use generic GCC library routines from lib/

2018-01-17 Thread Palmer Dabbelt
Ah, thanks for reminding me -- I'd originally posted a patch set that converted every other port to use these routines, but I ended up dropping all those. Here's my original MIPS attempt https://marc.info/?l=linux-mips=149677651707103=2 Given that, I think you can also drop

Re: [PATCH] MIPS: use generic GCC library routines from lib/

2018-01-17 Thread Palmer Dabbelt
Ah, thanks for reminding me -- I'd originally posted a patch set that converted every other port to use these routines, but I ended up dropping all those. Here's my original MIPS attempt https://marc.info/?l=linux-mips=149677651707103=2 Given that, I think you can also drop

Re: [PATCH] PCI / PM: Fix trailing semicolon

2018-01-17 Thread Rafael J. Wysocki
On Wednesday, January 17, 2018 7:21:49 PM CET Bjorn Helgaas wrote: > [+cc Rafael] > > On Wed, Jan 17, 2018 at 10:33:21AM +, Luis de Bethencourt wrote: > > The trailing semicolon is an empty statement that does no operation. > > Removing it since it doesn't do anything. > > > > Signed-off-by:

Re: [PATCH] PCI / PM: Fix trailing semicolon

2018-01-17 Thread Rafael J. Wysocki
On Wednesday, January 17, 2018 7:21:49 PM CET Bjorn Helgaas wrote: > [+cc Rafael] > > On Wed, Jan 17, 2018 at 10:33:21AM +, Luis de Bethencourt wrote: > > The trailing semicolon is an empty statement that does no operation. > > Removing it since it doesn't do anything. > > > > Signed-off-by:

Re: [PATCH] x86/mm: Rework wbinvd, hlt operation in stop_this_cpu()

2018-01-17 Thread Dave Young
On 01/17/18 at 05:47pm, Tom Lendacky wrote: > On 1/17/2018 5:41 PM, Tom Lendacky wrote: > > Some issues have been reported with the for loop in stop_this_cpu() that > > issues the 'wbinvd; hlt' sequence. Reverting this sequence to halt() > > has been shown to resolve the issue. > > > > However,

Re: [PATCH] x86/mm: Rework wbinvd, hlt operation in stop_this_cpu()

2018-01-17 Thread Dave Young
On 01/17/18 at 05:47pm, Tom Lendacky wrote: > On 1/17/2018 5:41 PM, Tom Lendacky wrote: > > Some issues have been reported with the for loop in stop_this_cpu() that > > issues the 'wbinvd; hlt' sequence. Reverting this sequence to halt() > > has been shown to resolve the issue. > > > > However,

RE: [PATCH] [RESEND] scsi: fnic: use 64-bit timestamps

2018-01-17 Thread Satish Kharat (satishkh)
Looks good to me. Acked-by: Satish Kharat -Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: Wednesday, January 17, 2018 7:17 AM To: Satish Kharat (satishkh) ; Sesidhar Baddela (sebaddel) ; Karan Tilak Kumar

RE: [PATCH] [RESEND] scsi: fnic: use 64-bit timestamps

2018-01-17 Thread Satish Kharat (satishkh)
Looks good to me. Acked-by: Satish Kharat -Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: Wednesday, January 17, 2018 7:17 AM To: Satish Kharat (satishkh) ; Sesidhar Baddela (sebaddel) ; Karan Tilak Kumar (kartilak) ; James E.J. Bottomley ; Martin K. Petersen

Re: [PATCH v7 3/5] x86/KASLR: Give a warning if movable_node specified without kaslr_mem=

2018-01-17 Thread Chao Fan
On Wed, Jan 17, 2018 at 10:02:48PM +0800, Baoquan He wrote: >On 01/17/18 at 06:53pm, Chao Fan wrote: >> Since only 'movable_node' specified without 'kaslr_mem=' may break >> memory hotplug, so reconmmend users using 'kaslr_mem=' when >> 'movable_node' specified.. >> >> Signed-off-by: Chao Fan

Re: [PATCH v7 3/5] x86/KASLR: Give a warning if movable_node specified without kaslr_mem=

2018-01-17 Thread Chao Fan
On Wed, Jan 17, 2018 at 10:02:48PM +0800, Baoquan He wrote: >On 01/17/18 at 06:53pm, Chao Fan wrote: >> Since only 'movable_node' specified without 'kaslr_mem=' may break >> memory hotplug, so reconmmend users using 'kaslr_mem=' when >> 'movable_node' specified.. >> >> Signed-off-by: Chao Fan >>

linux-next: build warning after merge of the net-next tree

2018-01-17 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (powerpc ppc64_defconfig) produced this warning: net/sched/cls_api.c: In function 'tc_dump_tfilter': net/sched/cls_api.c:1362:8: warning: 'parent' may be used uninitialized in this function [-Wmaybe-uninitialized] if

linux-next: build warning after merge of the net-next tree

2018-01-17 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (powerpc ppc64_defconfig) produced this warning: net/sched/cls_api.c: In function 'tc_dump_tfilter': net/sched/cls_api.c:1362:8: warning: 'parent' may be used uninitialized in this function [-Wmaybe-uninitialized] if

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-17 Thread Joe Perches
On Wed, 2018-01-17 at 20:09 -0500, Theodore Ts'o wrote: > get_maintainer.pl, which is often not accurate Examples please.

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-17 Thread Joe Perches
On Wed, 2018-01-17 at 20:09 -0500, Theodore Ts'o wrote: > get_maintainer.pl, which is often not accurate Examples please.

Re: [PATCH v7 4/5] x86/KASLR: Skip memory mirror handling if movable_node specified

2018-01-17 Thread Chao Fan
On Wed, Jan 17, 2018 at 10:03:54PM +0800, Baoquan He wrote: >On 01/17/18 at 06:53pm, Chao Fan wrote: >> In kernel code, if movable_node specified, it will skip the mirror >> feature. So we should also skip mirror feature in KASLR. >> >> Signed-off-by: Chao Fan >> --- >>

Re: [ANNOUNCE] autofs 5.1.2 release

2018-01-17 Thread Ian Kent
On 03/01/18 06:14, NeilBrown wrote: > On Thu, Dec 21 2017, Ian Kent wrote: > >> On 21/12/17 19:06, Ian Kent wrote: >>> On 21/12/17 09:09, NeilBrown wrote: On Wed, Dec 20 2017, Ian Kent wrote: > On 20/12/17 13:52, Ian Kent wrote: >> On 20/12/17 11:29, NeilBrown wrote: >>>

Re: [PATCH v7 4/5] x86/KASLR: Skip memory mirror handling if movable_node specified

2018-01-17 Thread Chao Fan
On Wed, Jan 17, 2018 at 10:03:54PM +0800, Baoquan He wrote: >On 01/17/18 at 06:53pm, Chao Fan wrote: >> In kernel code, if movable_node specified, it will skip the mirror >> feature. So we should also skip mirror feature in KASLR. >> >> Signed-off-by: Chao Fan >> --- >>

Re: [ANNOUNCE] autofs 5.1.2 release

2018-01-17 Thread Ian Kent
On 03/01/18 06:14, NeilBrown wrote: > On Thu, Dec 21 2017, Ian Kent wrote: > >> On 21/12/17 19:06, Ian Kent wrote: >>> On 21/12/17 09:09, NeilBrown wrote: On Wed, Dec 20 2017, Ian Kent wrote: > On 20/12/17 13:52, Ian Kent wrote: >> On 20/12/17 11:29, NeilBrown wrote: >>>

Re: [PATCH v7 0/5] x86/KASLR: Add parameter kaslr_mem=nn[KMG]@ss[KMG]

2018-01-17 Thread Chao Fan
On Wed, Jan 17, 2018 at 12:32:35PM -0500, Luiz Capitulino wrote: >On Wed, 17 Jan 2018 18:53:46 +0800 >Chao Fan wrote: > >> ***Background: >> People reported that kaslr may randomly chooses some positions >> which are located in movable memory regions. This will break

Re: [PATCH v7 0/5] x86/KASLR: Add parameter kaslr_mem=nn[KMG]@ss[KMG]

2018-01-17 Thread Chao Fan
On Wed, Jan 17, 2018 at 12:32:35PM -0500, Luiz Capitulino wrote: >On Wed, 17 Jan 2018 18:53:46 +0800 >Chao Fan wrote: > >> ***Background: >> People reported that kaslr may randomly chooses some positions >> which are located in movable memory regions. This will break memory >> hotplug feature.

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-17 Thread Theodore Ts'o
On Wed, Jan 17, 2018 at 04:21:13PM -0800, Alexei Starovoitov wrote: > > If syzkaller can only test one tree than linux-next should be the one. Well, there's been some controversy about that. The problem is that it's often not clear if this is long-standing bug, or a bug which is in a particular

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-17 Thread Theodore Ts'o
On Wed, Jan 17, 2018 at 04:21:13PM -0800, Alexei Starovoitov wrote: > > If syzkaller can only test one tree than linux-next should be the one. Well, there's been some controversy about that. The problem is that it's often not clear if this is long-standing bug, or a bug which is in a particular

linux-next: manual merge of the net-next tree with the net tree

2018-01-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/tun.c between commit: 4df0bfc79904 ("tun: fix a memory leak for tfile->tx_array") from the net tree and commits: 8bf5c4ee1889 ("tun: setup xdp_rxq_info") 5990a30510ed ("tun/tap: use ptr_ring instead

linux-next: manual merge of the net-next tree with the net tree

2018-01-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/tun.c between commit: 4df0bfc79904 ("tun: fix a memory leak for tfile->tx_array") from the net tree and commits: 8bf5c4ee1889 ("tun: setup xdp_rxq_info") 5990a30510ed ("tun/tap: use ptr_ring instead

[PATCH] x86/pti: Document fix wrong index

2018-01-17 Thread zhenwei.pi
In section <2. Runtime Cost>, fix wrong index. Signed-off-by: zhenwei.pi --- Documentation/x86/pti.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/x86/pti.txt b/Documentation/x86/pti.txt index d11eff6..5cd5843 100644 ---

[PATCH] x86/pti: Document fix wrong index

2018-01-17 Thread zhenwei.pi
In section <2. Runtime Cost>, fix wrong index. Signed-off-by: zhenwei.pi --- Documentation/x86/pti.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/x86/pti.txt b/Documentation/x86/pti.txt index d11eff6..5cd5843 100644 --- a/Documentation/x86/pti.txt +++

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

2018-01-17 Thread Madhani, Himanshu
Max, > On Jan 15, 2018, at 12:37 PM, Max Kellermann wrote: > > On 2018/01/15 20:58, "Madhani, Himanshu" wrote: >> We have patch to prevent this double free in 4.16/scsi-queue >> already. > > No, let me repeat: this is a different bug! > > Your

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

2018-01-17 Thread Madhani, Himanshu
Max, > On Jan 15, 2018, at 12:37 PM, Max Kellermann wrote: > > On 2018/01/15 20:58, "Madhani, Himanshu" wrote: >> We have patch to prevent this double free in 4.16/scsi-queue >> already. > > No, let me repeat: this is a different bug! > > Your bug is about the free call after waiting for

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-17 Thread Wang, Haiyue
On 2018-01-18 00:31, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: Snip... + +struct kcs_bmc { +    struct regmap *map; +    spinlock_t lock; This lock is only used in threads, as far as I can tell. Couldn't it just be a normal mutex? But more on this later.

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-17 Thread Wang, Haiyue
On 2018-01-18 00:31, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: Snip... + +struct kcs_bmc { +    struct regmap *map; +    spinlock_t lock; This lock is only used in threads, as far as I can tell. Couldn't it just be a normal mutex? But more on this later.

Re: [PATCH] rcu: Use wrapper for lockdep asserts

2018-01-17 Thread Matthew Wilcox
On Wed, Jan 17, 2018 at 03:29:13PM -0800, Paul E. McKenney wrote: > On Wed, Jan 17, 2018 at 06:24:30AM -0800, Matthew Wilcox wrote: > > > > From: Matthew Wilcox > > > > Commits c0b334c5bfa9 and ea9b0c8a26a2 introduced new sparse warnings > > by accessing rcu_node->lock

Re: [PATCH] rcu: Use wrapper for lockdep asserts

2018-01-17 Thread Matthew Wilcox
On Wed, Jan 17, 2018 at 03:29:13PM -0800, Paul E. McKenney wrote: > On Wed, Jan 17, 2018 at 06:24:30AM -0800, Matthew Wilcox wrote: > > > > From: Matthew Wilcox > > > > Commits c0b334c5bfa9 and ea9b0c8a26a2 introduced new sparse warnings > > by accessing rcu_node->lock directly and ignoring the

Re: [PATCH v2 1/2] fscrypt: add support for the encrypted key type

2018-01-17 Thread Eric Biggers
Hi André, On Wed, Jan 17, 2018 at 02:13:18PM +, André Draszik wrote: > We now try to acquire the key according to the > encryption policy from both key types, 'logon' > as well as 'encrypted'. > > Signed-off-by: André Draszik > Cc: "Theodore Y. Ts'o" > Cc:

Re: [PATCH v2 1/2] fscrypt: add support for the encrypted key type

2018-01-17 Thread Eric Biggers
Hi André, On Wed, Jan 17, 2018 at 02:13:18PM +, André Draszik wrote: > We now try to acquire the key according to the > encryption policy from both key types, 'logon' > as well as 'encrypted'. > > Signed-off-by: André Draszik > Cc: "Theodore Y. Ts'o" > Cc: Jaegeuk Kim > Cc:

Re: [GIT PULL] x86 fixes

2018-01-17 Thread Andrew Morton
On Thu, 18 Jan 2018 01:24:08 +0100 Ingo Molnar wrote: > > * Linus Torvalds wrote: > > > On Wed, Jan 17, 2018 at 7:41 AM, Ingo Molnar wrote: > > > > > > - A kdump fix > > > > > > out-of-topic modifications in

Re: [GIT PULL] x86 fixes

2018-01-17 Thread Andrew Morton
On Thu, 18 Jan 2018 01:24:08 +0100 Ingo Molnar wrote: > > * Linus Torvalds wrote: > > > On Wed, Jan 17, 2018 at 7:41 AM, Ingo Molnar wrote: > > > > > > - A kdump fix > > > > > > out-of-topic modifications in x86-urgent-for-linus: > > >

Re: [PATCH net-next] net: core: Expose number of link up/down transitions

2018-01-17 Thread David Ahern
On 1/17/18 3:06 PM, Florian Fainelli wrote: > diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c > index 7bf8b85ade16..9f732c3dc2ce 100644 > --- a/net/core/net-sysfs.c > +++ b/net/core/net-sysfs.c > @@ -295,10 +295,29 @@ static ssize_t carrier_changes_show(struct device *dev, > struct

Re: [PATCH net-next] net: core: Expose number of link up/down transitions

2018-01-17 Thread David Ahern
On 1/17/18 3:06 PM, Florian Fainelli wrote: > diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c > index 7bf8b85ade16..9f732c3dc2ce 100644 > --- a/net/core/net-sysfs.c > +++ b/net/core/net-sysfs.c > @@ -295,10 +295,29 @@ static ssize_t carrier_changes_show(struct device *dev, > struct

Re: [GIT PULL] x86 fixes

2018-01-17 Thread Ingo Molnar
* Linus Torvalds wrote: > On Wed, Jan 17, 2018 at 7:41 AM, Ingo Molnar wrote: > > > > - A kdump fix > > > > out-of-topic modifications in x86-urgent-for-linus: > > - > >

Re: [GIT PULL] x86 fixes

2018-01-17 Thread Ingo Molnar
* Linus Torvalds wrote: > On Wed, Jan 17, 2018 at 7:41 AM, Ingo Molnar wrote: > > > > - A kdump fix > > > > out-of-topic modifications in x86-urgent-for-linus: > > - > > include/linux/crash_core.h # 9f15b9120f56: kdump: Write

Re: [PATCH net-next] net: core: Expose number of link up/down transitions

2018-01-17 Thread Andrei Vagin
On Thu, Jan 18, 2018 at 01:06:52AM +0100, Andrew Lunn wrote: > > What is the idea to have two separate counters? Can a delta between them > > be a bigger than 1? > > Yes, it can. > > These counters are incremented in netif_carrier_on() / > netif_carrier_off(). They are not always called in pairs

Re: [PATCH net-next] net: core: Expose number of link up/down transitions

2018-01-17 Thread Andrei Vagin
On Thu, Jan 18, 2018 at 01:06:52AM +0100, Andrew Lunn wrote: > > What is the idea to have two separate counters? Can a delta between them > > be a bigger than 1? > > Yes, it can. > > These counters are incremented in netif_carrier_on() / > netif_carrier_off(). They are not always called in pairs

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-17 Thread Alexei Starovoitov
On Wed, Jan 17, 2018 at 03:47:35PM -0500, Theodore Ts'o wrote: > On Wed, Jan 17, 2018 at 12:09:18PM +0100, Dmitry Vyukov wrote: > > On Wed, Jan 17, 2018 at 10:49 AM, Daniel Borkmann > > wrote: > > > Don't know if there's such a possibility, but it would be nice if we could

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

2018-01-17 Thread Alexei Starovoitov
On Wed, Jan 17, 2018 at 03:47:35PM -0500, Theodore Ts'o wrote: > On Wed, Jan 17, 2018 at 12:09:18PM +0100, Dmitry Vyukov wrote: > > On Wed, Jan 17, 2018 at 10:49 AM, Daniel Borkmann > > wrote: > > > Don't know if there's such a possibility, but it would be nice if we could > > > target fuzzing

Re: [PATCH 1/3] encrypted-keys: add fscrypt format support

2018-01-17 Thread Eric Biggers
Hi André, On Wed, Jan 17, 2018 at 02:29:29PM +, André Draszik wrote: > Thanks Eric for the review! > > On Wed, 2018-01-10 at 20:00 -0800, Eric Biggers wrote: > > Hi André, > > > > On Wed, Jan 10, 2018 at 12:44:16PM +, André Draszik wrote: > > > This is heavily based on commit

Re: [PATCH 1/3] encrypted-keys: add fscrypt format support

2018-01-17 Thread Eric Biggers
Hi André, On Wed, Jan 17, 2018 at 02:29:29PM +, André Draszik wrote: > Thanks Eric for the review! > > On Wed, 2018-01-10 at 20:00 -0800, Eric Biggers wrote: > > Hi André, > > > > On Wed, Jan 10, 2018 at 12:44:16PM +, André Draszik wrote: > > > This is heavily based on commit

Re: [PATCH net-next] net: core: Expose number of link up/down transitions

2018-01-17 Thread David Ahern
On 1/17/18 3:52 PM, Jiri Pirko wrote: > Thu, Jan 18, 2018 at 12:06:57AM CET, f.faine...@gmail.com wrote: >> From: David Decotigny >> >> Expose the number of times the link has been going UP or DOWN, and >> update the "carrier_changes" counter to be the sum of these two events.

Re: [PATCH net-next] net: core: Expose number of link up/down transitions

2018-01-17 Thread David Ahern
On 1/17/18 3:52 PM, Jiri Pirko wrote: > Thu, Jan 18, 2018 at 12:06:57AM CET, f.faine...@gmail.com wrote: >> From: David Decotigny >> >> Expose the number of times the link has been going UP or DOWN, and >> update the "carrier_changes" counter to be the sum of these two events. >> While at it,

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-17 Thread Wang, Haiyue
On 2018-01-17 23:59, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-17 Thread Wang, Haiyue
On 2018-01-17 23:59, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band

Re: remove pci_dma_* abuses and workarounds V2

2018-01-17 Thread Bjorn Helgaas
[+cc David] On Wed, Jan 10, 2018 at 07:03:18PM +0100, Christoph Hellwig wrote: > Back before the dawn of time pci_dma_* with a NULL pci_dev argument > was used for all kinds of things, e.g. dma mapping for non-PCI > devices. All this has been long removed, but it turns out we > still care for a

Re: remove pci_dma_* abuses and workarounds V2

2018-01-17 Thread Bjorn Helgaas
[+cc David] On Wed, Jan 10, 2018 at 07:03:18PM +0100, Christoph Hellwig wrote: > Back before the dawn of time pci_dma_* with a NULL pci_dev argument > was used for all kinds of things, e.g. dma mapping for non-PCI > devices. All this has been long removed, but it turns out we > still care for a

Re: [PATCH net-next] net: core: Expose number of link up/down transitions

2018-01-17 Thread Andrew Lunn
> What is the idea to have two separate counters? Can a delta between them > be a bigger than 1? Yes, it can. These counters are incremented in netif_carrier_on() / netif_carrier_off(). They are not always called in pairs and they can be called multiple times for the same event. The phylib will

Re: [PATCH 3/4] tsi108_eth: use dma API properly

2018-01-17 Thread Bjorn Helgaas
[+cc David, FYI, I plan to merge this via PCI along with the rest of Christoph's series] On Wed, Jan 10, 2018 at 07:03:21PM +0100, Christoph Hellwig wrote: > We need to pass a struct device to the dma API, even if some > architectures still support that for legacy reasons, and should not mix > it

Re: [PATCH net-next] net: core: Expose number of link up/down transitions

2018-01-17 Thread Andrew Lunn
> What is the idea to have two separate counters? Can a delta between them > be a bigger than 1? Yes, it can. These counters are incremented in netif_carrier_on() / netif_carrier_off(). They are not always called in pairs and they can be called multiple times for the same event. The phylib will

Re: [PATCH 3/4] tsi108_eth: use dma API properly

2018-01-17 Thread Bjorn Helgaas
[+cc David, FYI, I plan to merge this via PCI along with the rest of Christoph's series] On Wed, Jan 10, 2018 at 07:03:21PM +0100, Christoph Hellwig wrote: > We need to pass a struct device to the dma API, even if some > architectures still support that for legacy reasons, and should not mix > it

[PATCH 2/2] mm: Fix devm_memremap_pages() collision handling

2018-01-17 Thread Jan H . Schönherr
If devm_memremap_pages() detects a collision while adding entries to the radix-tree, we call pgmap_radix_release(). Unfortunately, the function removes *all* entries for the range -- including the entries that caused the collision in the first place. Modify pgmap_radix_release() to take an

[PATCH 2/2] mm: Fix devm_memremap_pages() collision handling

2018-01-17 Thread Jan H . Schönherr
If devm_memremap_pages() detects a collision while adding entries to the radix-tree, we call pgmap_radix_release(). Unfortunately, the function removes *all* entries for the range -- including the entries that caused the collision in the first place. Modify pgmap_radix_release() to take an

[PATCH 1/2] mm: Fix memory size alignment in devm_memremap_pages_release()

2018-01-17 Thread Jan H . Schönherr
The functions devm_memremap_pages() and devm_memremap_pages_release() use different ways to calculate the section-aligned amount of memory. The latter function may use an incorrect size if the memory region is small but straddles a section border. Use the same code for both. Fixes: 5f29a77cd957

[PATCH 1/2] mm: Fix memory size alignment in devm_memremap_pages_release()

2018-01-17 Thread Jan H . Schönherr
The functions devm_memremap_pages() and devm_memremap_pages_release() use different ways to calculate the section-aligned amount of memory. The latter function may use an incorrect size if the memory region is small but straddles a section border. Use the same code for both. Fixes: 5f29a77cd957

<    1   2   3   4   5   6   7   8   9   10   >